From: "hch@lst.de" <hch@lst.de>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Chaitanya Kulkarni <ckulkarnilinux@gmail.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"agk@redhat.com" <agk@redhat.com>,
"snitzer@kernel.org" <snitzer@kernel.org>,
"mpatocka@redhat.com" <mpatocka@redhat.com>,
"song@kernel.org" <song@kernel.org>,
"yukuai@fnnas.com" <yukuai@fnnas.com>, "hch@lst.de" <hch@lst.de>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"jaegeuk@kernel.org" <jaegeuk@kernel.org>,
"chao@kernel.org" <chao@kernel.org>,
"cem@kernel.org" <cem@kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dm-devel@lists.linux.dev" <dm-devel@lists.linux.dev>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-f2fs-devel@lists.sourceforge.net"
<linux-f2fs-devel@lists.sourceforge.net>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH V3 4/6] nvmet: ignore discard return value
Date: Mon, 26 Jan 2026 05:57:16 +0100 [thread overview]
Message-ID: <20260126045716.GA31683@lst.de> (raw)
In-Reply-To: <942ad29c-cff3-458f-b175-0111de821970@nvidia.com>
On Sat, Jan 24, 2026 at 09:35:16PM +0000, Chaitanya Kulkarni wrote:
> On 11/24/25 15:48, Chaitanya Kulkarni wrote:
> > __blkdev_issue_discard() always returns 0, making the error checking
> > in nvmet_bdev_discard_range() dead code.
> >
> > Kill the function nvmet_bdev_discard_range() and call
> > __blkdev_issue_discard() directly from nvmet_bdev_execute_discard(),
> > since no error handling is needed anymore for __blkdev_issue_discard()
> > call.
> >
> > Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> > Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > Signed-off-by: Chaitanya Kulkarni <ckulkarnilinux@gmail.com>
> > ---
>
> Gentle ping on this, can we apply this patch ?
Are we down to three patches now? Maybe resend the whole series and
get ACKs to merge everything through the block layer?
WARNING: multiple messages have this Message-ID (diff)
From: "hch@lst.de" <hch@lst.de>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: "cem@kernel.org" <cem@kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"song@kernel.org" <song@kernel.org>, "hch@lst.de" <hch@lst.de>,
"agk@redhat.com" <agk@redhat.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
Chaitanya Kulkarni <ckulkarnilinux@gmail.com>,
"dm-devel@lists.linux.dev" <dm-devel@lists.linux.dev>,
"snitzer@kernel.org" <snitzer@kernel.org>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"mpatocka@redhat.com" <mpatocka@redhat.com>,
"jaegeuk@kernel.org" <jaegeuk@kernel.org>,
"yukuai@fnnas.com" <yukuai@fnnas.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-f2fs-devel@lists.sourceforge.net"
<linux-f2fs-devel@lists.sourceforge.net>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>
Subject: Re: [f2fs-dev] [PATCH V3 4/6] nvmet: ignore discard return value
Date: Mon, 26 Jan 2026 05:57:16 +0100 [thread overview]
Message-ID: <20260126045716.GA31683@lst.de> (raw)
In-Reply-To: <942ad29c-cff3-458f-b175-0111de821970@nvidia.com>
On Sat, Jan 24, 2026 at 09:35:16PM +0000, Chaitanya Kulkarni wrote:
> On 11/24/25 15:48, Chaitanya Kulkarni wrote:
> > __blkdev_issue_discard() always returns 0, making the error checking
> > in nvmet_bdev_discard_range() dead code.
> >
> > Kill the function nvmet_bdev_discard_range() and call
> > __blkdev_issue_discard() directly from nvmet_bdev_execute_discard(),
> > since no error handling is needed anymore for __blkdev_issue_discard()
> > call.
> >
> > Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> > Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > Signed-off-by: Chaitanya Kulkarni <ckulkarnilinux@gmail.com>
> > ---
>
> Gentle ping on this, can we apply this patch ?
Are we down to three patches now? Maybe resend the whole series and
get ACKs to merge everything through the block layer?
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-01-26 4:57 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 23:48 [PATCH V3 0/6] block: ignore __blkdev_issue_discard() ret value Chaitanya Kulkarni
2025-11-24 23:48 ` [f2fs-dev] " Chaitanya Kulkarni
2025-11-24 23:48 ` [PATCH V3 1/6] block: ignore discard return value Chaitanya Kulkarni
2025-11-24 23:48 ` [f2fs-dev] " Chaitanya Kulkarni
2025-11-25 17:38 ` Jens Axboe
2025-11-25 17:38 ` [f2fs-dev] " Jens Axboe
2025-11-25 19:09 ` Chaitanya Kulkarni
2025-11-25 19:09 ` [f2fs-dev] " Chaitanya Kulkarni
2025-11-25 19:19 ` Jens Axboe
2025-11-25 19:19 ` [f2fs-dev] " Jens Axboe
2025-11-24 23:48 ` [PATCH V3 2/6] md: " Chaitanya Kulkarni
2025-11-24 23:48 ` [f2fs-dev] " Chaitanya Kulkarni
2025-12-01 6:22 ` Chaitanya Kulkarni
2026-01-24 21:29 ` Chaitanya Kulkarni
2025-11-24 23:48 ` [PATCH V3 3/6] dm: " Chaitanya Kulkarni
2025-11-24 23:48 ` [f2fs-dev] " Chaitanya Kulkarni
2025-12-01 6:23 ` Chaitanya Kulkarni
2025-12-01 21:07 ` Mikulas Patocka
2025-11-24 23:48 ` [PATCH V3 4/6] nvmet: " Chaitanya Kulkarni
2025-11-24 23:48 ` [f2fs-dev] " Chaitanya Kulkarni
2025-11-26 10:14 ` Yongpeng Yang
2025-11-26 10:14 ` Yongpeng Yang
2025-11-26 10:37 ` Christoph Hellwig
2025-11-26 10:37 ` Christoph Hellwig
2026-01-24 21:35 ` Chaitanya Kulkarni
2026-01-24 21:35 ` [f2fs-dev] " Chaitanya Kulkarni via Linux-f2fs-devel
2026-01-26 4:57 ` hch [this message]
2026-01-26 4:57 ` hch
2026-01-27 22:40 ` Chaitanya Kulkarni
2026-01-27 22:40 ` [f2fs-dev] " Chaitanya Kulkarni via Linux-f2fs-devel
2025-11-24 23:48 ` [PATCH V3 5/6] f2fs: " Chaitanya Kulkarni
2025-11-24 23:48 ` [f2fs-dev] " Chaitanya Kulkarni
2025-11-25 1:10 ` Chao Yu
2025-11-25 1:10 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-11-25 6:33 ` Christoph Hellwig
2025-11-25 6:33 ` [f2fs-dev] " Christoph Hellwig
2025-11-25 7:11 ` Chao Yu
2025-11-25 7:11 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-12-01 6:26 ` Chaitanya Kulkarni via Linux-f2fs-devel
2025-11-26 2:47 ` Chao Yu
2025-11-26 2:47 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-11-26 3:37 ` Chaitanya Kulkarni
2025-11-26 3:37 ` [f2fs-dev] " Chaitanya Kulkarni via Linux-f2fs-devel
2025-11-26 3:58 ` Chao Yu
2025-11-26 3:58 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-11-24 23:48 ` [PATCH V3 6/6] xfs: " Chaitanya Kulkarni
2025-11-24 23:48 ` [f2fs-dev] " Chaitanya Kulkarni
2025-11-26 2:37 ` Yongpeng Yang
2025-11-26 2:37 ` Yongpeng Yang
2025-11-26 8:07 ` Chaitanya Kulkarni
2025-11-26 8:07 ` Chaitanya Kulkarni via Linux-f2fs-devel
2025-11-26 9:14 ` Yongpeng Yang
2025-11-26 9:14 ` Yongpeng Yang
2025-11-26 9:48 ` Yongpeng Yang
2025-11-26 9:48 ` Yongpeng Yang
2025-11-26 10:34 ` hch
2025-11-26 10:34 ` hch
2025-11-26 10:33 ` Christoph Hellwig
2025-11-26 10:33 ` Christoph Hellwig
2025-12-01 6:28 ` Chaitanya Kulkarni
2025-12-01 12:20 ` Carlos Maiolino
2025-11-25 13:20 ` [PATCH V3 0/6] block: ignore __blkdev_issue_discard() ret value Anuj gupta
2025-11-25 13:20 ` [f2fs-dev] " Anuj gupta
2025-11-25 19:20 ` (subset) " Jens Axboe
2025-11-25 19:20 ` [f2fs-dev] " Jens Axboe
2025-12-03 21:50 ` [f2fs-dev] " patchwork-bot+f2fs
2025-12-03 21:50 ` patchwork-bot+f2fs--- via Linux-f2fs-devel
2025-12-09 17:18 ` patchwork-bot+f2fs
2025-12-09 17:18 ` patchwork-bot+f2fs--- via Linux-f2fs-devel
2025-12-16 0:50 ` patchwork-bot+f2fs
2025-12-16 0:50 ` patchwork-bot+f2fs--- via Linux-f2fs-devel
2026-02-17 21:14 ` patchwork-bot+f2fs
2026-02-17 21:14 ` patchwork-bot+f2fs--- via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260126045716.GA31683@lst.de \
--to=hch@lst.de \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=bpf@vger.kernel.org \
--cc=cem@kernel.org \
--cc=chaitanyak@nvidia.com \
--cc=chao@kernel.org \
--cc=ckulkarnilinux@gmail.com \
--cc=dm-devel@lists.linux.dev \
--cc=jaegeuk@kernel.org \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpatocka@redhat.com \
--cc=sagi@grimberg.me \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.