From: Eric Biggers <ebiggers@kernel.org>
To: fsverity@lists.linux.dev
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
Eric Biggers <ebiggers@kernel.org>
Subject: [PATCH v2 1/2] f2fs: use fsverity_verify_blocks() instead of fsverity_verify_page()
Date: Sat, 14 Feb 2026 13:18:29 -0800 [thread overview]
Message-ID: <20260214211830.15437-2-ebiggers@kernel.org> (raw)
In-Reply-To: <20260214211830.15437-1-ebiggers@kernel.org>
Replace the only remaining caller of fsverity_verify_page() with a
direct call to fsverity_verify_blocks(). This will allow
fsverity_verify_page() to be removed.
Make it large-folio-aware by using the page's offset in the folio
instead of 0, though the rest of f2fs_verify_cluster() and f2fs
decompression as a whole still assumes small folios.
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---
fs/f2fs/compress.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index 006a80acd1de..11c4de515f98 100644
--- a/fs/f2fs/compress.c
+++ b/fs/f2fs/compress.c
@@ -1811,15 +1811,19 @@ static void f2fs_verify_cluster(struct work_struct *work)
int i;
/* Verify, update, and unlock the decompressed pages. */
for (i = 0; i < dic->cluster_size; i++) {
struct page *rpage = dic->rpages[i];
+ struct folio *rfolio;
+ size_t offset;
if (!rpage)
continue;
+ rfolio = page_folio(rpage);
+ offset = folio_page_idx(rfolio, rpage) * PAGE_SIZE;
- if (fsverity_verify_page(dic->vi, rpage))
+ if (fsverity_verify_blocks(dic->vi, rfolio, PAGE_SIZE, offset))
SetPageUptodate(rpage);
else
ClearPageUptodate(rpage);
unlock_page(rpage);
}
--
2.53.0
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: fsverity@lists.linux.dev
Cc: linux-f2fs-devel@lists.sourceforge.net,
Eric Biggers <ebiggers@kernel.org>,
linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [f2fs-dev] [PATCH v2 1/2] f2fs: use fsverity_verify_blocks() instead of fsverity_verify_page()
Date: Sat, 14 Feb 2026 13:18:29 -0800 [thread overview]
Message-ID: <20260214211830.15437-2-ebiggers@kernel.org> (raw)
In-Reply-To: <20260214211830.15437-1-ebiggers@kernel.org>
Replace the only remaining caller of fsverity_verify_page() with a
direct call to fsverity_verify_blocks(). This will allow
fsverity_verify_page() to be removed.
Make it large-folio-aware by using the page's offset in the folio
instead of 0, though the rest of f2fs_verify_cluster() and f2fs
decompression as a whole still assumes small folios.
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---
fs/f2fs/compress.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index 006a80acd1de..11c4de515f98 100644
--- a/fs/f2fs/compress.c
+++ b/fs/f2fs/compress.c
@@ -1811,15 +1811,19 @@ static void f2fs_verify_cluster(struct work_struct *work)
int i;
/* Verify, update, and unlock the decompressed pages. */
for (i = 0; i < dic->cluster_size; i++) {
struct page *rpage = dic->rpages[i];
+ struct folio *rfolio;
+ size_t offset;
if (!rpage)
continue;
+ rfolio = page_folio(rpage);
+ offset = folio_page_idx(rfolio, rpage) * PAGE_SIZE;
- if (fsverity_verify_page(dic->vi, rpage))
+ if (fsverity_verify_blocks(dic->vi, rfolio, PAGE_SIZE, offset))
SetPageUptodate(rpage);
else
ClearPageUptodate(rpage);
unlock_page(rpage);
}
--
2.53.0
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-02-14 21:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-14 21:18 [PATCH v2 0/2] fsverity: remove fsverity_verify_page() Eric Biggers
2026-02-14 21:18 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-02-14 21:18 ` Eric Biggers [this message]
2026-02-14 21:18 ` [f2fs-dev] [PATCH v2 1/2] f2fs: use fsverity_verify_blocks() instead of fsverity_verify_page() Eric Biggers via Linux-f2fs-devel
2026-02-14 21:50 ` Eric Biggers
2026-02-14 21:50 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-02-14 22:20 ` Linus Torvalds
2026-02-14 22:20 ` [f2fs-dev] " Linus Torvalds
2026-02-15 3:38 ` Matthew Wilcox
2026-02-15 3:38 ` [f2fs-dev] " Matthew Wilcox
2026-02-15 4:11 ` Eric Biggers
2026-02-15 4:11 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-02-14 21:18 ` [PATCH v2 2/2] fsverity: remove fsverity_verify_page() Eric Biggers
2026-02-14 21:18 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260214211830.15437-2-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=chao@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.