All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, fam@euphon.net
Subject: Re: [PATCH 2/2] fdmon-io_uring: check CQ ring directly in gsource_check
Date: Wed, 18 Feb 2026 11:24:15 -0500	[thread overview]
Message-ID: <20260218162415.GD587447@fedora> (raw)
In-Reply-To: <20260213143225.161043-3-axboe@kernel.dk>

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

On Fri, Feb 13, 2026 at 07:26:37AM -0700, Jens Axboe wrote:
> gsource_check() only looks at the ppoll revents for the io_uring fd,
> but CQEs can be posted during gsource_prepare()'s io_uring_submit()
> call via kernel task_work processing on syscall exit. These completions
> are already sitting in the CQ ring but the ring fd may not be signaled
> yet, causing gsource_check() to return false.
> 
> Add a fallback io_uring_cq_ready() check so completions that arrive
> during submission are dispatched immediately rather than waiting for
> the next ppoll() cycle.
> 
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> ---
>  util/fdmon-io_uring.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2026-02-18 16:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13 14:26 [PATCHSET 0/2] io_uring fixes Jens Axboe
2026-02-13 14:26 ` [PATCH 1/2] fdmon-io_uring: notify main loop when SQEs are queued Jens Axboe
2026-02-13 16:04   ` Kevin Wolf
2026-02-18  9:57     ` Fiona Ebner
2026-02-18 16:06       ` Stefan Hajnoczi
2026-02-18 16:17         ` Jens Axboe
2026-02-18 20:02           ` Stefan Hajnoczi
2026-02-18 16:11       ` Stefan Hajnoczi
2026-02-18 16:19         ` Jens Axboe
2026-02-18 16:41           ` [PATCH v2] aio-posix: " Jens Axboe
2026-02-18 20:57             ` Stefan Hajnoczi
2026-02-19 14:27               ` Jens Axboe
2026-02-19 15:49             ` Kevin Wolf
2026-02-23 13:53               ` Stefan Hajnoczi
2026-02-18 15:56     ` [PATCH 1/2] fdmon-io_uring: " Stefan Hajnoczi
2026-02-13 14:26 ` [PATCH 2/2] fdmon-io_uring: check CQ ring directly in gsource_check Jens Axboe
2026-02-13 16:22   ` Kevin Wolf
2026-02-18 16:24   ` Stefan Hajnoczi [this message]
2026-02-18 10:07 ` [PATCHSET 0/2] io_uring fixes Fiona Ebner
2026-03-03 11:52 ` Fiona Ebner
2026-03-03 16:51   ` Jens Axboe
2026-03-08 12:11   ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260218162415.GD587447@fedora \
    --to=stefanha@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=fam@euphon.net \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.