From: Eric Biggers <ebiggers@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: "Theodore Y. Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Chao Yu <chao@kernel.org>, Christian Brauner <brauner@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/9] fscrypt: pass a byte offset to fscrypt_mergeable_bio
Date: Sat, 21 Feb 2026 11:44:02 -0800 [thread overview]
Message-ID: <20260221194402.GB2536@quark> (raw)
In-Reply-To: <20260218061531.3318130-3-hch@lst.de>
On Wed, Feb 18, 2026 at 07:14:40AM +0100, Christoph Hellwig wrote:
> Logical offsets into an inode are usually expresssed as bytes in the VFS.
expresssed => expressed, in all the commit messages
> /**
> * fscrypt_mergeable_bio_bh() - test whether data can be added to a bio
> * @bio: the bio being built up
> * @next_bh: the next buffer_head for which I/O will be submitted
> *
> * Same as fscrypt_mergeable_bio(), except this takes a buffer_head instead of
> * an inode and block number directly.
Above comment needs "block number" => "file position".
(Or "file offset" if you want. I think "file position" makes more
sense, given that the variable is called 'pos'. Either way, "block
number" is definitely wrong.)
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Christoph Hellwig <hch@lst.de>
Cc: Christian Brauner <brauner@kernel.org>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fscrypt@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 2/9] fscrypt: pass a byte offset to fscrypt_mergeable_bio
Date: Sat, 21 Feb 2026 11:44:02 -0800 [thread overview]
Message-ID: <20260221194402.GB2536@quark> (raw)
In-Reply-To: <20260218061531.3318130-3-hch@lst.de>
On Wed, Feb 18, 2026 at 07:14:40AM +0100, Christoph Hellwig wrote:
> Logical offsets into an inode are usually expresssed as bytes in the VFS.
expresssed => expressed, in all the commit messages
> /**
> * fscrypt_mergeable_bio_bh() - test whether data can be added to a bio
> * @bio: the bio being built up
> * @next_bh: the next buffer_head for which I/O will be submitted
> *
> * Same as fscrypt_mergeable_bio(), except this takes a buffer_head instead of
> * an inode and block number directly.
Above comment needs "block number" => "file position".
(Or "file offset" if you want. I think "file position" makes more
sense, given that the variable is called 'pos'. Either way, "block
number" is definitely wrong.)
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-02-21 19:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 6:14 fscrypt API cleanups Christoph Hellwig
2026-02-18 6:14 ` [f2fs-dev] " Christoph Hellwig
2026-02-18 6:14 ` [PATCH 1/9] fscrypt: pass a byte offset to fscrypt_generate_dun Christoph Hellwig
2026-02-18 6:14 ` [f2fs-dev] " Christoph Hellwig
2026-02-18 6:14 ` [PATCH 2/9] fscrypt: pass a byte offset to fscrypt_mergeable_bio Christoph Hellwig
2026-02-18 6:14 ` [f2fs-dev] " Christoph Hellwig
2026-02-21 19:44 ` Eric Biggers [this message]
2026-02-21 19:44 ` Eric Biggers via Linux-f2fs-devel
2026-02-18 6:14 ` [PATCH 3/9] fscrypt: pass a byte offset to fscrypt_set_bio_crypt_ctx Christoph Hellwig
2026-02-18 6:14 ` [f2fs-dev] " Christoph Hellwig
2026-02-21 19:45 ` Eric Biggers
2026-02-21 19:45 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-02-18 6:14 ` [PATCH 4/9] fscrypt: pass a byte offset to fscrypt_zeroout_range_inline_crypt Christoph Hellwig
2026-02-18 6:14 ` [f2fs-dev] " Christoph Hellwig
2026-02-18 6:14 ` [PATCH 5/9] fscrypt: pass a byte length " Christoph Hellwig
2026-02-18 6:14 ` [f2fs-dev] " Christoph Hellwig
2026-02-18 6:14 ` [PATCH 6/9] fscrypt: return a byte offset from bh_get_inode_and_lblk_num Christoph Hellwig
2026-02-18 6:14 ` [f2fs-dev] " Christoph Hellwig
2026-02-21 19:47 ` Eric Biggers
2026-02-21 19:47 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-02-18 6:14 ` [PATCH 7/9] fscrypt: pass a byte offset to fscrypt_zeroout_range Christoph Hellwig
2026-02-18 6:14 ` [f2fs-dev] " Christoph Hellwig
2026-02-21 19:49 ` Eric Biggers
2026-02-21 19:49 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-02-18 6:14 ` [PATCH 8/9] fscrypt: pass a byte length " Christoph Hellwig
2026-02-18 6:14 ` [f2fs-dev] " Christoph Hellwig
2026-02-21 19:56 ` Eric Biggers
2026-02-21 19:56 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-02-18 6:14 ` [PATCH 9/9] fscrypt: pass a real sector_t " Christoph Hellwig
2026-02-18 6:14 ` [f2fs-dev] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260221194402.GB2536@quark \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.