All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aadarsh Mandal <aadarshmandal9354@gmail.com>
To: luka.gejak@linux.dev
Cc: aadarshmandal9354@gmail.com, dan.carpenter@linaro.org,
	ethantidmore06@gmail.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
	straube.linux@gmail.com
Subject: [PATCH v4] staging: rtl8723bs: removed dead code
Date: Thu, 19 Mar 2026 19:41:09 +0530	[thread overview]
Message-ID: <20260319141109.7212-1-aadarshmandal9354@gmail.com> (raw)
In-Reply-To: <2A37C741-68A1-47E2-AB3D-833593B5C392@linux.dev>

- removed the dead code.

Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
---
v4:
 - removed the space insertion.
 - deleted the commented codes.
v3:
 - added the extra space that count as insertion.
 - removed unwanted addition.
v2:
 - accidently deleted the braces for the standalone code blocks {}.
 - deleted the reindented comment code, extra space.
v1:
 - reindented comment code,extra space remained.

 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 063a0737933e..96a0c8e304da 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -481,9 +481,6 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
 {
	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);

-	/*  Tx aggregation setting */
-/*	sdio_AggSettingTxUpdate(padapter); */
-
	/*  Rx aggregation setting */
	HalRxAggr8723BSdio(padapter);

@@ -635,9 +632,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
		return _SUCCESS;
	}

-	/*  Disable Interrupt first. */
-/*	rtw_hal_disable_interrupt(padapter); */
-
	ret = _InitPowerOn_8723BS(padapter);
	if (ret == _FAIL)
		return _FAIL;
@@ -656,8 +650,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)

	rtl8723b_InitializeFirmwareVars(padapter);

-/*	SIC_Init(padapter); */
-
	if (pwrctrlpriv->reg_rfoff)
		pwrctrlpriv->rf_pwrstate = rf_off;

@@ -740,11 +732,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
	rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel,
		CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET_DONT_CARE);

-	/*  Record original value for template. This is arough data, we can only use the data */
-	/*  for power adjust. The value can not be adjustde according to different power!!! */
-/*	pHalData->OriginalCckTxPwrIdx = pHalData->CurrentCckTxPwrIdx; */
-/*	pHalData->OriginalOfdm24GTxPwrIdx = pHalData->CurrentOfdm24GTxPwrIdx; */
-
	rtl8723b_InitAntenna_Selection(padapter);

	/*  */
@@ -786,8 +773,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
	/* ack for xmit mgmt frames. */
	rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ_CTRL) | BIT(12));

-/*	pHalData->PreRpwmVal = SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRPWM1) & 0x80; */
-
	{
		pwrctrlpriv->rf_pwrstate = rf_on;

@@ -1075,8 +1060,6 @@ static void _ReadPROMContent(struct adapter *padapter)
	pEEPROM->EepromOrEfuse = (eeValue & BOOT_FROM_EEPROM) ? true : false;
	pEEPROM->bautoload_fail_flag = (eeValue & EEPROM_EN) ? false : true;

-/*	pHalData->EEType = IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPROM_BOOT_EFUSE; */
-
	_ReadEfuseInfo8723BS(padapter);
 }

--
2.43.0

  parent reply	other threads:[~2026-03-19 14:11 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18  2:10 [PATCH] staging: rtl8723bs: fixed the trailing whitespaces/commented code Aadarsh Mandal
2026-03-18  6:52 ` Luka Gejak
2026-03-18  9:26   ` [PATCH] [PATCH] staging: rtl8723bs: clean up coding style in sdio_halinit.c V2 Aadarsh Mandal
2026-03-18  9:45     ` Luka Gejak
2026-03-18  9:53       ` Dan Carpenter
2026-03-18 10:43     ` [PATCH v3] staging: rtl8723bs: remove dead code Aadarsh Mandal
2026-03-18 11:17       ` Dan Carpenter
2026-03-18 11:33         ` Dan Carpenter
2026-03-18 11:37       ` Greg KH
2026-03-18  6:59 ` [PATCH] staging: rtl8723bs: fixed the trailing whitespaces/commented code Luka Gejak
2026-03-18 10:11   ` Greg KH
     [not found]     ` <CANQQrNO0GzqhYLj7DauWAoO=tVCz=86YaSjWWjAf-ER+UKmK6Q@mail.gmail.com>
2026-03-18 15:11       ` Greg KH
2026-03-18 17:54         ` Ethan Tidmore
2026-03-18 18:17           ` Greg KH
2026-03-18 21:06             ` Luka Gejak
2026-03-19  6:38               ` Greg KH
2026-03-19 14:11   ` Aadarsh Mandal [this message]
2026-03-20 14:46     ` [PATCH v5] staging: rtl8723bs: cleaned up patch formatting Aadarsh Mandal
2026-03-20 15:12       ` Luka Gejak
2026-03-19 14:12   ` [PATCH v4] staging: rtl8723bs: removed dead code Aadarsh Mandal
2026-03-19 14:18   ` Aadarsh Mandal
2026-03-19 17:46     ` Luka Gejak
2026-03-19 18:25     ` Ethan Tidmore
2026-03-19 18:26       ` Ethan Tidmore
2026-03-22 11:48 ` [PATCH v6] staging: rtl8723bs: remove commented-out code Aadarsh Mandal
2026-03-22 22:01   ` Ethan Tidmore
2026-03-23  8:47     ` Dan Carpenter
2026-03-24  4:07 ` [PATCH v7] " Aadarsh Mandal
2026-03-24  5:31   ` Luka Gejak
2026-03-24  6:54   ` Dan Carpenter
2026-03-24  8:12     ` Luka Gejak
2026-03-24  8:53       ` Dan Carpenter
     [not found]       ` <CANQQrNMNRuFw29zhckRYJ37Xf0YDXqZg9jnHgXznvNL=VfS7kA@mail.gmail.com>
2026-03-25  5:37         ` Luka Gejak
2026-03-28  3:31 ` [PATCH v8] " Aadarsh Mandal
2026-03-28 15:17   ` Luka Gejak
2026-03-31  8:38   ` Greg KH
2026-04-01  9:55 ` [PATCH v9] " Aadarsh Mandal
2026-04-01 17:38   ` Ethan Tidmore
2026-04-14  6:35 ` [PATCH v10] " Aadarsh Mandal
2026-04-14  7:10   ` Dan Carpenter
2026-04-14  7:35     ` Luka Gejak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260319141109.7212-1-aadarshmandal9354@gmail.com \
    --to=aadarshmandal9354@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=ethantidmore06@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=luka.gejak@linux.dev \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.