All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Aadarsh Mandal <aadarshmandal9354@gmail.com>
Cc: dan.carpenter@linaro.org, ethantidmore06@gmail.com,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
	luka.gejak@linux.dev, straube.linux@gmail.com
Subject: Re: [PATCH v8] staging: rtl8723bs: remove commented-out code
Date: Tue, 31 Mar 2026 10:38:05 +0200	[thread overview]
Message-ID: <2026033138-astute-rotten-9d06@gregkh> (raw)
In-Reply-To: <20260328033128.27946-1-aadarshmandal9354@gmail.com>

On Sat, Mar 28, 2026 at 09:01:28AM +0530, Aadarsh Mandal wrote:
> @@ -484,10 +474,7 @@ static void sdio_AggSettingRxUpdate(struct adapter *padapter)
>  
>  static void _initSdioAggregationSetting(struct adapter *padapter)
>  {
> -	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);
> -
> -	/*  Tx aggregation setting */
> -/* 	sdio_AggSettingTxUpdate(padapter); */
> +	struct hal_com_data *pHalData = GET_HAL_DATA(padapter);

Why did you reformat this line?

That's not a "remove commented-out code" change :(

thanks,

greg k-h

  parent reply	other threads:[~2026-03-31  8:38 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18  2:10 [PATCH] staging: rtl8723bs: fixed the trailing whitespaces/commented code Aadarsh Mandal
2026-03-18  6:52 ` Luka Gejak
2026-03-18  9:26   ` [PATCH] [PATCH] staging: rtl8723bs: clean up coding style in sdio_halinit.c V2 Aadarsh Mandal
2026-03-18  9:45     ` Luka Gejak
2026-03-18  9:53       ` Dan Carpenter
2026-03-18 10:43     ` [PATCH v3] staging: rtl8723bs: remove dead code Aadarsh Mandal
2026-03-18 11:17       ` Dan Carpenter
2026-03-18 11:33         ` Dan Carpenter
2026-03-18 11:37       ` Greg KH
2026-03-18  6:59 ` [PATCH] staging: rtl8723bs: fixed the trailing whitespaces/commented code Luka Gejak
2026-03-18 10:11   ` Greg KH
     [not found]     ` <CANQQrNO0GzqhYLj7DauWAoO=tVCz=86YaSjWWjAf-ER+UKmK6Q@mail.gmail.com>
2026-03-18 15:11       ` Greg KH
2026-03-18 17:54         ` Ethan Tidmore
2026-03-18 18:17           ` Greg KH
2026-03-18 21:06             ` Luka Gejak
2026-03-19  6:38               ` Greg KH
2026-03-19 14:11   ` [PATCH v4] staging: rtl8723bs: removed dead code Aadarsh Mandal
2026-03-20 14:46     ` [PATCH v5] staging: rtl8723bs: cleaned up patch formatting Aadarsh Mandal
2026-03-20 15:12       ` Luka Gejak
2026-03-19 14:12   ` [PATCH v4] staging: rtl8723bs: removed dead code Aadarsh Mandal
2026-03-19 14:18   ` Aadarsh Mandal
2026-03-19 17:46     ` Luka Gejak
2026-03-19 18:25     ` Ethan Tidmore
2026-03-19 18:26       ` Ethan Tidmore
2026-03-22 11:48 ` [PATCH v6] staging: rtl8723bs: remove commented-out code Aadarsh Mandal
2026-03-22 22:01   ` Ethan Tidmore
2026-03-23  8:47     ` Dan Carpenter
2026-03-24  4:07 ` [PATCH v7] " Aadarsh Mandal
2026-03-24  5:31   ` Luka Gejak
2026-03-24  6:54   ` Dan Carpenter
2026-03-24  8:12     ` Luka Gejak
2026-03-24  8:53       ` Dan Carpenter
     [not found]       ` <CANQQrNMNRuFw29zhckRYJ37Xf0YDXqZg9jnHgXznvNL=VfS7kA@mail.gmail.com>
2026-03-25  5:37         ` Luka Gejak
2026-03-28  3:31 ` [PATCH v8] " Aadarsh Mandal
2026-03-28 15:17   ` Luka Gejak
2026-03-31  8:38   ` Greg KH [this message]
2026-04-01  9:55 ` [PATCH v9] " Aadarsh Mandal
2026-04-01 17:38   ` Ethan Tidmore
2026-04-14  6:35 ` [PATCH v10] " Aadarsh Mandal
2026-04-14  7:10   ` Dan Carpenter
2026-04-14  7:35     ` Luka Gejak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026033138-astute-rotten-9d06@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=aadarshmandal9354@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=ethantidmore06@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=luka.gejak@linux.dev \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.