Re: [PATCH] riscv: dts: spacemit: drop incorrect pinctrl for combo PHY

From: Yixun Lan <dlan@kernel.org>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Chukun Pan <amadeus@jmu.edu.cn>,
	linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>, Alex Elder <elder@riscstar.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list:RISC-V ARCHITECTURE" <linux-riscv@lists.infradead.org>,
	"open list:RISC-V SPACEMIT SoC Support"
	<spacemit@lists.linux.dev>
Subject: Re: [PATCH] riscv: dts: spacemit: drop incorrect pinctrl for combo PHY
Date: Tue, 24 Mar 2026 14:05:24 +0800	[thread overview]
Message-ID: <20260324060524-GKA533070@kernel.org> (raw)
In-Reply-To: <20260322202502.2205755-1-aurelien@aurel32.net>

Hi Aurelien, 

On 21:25 Sun 22 Mar     , Aurelien Jarno wrote:
> The combo PHY on the Banana Pi F3 is used for the USB 3.0 port. The high
> speed differential lanes are always configured as such, and do not
> require a pinctrl entry.
> 
> The existing pinctrl entry only configures PCIe secondary pins, which
> are unused for USB and instead routed to the MIPI CSI1 connector.
> 
> Remove this incorrect pinctrl entry.
> 
> Fixes: 0be016a4b5d1b9 ("riscv: dts: spacemit: PCIe and PHY-related updates")
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Thanks for doing this, I thought Chukun was planing to submit a fix, CC him

Reviewed-by: Yixun Lan <dlan@kernel.org>

> ---
>  arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> index 404b69c47b91f..5790d927b93db 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> @@ -81,8 +81,6 @@ usb3_hub_5v: regulator-usb3-hub-5v {
>  };
>  
>  &combo_phy {
> -	pinctrl-names = "default";
> -	pinctrl-0 = <&pcie0_3_cfg>;
>  	status = "okay";
>  };
>  
> -- 
> 2.51.0
> 

-- 
Yixun Lan (dlan)