* [PATCH] riscv: dts: spacemit: drop incorrect pinctrl for combo PHY
@ 2026-03-22 20:25 ` Aurelien Jarno
0 siblings, 0 replies; 6+ messages in thread
From: Aurelien Jarno @ 2026-03-22 20:25 UTC (permalink / raw)
To: linux-kernel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
Yixun Lan, Alex Elder
Cc: Aurelien Jarno,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:RISC-V ARCHITECTURE,
open list:RISC-V SPACEMIT SoC Support
The combo PHY on the Banana Pi F3 is used for the USB 3.0 port. The high
speed differential lanes are always configured as such, and do not
require a pinctrl entry.
The existing pinctrl entry only configures PCIe secondary pins, which
are unused for USB and instead routed to the MIPI CSI1 connector.
Remove this incorrect pinctrl entry.
Fixes: 0be016a4b5d1b9 ("riscv: dts: spacemit: PCIe and PHY-related updates")
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
index 404b69c47b91f..5790d927b93db 100644
--- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
@@ -81,8 +81,6 @@ usb3_hub_5v: regulator-usb3-hub-5v {
};
&combo_phy {
- pinctrl-names = "default";
- pinctrl-0 = <&pcie0_3_cfg>;
status = "okay";
};
--
2.51.0
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] riscv: dts: spacemit: drop incorrect pinctrl for combo PHY
2026-03-22 20:25 ` Aurelien Jarno
@ 2026-03-24 6:05 ` Yixun Lan
-1 siblings, 0 replies; 6+ messages in thread
From: Yixun Lan @ 2026-03-24 6:05 UTC (permalink / raw)
To: Aurelien Jarno
Cc: Chukun Pan, linux-kernel, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Alexandre Ghiti, Alex Elder,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:RISC-V ARCHITECTURE,
open list:RISC-V SPACEMIT SoC Support
Hi Aurelien,
On 21:25 Sun 22 Mar , Aurelien Jarno wrote:
> The combo PHY on the Banana Pi F3 is used for the USB 3.0 port. The high
> speed differential lanes are always configured as such, and do not
> require a pinctrl entry.
>
> The existing pinctrl entry only configures PCIe secondary pins, which
> are unused for USB and instead routed to the MIPI CSI1 connector.
>
> Remove this incorrect pinctrl entry.
>
> Fixes: 0be016a4b5d1b9 ("riscv: dts: spacemit: PCIe and PHY-related updates")
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Thanks for doing this, I thought Chukun was planing to submit a fix, CC him
Reviewed-by: Yixun Lan <dlan@kernel.org>
> ---
> arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> index 404b69c47b91f..5790d927b93db 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> @@ -81,8 +81,6 @@ usb3_hub_5v: regulator-usb3-hub-5v {
> };
>
> &combo_phy {
> - pinctrl-names = "default";
> - pinctrl-0 = <&pcie0_3_cfg>;
> status = "okay";
> };
>
> --
> 2.51.0
>
--
Yixun Lan (dlan)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] riscv: dts: spacemit: drop incorrect pinctrl for combo PHY
@ 2026-03-24 6:05 ` Yixun Lan
0 siblings, 0 replies; 6+ messages in thread
From: Yixun Lan @ 2026-03-24 6:05 UTC (permalink / raw)
To: Aurelien Jarno
Cc: Chukun Pan, linux-kernel, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Alexandre Ghiti, Alex Elder,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:RISC-V ARCHITECTURE,
open list:RISC-V SPACEMIT SoC Support
Hi Aurelien,
On 21:25 Sun 22 Mar , Aurelien Jarno wrote:
> The combo PHY on the Banana Pi F3 is used for the USB 3.0 port. The high
> speed differential lanes are always configured as such, and do not
> require a pinctrl entry.
>
> The existing pinctrl entry only configures PCIe secondary pins, which
> are unused for USB and instead routed to the MIPI CSI1 connector.
>
> Remove this incorrect pinctrl entry.
>
> Fixes: 0be016a4b5d1b9 ("riscv: dts: spacemit: PCIe and PHY-related updates")
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Thanks for doing this, I thought Chukun was planing to submit a fix, CC him
Reviewed-by: Yixun Lan <dlan@kernel.org>
> ---
> arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> index 404b69c47b91f..5790d927b93db 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> @@ -81,8 +81,6 @@ usb3_hub_5v: regulator-usb3-hub-5v {
> };
>
> &combo_phy {
> - pinctrl-names = "default";
> - pinctrl-0 = <&pcie0_3_cfg>;
> status = "okay";
> };
>
> --
> 2.51.0
>
--
Yixun Lan (dlan)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] riscv: dts: spacemit: drop incorrect pinctrl for combo PHY
2026-03-22 20:25 ` Aurelien Jarno
@ 2026-03-24 6:54 ` Yixun Lan
-1 siblings, 0 replies; 6+ messages in thread
From: Yixun Lan @ 2026-03-24 6:54 UTC (permalink / raw)
To: linux-kernel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
Alex Elder, Aurelien Jarno
Cc: Yixun Lan, Chukun Pan, devicetree, linux-riscv, spacemit
On Sun, 22 Mar 2026 21:25:01 +0100, Aurelien Jarno wrote:
> The combo PHY on the Banana Pi F3 is used for the USB 3.0 port. The high
> speed differential lanes are always configured as such, and do not
> require a pinctrl entry.
>
> The existing pinctrl entry only configures PCIe secondary pins, which
> are unused for USB and instead routed to the MIPI CSI1 connector.
>
> [...]
Applied, thanks!
[1/1] riscv: dts: spacemit: drop incorrect pinctrl for combo PHY
https://github.com/spacemit-com/linux/commit/c68360c0d636dae71f766b7b296ddfcf2827ccc7
Best regards,
--
Yixun Lan <dlan@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] riscv: dts: spacemit: drop incorrect pinctrl for combo PHY
@ 2026-03-24 6:54 ` Yixun Lan
0 siblings, 0 replies; 6+ messages in thread
From: Yixun Lan @ 2026-03-24 6:54 UTC (permalink / raw)
To: linux-kernel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
Alex Elder, Aurelien Jarno
Cc: Yixun Lan, Chukun Pan, devicetree, linux-riscv, spacemit
On Sun, 22 Mar 2026 21:25:01 +0100, Aurelien Jarno wrote:
> The combo PHY on the Banana Pi F3 is used for the USB 3.0 port. The high
> speed differential lanes are always configured as such, and do not
> require a pinctrl entry.
>
> The existing pinctrl entry only configures PCIe secondary pins, which
> are unused for USB and instead routed to the MIPI CSI1 connector.
>
> [...]
Applied, thanks!
[1/1] riscv: dts: spacemit: drop incorrect pinctrl for combo PHY
https://github.com/spacemit-com/linux/commit/c68360c0d636dae71f766b7b296ddfcf2827ccc7
Best regards,
--
Yixun Lan <dlan@kernel.org>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread