From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: Aman Singh <aman.deep.singh@intel.com>
Cc: <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Raslan Darawsheh <rasland@nvidia.com>,
Stephen Hemminger <stephen@networkplumber.org>,
"Adrian Schollmeyer" <a.schollmeyer@syseleven.de>
Subject: [PATCH 2/2] app/testpmd: revert switch domain mismatch check
Date: Tue, 24 Mar 2026 13:37:09 +0100 [thread overview]
Message-ID: <20260324123709.3471-3-dsosnowski@nvidia.com> (raw)
In-Reply-To: <20260324123709.3471-1-dsosnowski@nvidia.com>
This reverts commit 8ebba91086f47c90e398d7775921e05659c0d62f.
Previous patch changed --rxq-share parameter logic.
If this parameter is passed, then unique share group index
per switch and Rx domain will be assigned to each shared Rx queue.
As a result the check for domain mismatch is not needed.
Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
---
app/test-pmd/testpmd.c | 39 ---------------------------------------
1 file changed, 39 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index be8e8299e3..5542ac9855 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2721,45 +2721,6 @@ rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,
uint32_t prev_hdrs = 0;
int ret;
- if (rx_conf->share_group > 0) {
- /* Check required switch info for Rx queue sharing */
- const uint16_t dom_id = ports[port_id].dev_info.switch_info.domain_id;
- const uint16_t rx_dom = ports[port_id].dev_info.switch_info.rx_domain;
-
- uint16_t pid;
- const char *mismatch = NULL;
- uint16_t mismatch_pid = (uint16_t)RTE_PORT_ALL;
-
- RTE_ETH_FOREACH_DEV(pid) {
- struct rte_port *o_port = &ports[pid];
- const uint16_t o_dom_id = o_port->dev_info.switch_info.domain_id;
- const uint16_t o_rx_dom = o_port->dev_info.switch_info.rx_domain;
-
- for (uint16_t q = 0; q < nb_rxq; ++q) {
- struct port_rxqueue *rxq = &o_port->rxq[q];
- if (rxq->conf.share_group != rx_conf->share_group ||
- rxq->conf.share_qid != rx_conf->share_qid)
- continue;
- if (o_dom_id == dom_id && o_rx_dom == rx_dom)
- continue;
-
- if (o_dom_id != dom_id)
- mismatch = "switch domain";
- else if (o_rx_dom != rx_dom)
- mismatch = "rx domain";
-
- mismatch_pid = pid;
- break;
- }
- }
-
- if (mismatch) {
- fprintf(stderr,
- "Invalid shared rxq config: %s mismatch between ports %u and %u\n",
- mismatch, port_id, mismatch_pid);
- return -EINVAL;
- }
- }
if ((rx_pkt_nb_segs > 1) &&
(rx_conf->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT)) {
--
2.47.3
next prev parent reply other threads:[~2026-03-24 12:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 12:37 [PATCH 0/2] app/testpmd: assign share group dynamically Dariusz Sosnowski
2026-03-24 12:37 ` [PATCH 1/2] " Dariusz Sosnowski
2026-03-24 15:15 ` Stephen Hemminger
2026-03-25 16:45 ` Stephen Hemminger
2026-03-24 12:37 ` Dariusz Sosnowski [this message]
2026-03-24 15:17 ` [PATCH 2/2] app/testpmd: revert switch domain mismatch check Stephen Hemminger
2026-03-24 16:56 ` [PATCH v2 0/2] app/testpmd: assign share group dynamically Dariusz Sosnowski
2026-03-24 16:56 ` [PATCH v2 1/2] " Dariusz Sosnowski
2026-03-25 16:49 ` Stephen Hemminger
2026-03-25 18:06 ` Dariusz Sosnowski
2026-03-25 16:50 ` Stephen Hemminger
2026-03-25 18:12 ` Dariusz Sosnowski
2026-03-24 16:56 ` [PATCH v2 2/2] app/testpmd: revert switch domain mismatch check Dariusz Sosnowski
2026-03-25 18:02 ` [PATCH v3 0/2] app/testpmd: assign share group dynamically Dariusz Sosnowski
2026-03-25 18:02 ` [PATCH v3 1/2] " Dariusz Sosnowski
2026-03-25 18:51 ` Stephen Hemminger
2026-03-25 19:11 ` Dariusz Sosnowski
2026-03-25 18:02 ` [PATCH v3 2/2] app/testpmd: revert switch domain mismatch check Dariusz Sosnowski
2026-03-25 19:09 ` [PATCH v4 0/2] app/testpmd: assign share group dynamically Dariusz Sosnowski
2026-03-25 19:09 ` [PATCH v4 1/2] " Dariusz Sosnowski
2026-03-25 19:09 ` [PATCH v4 2/2] app/testpmd: revert switch domain mismatch check Dariusz Sosnowski
2026-03-25 20:16 ` [PATCH v4 0/2] app/testpmd: assign share group dynamically Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260324123709.3471-3-dsosnowski@nvidia.com \
--to=dsosnowski@nvidia.com \
--cc=a.schollmeyer@syseleven.de \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=rasland@nvidia.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.