All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>
Cc: Aman Singh <aman.deep.singh@intel.com>, <dev@dpdk.org>,
	Thomas Monjalon <thomas@monjalon.net>,
	Raslan Darawsheh <rasland@nvidia.com>,
	"Adrian Schollmeyer" <a.schollmeyer@syseleven.de>
Subject: Re: [PATCH v4 0/2] app/testpmd: assign share group dynamically
Date: Wed, 25 Mar 2026 13:16:37 -0700	[thread overview]
Message-ID: <20260325131637.74f01067@phoenix.local> (raw)
In-Reply-To: <20260325190906.68531-1-dsosnowski@nvidia.com>

On Wed, 25 Mar 2026 20:09:04 +0100
Dariusz Sosnowski <dsosnowski@nvidia.com> wrote:

> Our internal regression tests have flagged issues with shared Rx queues.
> Specifically, issues with domain mismatches:
> 
> 	Invalid shared rxq config: switch domain mismatch ports 0 and 3
> 
> These started appearing after commit [1] which added checks
> for globally unique share group indexes.
> This could be worked around with --rxq-share=N option,
> but it does not allow proper testing of all use cases [2].
> 
> This patchset addresses that by changing behavior of --rxq-share parameter.
> Instead of relying on user to select proper parameter value,
> testpmd will dynamically assign globally unique share group index
> to each unique switch and Rx domain.
> 
> [1]: 8ebba91086f4 ("app/testpmd: fail on shared Rx queue switch mismatch")
> [2]: https://inbox.dpdk.org/dev/yotjxacqrodttraqrr3r6ftut4cty66g6cjnr5ughswtatapgh@gqqkftskp3qq/
> 
> v4:
> - Use short circuit return try_release_share_group().
> 
> v3:
> - Use short circuit return in assign_share_group().
> - Replace assert in assign_share_group() with error checking.
> - Do not require optional argument with --rxq-share option.
> - Fix typo in docs: update -> updates
> 
> v2:
> - Add releasing share groups when ports are closed.
> - Add static to share_group_slots array definition.
> - Remove double empty line in revert commit.
> 
> Dariusz Sosnowski (2):
>   app/testpmd: assign share group dynamically
>   app/testpmd: revert switch domain mismatch check
> 
>  app/test-pmd/parameters.c             |  14 +--
>  app/test-pmd/testpmd.c                | 121 ++++++++++++++++----------
>  app/test-pmd/testpmd.h                |   2 +-
>  doc/guides/testpmd_app_ug/run_app.rst |  10 +--
>  4 files changed, 86 insertions(+), 61 deletions(-)
> 
> --
> 2.47.3
> 

Applied to next-net thanks

      parent reply	other threads:[~2026-03-25 20:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24 12:37 [PATCH 0/2] app/testpmd: assign share group dynamically Dariusz Sosnowski
2026-03-24 12:37 ` [PATCH 1/2] " Dariusz Sosnowski
2026-03-24 15:15   ` Stephen Hemminger
2026-03-25 16:45   ` Stephen Hemminger
2026-03-24 12:37 ` [PATCH 2/2] app/testpmd: revert switch domain mismatch check Dariusz Sosnowski
2026-03-24 15:17   ` Stephen Hemminger
2026-03-24 16:56 ` [PATCH v2 0/2] app/testpmd: assign share group dynamically Dariusz Sosnowski
2026-03-24 16:56   ` [PATCH v2 1/2] " Dariusz Sosnowski
2026-03-25 16:49     ` Stephen Hemminger
2026-03-25 18:06       ` Dariusz Sosnowski
2026-03-25 16:50     ` Stephen Hemminger
2026-03-25 18:12       ` Dariusz Sosnowski
2026-03-24 16:56   ` [PATCH v2 2/2] app/testpmd: revert switch domain mismatch check Dariusz Sosnowski
2026-03-25 18:02   ` [PATCH v3 0/2] app/testpmd: assign share group dynamically Dariusz Sosnowski
2026-03-25 18:02     ` [PATCH v3 1/2] " Dariusz Sosnowski
2026-03-25 18:51       ` Stephen Hemminger
2026-03-25 19:11         ` Dariusz Sosnowski
2026-03-25 18:02     ` [PATCH v3 2/2] app/testpmd: revert switch domain mismatch check Dariusz Sosnowski
2026-03-25 19:09     ` [PATCH v4 0/2] app/testpmd: assign share group dynamically Dariusz Sosnowski
2026-03-25 19:09       ` [PATCH v4 1/2] " Dariusz Sosnowski
2026-03-25 19:09       ` [PATCH v4 2/2] app/testpmd: revert switch domain mismatch check Dariusz Sosnowski
2026-03-25 20:16       ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260325131637.74f01067@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=a.schollmeyer@syseleven.de \
    --cc=aman.deep.singh@intel.com \
    --cc=dev@dpdk.org \
    --cc=dsosnowski@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.