From: Stephen Hemminger <stephen@networkplumber.org>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>
Cc: Aman Singh <aman.deep.singh@intel.com>, <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
Raslan Darawsheh <rasland@nvidia.com>,
"Adrian Schollmeyer" <a.schollmeyer@syseleven.de>
Subject: Re: [PATCH v3 1/2] app/testpmd: assign share group dynamically
Date: Wed, 25 Mar 2026 11:51:27 -0700 [thread overview]
Message-ID: <20260325115127.0326795f@phoenix.local> (raw)
In-Reply-To: <20260325180255.57489-2-dsosnowski@nvidia.com>
On Wed, 25 Mar 2026 19:02:53 +0100
Dariusz Sosnowski <dsosnowski@nvidia.com> wrote:
> +static void
> +try_release_share_group(struct share_group_slot *slot)
> +{
> + uint16_t pi;
> + bool group_not_used = true;
> +
> + /* Check if any port still uses this share group. */
> + RTE_ETH_FOREACH_DEV(pi) {
> + if (ports[pi].dev_info.switch_info.domain_id == slot->domain_id &&
> + ports[pi].dev_info.switch_info.rx_domain == slot->rx_domain) {
> + group_not_used = false;
> + break;
> + }
> + }
> + if (group_not_used) {
> + slot->share_group = 0;
> + slot->domain_id = 0;
> + slot->rx_domain = 0;
> + }
> +}
Just add a return and skip the group_not_used boolean.
next prev parent reply other threads:[~2026-03-25 18:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 12:37 [PATCH 0/2] app/testpmd: assign share group dynamically Dariusz Sosnowski
2026-03-24 12:37 ` [PATCH 1/2] " Dariusz Sosnowski
2026-03-24 15:15 ` Stephen Hemminger
2026-03-25 16:45 ` Stephen Hemminger
2026-03-24 12:37 ` [PATCH 2/2] app/testpmd: revert switch domain mismatch check Dariusz Sosnowski
2026-03-24 15:17 ` Stephen Hemminger
2026-03-24 16:56 ` [PATCH v2 0/2] app/testpmd: assign share group dynamically Dariusz Sosnowski
2026-03-24 16:56 ` [PATCH v2 1/2] " Dariusz Sosnowski
2026-03-25 16:49 ` Stephen Hemminger
2026-03-25 18:06 ` Dariusz Sosnowski
2026-03-25 16:50 ` Stephen Hemminger
2026-03-25 18:12 ` Dariusz Sosnowski
2026-03-24 16:56 ` [PATCH v2 2/2] app/testpmd: revert switch domain mismatch check Dariusz Sosnowski
2026-03-25 18:02 ` [PATCH v3 0/2] app/testpmd: assign share group dynamically Dariusz Sosnowski
2026-03-25 18:02 ` [PATCH v3 1/2] " Dariusz Sosnowski
2026-03-25 18:51 ` Stephen Hemminger [this message]
2026-03-25 19:11 ` Dariusz Sosnowski
2026-03-25 18:02 ` [PATCH v3 2/2] app/testpmd: revert switch domain mismatch check Dariusz Sosnowski
2026-03-25 19:09 ` [PATCH v4 0/2] app/testpmd: assign share group dynamically Dariusz Sosnowski
2026-03-25 19:09 ` [PATCH v4 1/2] " Dariusz Sosnowski
2026-03-25 19:09 ` [PATCH v4 2/2] app/testpmd: revert switch domain mismatch check Dariusz Sosnowski
2026-03-25 20:16 ` [PATCH v4 0/2] app/testpmd: assign share group dynamically Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260325115127.0326795f@phoenix.local \
--to=stephen@networkplumber.org \
--cc=a.schollmeyer@syseleven.de \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.