From: Rob Woolley <rob.woolley@windriver.com>
To: <bitbake-devel@lists.openembedded.org>
Cc: <alex.kanavin@gmail.com>
Subject: [PATCH 03/11] bitbake-setup: Fix ambiguous variable names
Date: Thu, 26 Mar 2026 11:57:34 -0700 [thread overview]
Message-ID: <20260326185742.542268-4-rob.woolley@windriver.com> (raw)
In-Reply-To: <20260326185742.542268-1-rob.woolley@windriver.com>
The ruff lint tool detected use of ambiguous variables that
were named with a single letter:
E741 Ambiguous variable name: `l`
E741 Ambiguous variable name: `f`
This replaces the variables with a descriptive variable to add
clarity.
Signed-off-by: Rob Woolley <rob.woolley@windriver.com>
---
bin/bitbake-setup | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/bin/bitbake-setup b/bin/bitbake-setup
index 60d324b39..828459a00 100755
--- a/bin/bitbake-setup
+++ b/bin/bitbake-setup
@@ -231,11 +231,11 @@ bitbake-setup init -L {} /path/to/repo/checkout""".format(
if oesetupbuild:
links = {'setup-build': oesetupbuild, 'oe-scripts': os.path.dirname(oesetupbuild), 'oe-init-build-env-dir': oeinitbuildenvdir}
- for l,t in links.items():
- symlink = os.path.join(layerdir, l)
+ for link,item in links.items():
+ symlink = os.path.join(layerdir, link)
if os.path.lexists(symlink):
os.remove(symlink)
- os.symlink(os.path.relpath(t,layerdir),symlink)
+ os.symlink(os.path.relpath(item,layerdir),symlink)
return layers_fixed_revisions
@@ -244,19 +244,19 @@ def setup_bitbake_build(bitbake_config, layerdir, setupdir, thisdir, update_bb_c
os.makedirs(build_conf_dir)
layers_s = []
- for l in layers:
- l = os.path.join(layerdir, l)
- layers_s.append(" {} \\".format(l))
+ for layer in layers:
+ layer = os.path.join(layerdir, layer)
+ layers_s.append(" {} \\".format(layer))
- for l in filerelative_layers:
+ for layer in filerelative_layers:
if thisdir:
- l = os.path.join(thisdir, l)
+ layer = os.path.join(thisdir, layer)
else:
raise Exception("Configuration is using bb-layers-file-relative to specify " \
"a layer path relative to itself. This can be done only " \
"when the configuration is specified by its path on local " \
"disk, not when it's in a registry or is fetched over http.")
- layers_s.append(" {} \\".format(l))
+ layers_s.append(" {} \\".format(layer))
layers_s = "\n".join(layers_s)
bblayers_conf = """BBLAYERS ?= " \\
@@ -415,9 +415,9 @@ The bitbake configuration files (local.conf, bblayers.conf and more) can be foun
def get_registry_config(registry_path, id):
for root, _dirs, files in os.walk(registry_path):
- for f in files:
- if f.endswith('.conf.json') and id == get_config_name(f):
- return os.path.join(root, f)
+ for file in files:
+ if file.endswith('.conf.json') and id == get_config_name(file):
+ return os.path.join(root, file)
raise Exception("Unable to find {} in available configurations; use 'list' sub-command to see what is available".format(id))
def merge_overrides_into_sources(sources, overrides):
@@ -819,10 +819,10 @@ def list_registry(registry_path, with_expired):
json_data = {}
for root, _dirs, files in os.walk(registry_path):
- for f in files:
- if f.endswith('.conf.json'):
- config_name = get_config_name(f)
- config_data = json.load(open(os.path.join(root, f)))
+ for file in files:
+ if file.endswith('.conf.json'):
+ config_name = get_config_name(file)
+ config_data = json.load(open(os.path.join(root, file)))
config_desc = config_data["description"]
expiry_date = config_data.get("expires", None)
if expiry_date:
--
2.39.5
next prev parent reply other threads:[~2026-03-26 18:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 18:57 BitBake Linting Errors Rob Woolley
2026-03-26 18:57 ` [PATCH 01/11] bitbake-setup: Remove extraneous variable from str.format() Rob Woolley
2026-03-26 18:57 ` [PATCH 02/11] bitbake-setup: Resolve unused loop control variables Rob Woolley
2026-03-26 18:57 ` Rob Woolley [this message]
2026-03-26 18:57 ` [PATCH 04/11] bitbake-setup: Remove unused stdout variable Rob Woolley
2026-03-26 18:57 ` [PATCH 05/11] bitbake-setup: Replace f-string without placeholders Rob Woolley
2026-03-26 18:57 ` [PATCH 06/11] bitbake-setup: Remove unused Namespace import Rob Woolley
2026-03-26 18:57 ` [PATCH 07/11] bitbake-setup: Remove unused parser_settings_list Rob Woolley
2026-03-26 18:57 ` [PATCH 08/11] bitbake-setup: Fix linting error related to membership Rob Woolley
2026-03-26 18:57 ` [PATCH 09/11] bitbake-setup: Maintain exception chain Rob Woolley
2026-03-26 18:57 ` [PATCH 10/11] bitbake-setup: Set function default to None Rob Woolley
2026-03-30 16:34 ` [bitbake-devel] " adrian.freihofer
2026-03-30 21:49 ` Woolley, Rob
2026-03-30 22:51 ` Richard Purdie
2026-03-26 18:57 ` [PATCH 11/11] bitbake-setup: Sort and format imports Rob Woolley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326185742.542268-4-rob.woolley@windriver.com \
--to=rob.woolley@windriver.com \
--cc=alex.kanavin@gmail.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.