All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Woolley <rob.woolley@windriver.com>
To: <bitbake-devel@lists.openembedded.org>
Cc: <alex.kanavin@gmail.com>
Subject: [PATCH 07/11] bitbake-setup: Remove unused parser_settings_list
Date: Thu, 26 Mar 2026 11:57:38 -0700	[thread overview]
Message-ID: <20260326185742.542268-8-rob.woolley@windriver.com> (raw)
In-Reply-To: <20260326185742.542268-1-rob.woolley@windriver.com>

The ruff lint tool detected an used variable:

    F841 Local variable `parser_settings_list` is assigned to but never used

The list_settings function  gets invoked through the parent command's
settings_func function. This means that creating this variable is
unnecessary.

Signed-off-by: Rob Woolley <rob.woolley@windriver.com>
---
 bin/bitbake-setup | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/bin/bitbake-setup b/bin/bitbake-setup
index 00be16438..7cc3f9253 100755
--- a/bin/bitbake-setup
+++ b/bin/bitbake-setup
@@ -1109,8 +1109,7 @@ def main():
 
     subparser_settings = parser_settings.add_subparsers(dest="subcommand", required=True, help="The action to perform on the settings file")
 
-    parser_settings_list = subparser_settings.add_parser('list',
-                                                         help="List all settings with their values")
+    subparser_settings.add_parser('list', help="List all settings with their values")
 
     parser_settings_set = subparser_settings.add_parser('set', parents=[parser_settings_arg_global],
                                                         help="In a Section, set a setting to a certain value")
-- 
2.39.5



  parent reply	other threads:[~2026-03-26 18:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 18:57 BitBake Linting Errors Rob Woolley
2026-03-26 18:57 ` [PATCH 01/11] bitbake-setup: Remove extraneous variable from str.format() Rob Woolley
2026-03-26 18:57 ` [PATCH 02/11] bitbake-setup: Resolve unused loop control variables Rob Woolley
2026-03-26 18:57 ` [PATCH 03/11] bitbake-setup: Fix ambiguous variable names Rob Woolley
2026-03-26 18:57 ` [PATCH 04/11] bitbake-setup: Remove unused stdout variable Rob Woolley
2026-03-26 18:57 ` [PATCH 05/11] bitbake-setup: Replace f-string without placeholders Rob Woolley
2026-03-26 18:57 ` [PATCH 06/11] bitbake-setup: Remove unused Namespace import Rob Woolley
2026-03-26 18:57 ` Rob Woolley [this message]
2026-03-26 18:57 ` [PATCH 08/11] bitbake-setup: Fix linting error related to membership Rob Woolley
2026-03-26 18:57 ` [PATCH 09/11] bitbake-setup: Maintain exception chain Rob Woolley
2026-03-26 18:57 ` [PATCH 10/11] bitbake-setup: Set function default to None Rob Woolley
2026-03-30 16:34   ` [bitbake-devel] " adrian.freihofer
2026-03-30 21:49     ` Woolley, Rob
2026-03-30 22:51       ` Richard Purdie
2026-03-26 18:57 ` [PATCH 11/11] bitbake-setup: Sort and format imports Rob Woolley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260326185742.542268-8-rob.woolley@windriver.com \
    --to=rob.woolley@windriver.com \
    --cc=alex.kanavin@gmail.com \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.