From: Daiki Harada <daiky0325@gmail.com>
To: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Daiki Harada <daiky0325@gmail.com>, Kohei Enju <kohei@enjuk.jp>
Subject: [Intel-wired-lan] [PATCH iwl-next v1 1/2] igb: use napi_schedule_irqoff() instead of napi_schedule()
Date: Tue, 31 Mar 2026 10:39:19 +0000 [thread overview]
Message-ID: <20260331103924.36422-2-daiky0325@gmail.com> (raw)
In-Reply-To: <20260331103924.36422-1-daiky0325@gmail.com>
Replace napi_schedule() with napi_schedule_irqoff()
in the interrupt handler path in igb driver
Tested on QEMU with igb NIC emulation (-nic user,model=igb)
Suggested-by: Kohei Enju <kohei@enjuk.jp>
Signed-off-by: Daiki Harada <daiky0325@gmail.com>
---
drivers/net/ethernet/intel/igb/igb_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index ee99fd8fd513..d7a6ae938cc5 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -7158,7 +7158,7 @@ static irqreturn_t igb_msix_ring(int irq, void *data)
/* Write the ITR value calculated from the previous interrupt. */
igb_write_itr(q_vector);
- napi_schedule(&q_vector->napi);
+ napi_schedule_irqoff(&q_vector->napi);
return IRQ_HANDLED;
}
@@ -8199,7 +8199,7 @@ static irqreturn_t igb_intr_msi(int irq, void *data)
if (icr & E1000_ICR_TS)
igb_tsync_interrupt(adapter);
- napi_schedule(&q_vector->napi);
+ napi_schedule_irqoff(&q_vector->napi);
return IRQ_HANDLED;
}
@@ -8245,7 +8245,7 @@ static irqreturn_t igb_intr(int irq, void *data)
if (icr & E1000_ICR_TS)
igb_tsync_interrupt(adapter);
- napi_schedule(&q_vector->napi);
+ napi_schedule_irqoff(&q_vector->napi);
return IRQ_HANDLED;
}
--
2.53.0
WARNING: multiple messages have this Message-ID (diff)
From: Daiki Harada <daiky0325@gmail.com>
To: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Daiki Harada <daiky0325@gmail.com>, Kohei Enju <kohei@enjuk.jp>
Subject: [PATCH iwl-next v1 1/2] igb: use napi_schedule_irqoff() instead of napi_schedule()
Date: Tue, 31 Mar 2026 10:39:19 +0000 [thread overview]
Message-ID: <20260331103924.36422-2-daiky0325@gmail.com> (raw)
In-Reply-To: <20260331103924.36422-1-daiky0325@gmail.com>
Replace napi_schedule() with napi_schedule_irqoff()
in the interrupt handler path in igb driver
Tested on QEMU with igb NIC emulation (-nic user,model=igb)
Suggested-by: Kohei Enju <kohei@enjuk.jp>
Signed-off-by: Daiki Harada <daiky0325@gmail.com>
---
drivers/net/ethernet/intel/igb/igb_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index ee99fd8fd513..d7a6ae938cc5 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -7158,7 +7158,7 @@ static irqreturn_t igb_msix_ring(int irq, void *data)
/* Write the ITR value calculated from the previous interrupt. */
igb_write_itr(q_vector);
- napi_schedule(&q_vector->napi);
+ napi_schedule_irqoff(&q_vector->napi);
return IRQ_HANDLED;
}
@@ -8199,7 +8199,7 @@ static irqreturn_t igb_intr_msi(int irq, void *data)
if (icr & E1000_ICR_TS)
igb_tsync_interrupt(adapter);
- napi_schedule(&q_vector->napi);
+ napi_schedule_irqoff(&q_vector->napi);
return IRQ_HANDLED;
}
@@ -8245,7 +8245,7 @@ static irqreturn_t igb_intr(int irq, void *data)
if (icr & E1000_ICR_TS)
igb_tsync_interrupt(adapter);
- napi_schedule(&q_vector->napi);
+ napi_schedule_irqoff(&q_vector->napi);
return IRQ_HANDLED;
}
--
2.53.0
next prev parent reply other threads:[~2026-03-31 15:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 10:39 [Intel-wired-lan] [PATCH iwl-next v1 0/2] igb/igc: use napi_schedule_irqoff() instead of napi_schedule() Daiki Harada
2026-03-31 10:39 ` Daiki Harada
2026-03-31 10:39 ` Daiki Harada [this message]
2026-03-31 10:39 ` [PATCH iwl-next v1 1/2] igb: " Daiki Harada
2026-04-01 7:52 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-04-01 7:52 ` Loktionov, Aleksandr
2026-05-12 6:16 ` Rinitha, SX
2026-05-12 6:16 ` Rinitha, SX
2026-03-31 10:39 ` [Intel-wired-lan] [PATCH iwl-next v1 2/2] igc: " Daiki Harada
2026-03-31 10:39 ` Daiki Harada
2026-04-01 7:53 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-04-01 7:53 ` Loktionov, Aleksandr
2026-04-05 8:21 ` Ruinskiy, Dima
2026-05-14 7:38 ` Kadosh, MoriyaX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331103924.36422-2-daiky0325@gmail.com \
--to=daiky0325@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kohei@enjuk.jp \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.