From: Mohamed Mediouni <mohamed@unpredictable.fr>
To: qemu-devel@nongnu.org
Cc: Mohamed Mediouni <mohamed@unpredictable.fr>,
Zhao Liu <zhao1.liu@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Pedro Barbuda <pbarbuda@microsoft.com>
Subject: [PATCH v2 06/10] target: i386: HLT type that ignores EFLAGS.IF
Date: Wed, 15 Apr 2026 15:29:22 +0200 [thread overview]
Message-ID: <20260415132926.58878-7-mohamed@unpredictable.fr> (raw)
In-Reply-To: <20260415132926.58878-1-mohamed@unpredictable.fr>
The TLFS says:
> A partition which possesses the AccessGuestIdleMsr privilege may trigger
> entry into the virtual processor idle sleep state through a read to the
> hypervisor-defined MSR HV_X64_MSR_GUEST_IDLE. The virtual processor will
> be woken when an interrupt arrives, regardless of whether the interrupt
> is enabled on the virtual processor or not.
Meanwhile, Windows 24H2+ calls this MSR anyway without the privilege being set.
Add the infrastructure to support it on the generic QEMU side.
Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>
---
target/i386/cpu.c | 10 ++++++----
target/i386/cpu.h | 2 ++
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 0000093fa3..b18e40666e 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -10482,13 +10482,15 @@ int x86_cpu_pending_interrupt(CPUState *cs, int interrupt_request)
(((env->hflags2 & HF2_VINTR_MASK) &&
(env->hflags2 & HF2_HIF_MASK)) ||
(!(env->hflags2 & HF2_VINTR_MASK) &&
- (env->eflags & IF_MASK &&
- !(env->hflags & HF_INHIBIT_IRQ_MASK))))) {
+ ((env->eflags & IF_MASK &&
+ !(env->hflags & HF_INHIBIT_IRQ_MASK))
+ || env->hflags2 & HF2_HYPERV_HLT_MASK)))) {
return CPU_INTERRUPT_HARD;
} else if (env->hflags2 & HF2_VGIF_MASK) {
if((interrupt_request & CPU_INTERRUPT_VIRQ) &&
- (env->eflags & IF_MASK) &&
- !(env->hflags & HF_INHIBIT_IRQ_MASK)) {
+ ((env->eflags & IF_MASK &&
+ !(env->hflags & HF_INHIBIT_IRQ_MASK))
+ || env->hflags2 & HF2_HYPERV_HLT_MASK)) {
return CPU_INTERRUPT_VIRQ;
}
}
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
index 0b539155c4..67f508dc10 100644
--- a/target/i386/cpu.h
+++ b/target/i386/cpu.h
@@ -225,6 +225,7 @@ typedef enum X86Seg {
#define HF2_NPT_SHIFT 6 /* Nested Paging enabled */
#define HF2_IGNNE_SHIFT 7 /* Ignore CR0.NE=0 */
#define HF2_VGIF_SHIFT 8 /* Can take VIRQ*/
+#define HF2_HYPERV_HLT_SHIFT 9 /* Hyper-V HV_X64_MSR_GUEST_IDLE */
#define HF2_GIF_MASK (1 << HF2_GIF_SHIFT)
#define HF2_HIF_MASK (1 << HF2_HIF_SHIFT)
@@ -235,6 +236,7 @@ typedef enum X86Seg {
#define HF2_NPT_MASK (1 << HF2_NPT_SHIFT)
#define HF2_IGNNE_MASK (1 << HF2_IGNNE_SHIFT)
#define HF2_VGIF_MASK (1 << HF2_VGIF_SHIFT)
+#define HF2_HYPERV_HLT_MASK (1 << HF2_HYPERV_HLT_SHIFT)
#define CR0_PE_SHIFT 0
#define CR0_MP_SHIFT 1
--
2.50.1 (Apple Git-155)
next prev parent reply other threads:[~2026-04-15 13:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 13:29 [PATCH v2 00/10] whpx: i386: Some more changes Mohamed Mediouni
2026-04-15 13:29 ` [PATCH v2 01/10] whpx: i386: set apicbase value only on success Mohamed Mediouni
2026-04-15 13:29 ` [PATCH v2 02/10] whpx: i386: unknown MSR configurability Mohamed Mediouni
2026-04-15 13:29 ` [PATCH v2 03/10] whpx: i386: enable GuestIdleReg enlightenment Mohamed Mediouni
2026-04-15 13:29 ` [PATCH v2 04/10] whpx: i386: tighten APIC base validity check Mohamed Mediouni
2026-04-15 13:29 ` [PATCH v2 05/10] whpx: i386: ignore vpassist when kernel-irqchip=off Mohamed Mediouni
2026-04-15 13:29 ` Mohamed Mediouni [this message]
2026-04-15 13:29 ` [PATCH v2 07/10] whpx: i386: add HV_X64_MSR_GUEST_IDLE when !kernel-irqchip Mohamed Mediouni
2026-04-15 13:29 ` [PATCH v2 08/10] whpx: i386: one more CPUID Mohamed Mediouni
2026-04-15 13:29 ` [PATCH v2 09/10] whpx: i386: some x2APIC awareness Mohamed Mediouni
2026-04-15 13:29 ` [PATCH v2 10/10] whpx: i386: set WHvX64RegisterInitialApicId Mohamed Mediouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260415132926.58878-7-mohamed@unpredictable.fr \
--to=mohamed@unpredictable.fr \
--cc=pbarbuda@microsoft.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.