From: Simon Horman <horms@kernel.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org,
Tomasz Lichwala <tomasz.lichwala@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net 1/4] ice: fix asymmetric pause negotiation reporting in ethtool
Date: Mon, 20 Apr 2026 16:40:10 +0100 [thread overview]
Message-ID: <20260420154010.GS280379@horms.kernel.org> (raw)
In-Reply-To: <20260417062954.1241900-2-aleksandr.loktionov@intel.com>
On Fri, Apr 17, 2026 at 08:29:51AM +0200, Aleksandr Loktionov wrote:
> From: Tomasz Lichwala <tomasz.lichwala@intel.com>
>
> Add Asym_Pause to the supported link modes so that asymmetric pause
> negotiation is properly reported via ethtool. Without Asym_Pause in
> the supported modes, 'ethtool -a' incorrectly shows 'RX/TX negotiated: off'
> for asymmetric pause configurations, even when pause is properly
> negotiated and functional at the hardware level.
>
> Fixes: 5a056cd7ead2 ("ice: add lp_advertising flow control support")
> Signed-off-by: Tomasz Lichwala <tomasz.lichwala@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org,
Tomasz Lichwala <tomasz.lichwala@intel.com>
Subject: Re: [PATCH iwl-net 1/4] ice: fix asymmetric pause negotiation reporting in ethtool
Date: Mon, 20 Apr 2026 16:40:10 +0100 [thread overview]
Message-ID: <20260420154010.GS280379@horms.kernel.org> (raw)
In-Reply-To: <20260417062954.1241900-2-aleksandr.loktionov@intel.com>
On Fri, Apr 17, 2026 at 08:29:51AM +0200, Aleksandr Loktionov wrote:
> From: Tomasz Lichwala <tomasz.lichwala@intel.com>
>
> Add Asym_Pause to the supported link modes so that asymmetric pause
> negotiation is properly reported via ethtool. Without Asym_Pause in
> the supported modes, 'ethtool -a' incorrectly shows 'RX/TX negotiated: off'
> for asymmetric pause configurations, even when pause is properly
> negotiated and functional at the hardware level.
>
> Fixes: 5a056cd7ead2 ("ice: add lp_advertising flow control support")
> Signed-off-by: Tomasz Lichwala <tomasz.lichwala@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-04-20 15:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 6:29 [Intel-wired-lan] [PATCH iwl-net 0/4] ice: fixes for pause reporting, autoneg, RDMA and EIPE Aleksandr Loktionov
2026-04-17 6:29 ` Aleksandr Loktionov
2026-04-17 6:29 ` [Intel-wired-lan] [PATCH iwl-net 1/4] ice: fix asymmetric pause negotiation reporting in ethtool Aleksandr Loktionov
2026-04-17 6:29 ` Aleksandr Loktionov
2026-04-20 15:40 ` Simon Horman [this message]
2026-04-20 15:40 ` Simon Horman
2026-04-17 6:29 ` [Intel-wired-lan] [PATCH iwl-net 2/4] ice: fix autoneg disable when link partner doesn't support AN Aleksandr Loktionov
2026-04-17 6:29 ` Aleksandr Loktionov
2026-04-20 15:54 ` [Intel-wired-lan] " Simon Horman
2026-04-20 15:54 ` Simon Horman
2026-04-17 6:29 ` [Intel-wired-lan] [PATCH iwl-net 3/4] ice: support RDMA on 4+-port E830 devices Aleksandr Loktionov
2026-04-17 6:29 ` Aleksandr Loktionov
2026-04-20 15:56 ` [Intel-wired-lan] " Simon Horman
2026-04-20 15:56 ` Simon Horman
2026-04-17 6:29 ` [Intel-wired-lan] [PATCH iwl-net 4/4] ice: report EIPE checksum errors to the OS on E830 Aleksandr Loktionov
2026-04-17 6:29 ` Aleksandr Loktionov
2026-04-20 15:57 ` [Intel-wired-lan] " Simon Horman
2026-04-20 15:57 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260420154010.GS280379@horms.kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=tomasz.lichwala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.