From: Simon Horman <horms@kernel.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, Jan Glaza <jan.glaza@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net 4/4] ice: report EIPE checksum errors to the OS on E830
Date: Mon, 20 Apr 2026 16:57:30 +0100 [thread overview]
Message-ID: <20260420155730.GU280379@horms.kernel.org> (raw)
In-Reply-To: <20260417062954.1241900-5-aleksandr.loktionov@intel.com>
On Fri, Apr 17, 2026 at 08:29:54AM +0200, Aleksandr Loktionov wrote:
> From: Jan Glaza <jan.glaza@intel.com>
>
> For E830 adapters the hardware-reported EIPE (Ethernet Inline IPsec
> Engine) error is a reliable indication that a received packet failed
> decryption and has a bad checksum. Route EIPE errors through the
> generic checksum error path on E830 so the error is visible via
> standard ethtool statistics (rx_csum_bad).
>
> On previous devices (E810, E82X) the EIPE flag can be spuriously set
> on encapsulated packets with inner L2 padding, so those adapters only
> increment the driver-private hw_rx_eipe_error counter without routing
> through the checksum error path.
>
> Fixes: 0ca6755f3cc2 ("ice: Add a new counter for Rx EIPE errors")
> Signed-off-by: Jan Glaza <jan.glaza@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Sashiko has provided review of this patch. However, I don't believe any of
the issues flagged there should block progress of this patch.
You may wish to look over that review for possible follow-up activity.
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, Jan Glaza <jan.glaza@intel.com>
Subject: Re: [PATCH iwl-net 4/4] ice: report EIPE checksum errors to the OS on E830
Date: Mon, 20 Apr 2026 16:57:30 +0100 [thread overview]
Message-ID: <20260420155730.GU280379@horms.kernel.org> (raw)
In-Reply-To: <20260417062954.1241900-5-aleksandr.loktionov@intel.com>
On Fri, Apr 17, 2026 at 08:29:54AM +0200, Aleksandr Loktionov wrote:
> From: Jan Glaza <jan.glaza@intel.com>
>
> For E830 adapters the hardware-reported EIPE (Ethernet Inline IPsec
> Engine) error is a reliable indication that a received packet failed
> decryption and has a bad checksum. Route EIPE errors through the
> generic checksum error path on E830 so the error is visible via
> standard ethtool statistics (rx_csum_bad).
>
> On previous devices (E810, E82X) the EIPE flag can be spuriously set
> on encapsulated packets with inner L2 padding, so those adapters only
> increment the driver-private hw_rx_eipe_error counter without routing
> through the checksum error path.
>
> Fixes: 0ca6755f3cc2 ("ice: Add a new counter for Rx EIPE errors")
> Signed-off-by: Jan Glaza <jan.glaza@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Sashiko has provided review of this patch. However, I don't believe any of
the issues flagged there should block progress of this patch.
You may wish to look over that review for possible follow-up activity.
next prev parent reply other threads:[~2026-04-20 15:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 6:29 [Intel-wired-lan] [PATCH iwl-net 0/4] ice: fixes for pause reporting, autoneg, RDMA and EIPE Aleksandr Loktionov
2026-04-17 6:29 ` Aleksandr Loktionov
2026-04-17 6:29 ` [Intel-wired-lan] [PATCH iwl-net 1/4] ice: fix asymmetric pause negotiation reporting in ethtool Aleksandr Loktionov
2026-04-17 6:29 ` Aleksandr Loktionov
2026-04-20 15:40 ` [Intel-wired-lan] " Simon Horman
2026-04-20 15:40 ` Simon Horman
2026-04-17 6:29 ` [Intel-wired-lan] [PATCH iwl-net 2/4] ice: fix autoneg disable when link partner doesn't support AN Aleksandr Loktionov
2026-04-17 6:29 ` Aleksandr Loktionov
2026-04-20 15:54 ` [Intel-wired-lan] " Simon Horman
2026-04-20 15:54 ` Simon Horman
2026-04-17 6:29 ` [Intel-wired-lan] [PATCH iwl-net 3/4] ice: support RDMA on 4+-port E830 devices Aleksandr Loktionov
2026-04-17 6:29 ` Aleksandr Loktionov
2026-04-20 15:56 ` [Intel-wired-lan] " Simon Horman
2026-04-20 15:56 ` Simon Horman
2026-04-17 6:29 ` [Intel-wired-lan] [PATCH iwl-net 4/4] ice: report EIPE checksum errors to the OS on E830 Aleksandr Loktionov
2026-04-17 6:29 ` Aleksandr Loktionov
2026-04-20 15:57 ` Simon Horman [this message]
2026-04-20 15:57 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260420155730.GU280379@horms.kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jan.glaza@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.