All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <cel@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>,
	 Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	 linux-xfs@vger.kernel.org, linux-cifs@vger.kernel.org,
	 linux-nfs@vger.kernel.org, linux-api@vger.kernel.org,
	 linux-f2fs-devel@lists.sourceforge.net,
	hirofumi@mail.parknet.co.jp,  linkinjeon@kernel.org,
	sj1557.seo@samsung.com, yuezhang.mo@sony.com,
	 almaz.alexandrovich@paragon-software.com, slava@dubeyko.com,
	 glaubitz@physik.fu-berlin.de, frank.li@vivo.com, tytso@mit.edu,
	 adilger.kernel@dilger.ca, cem@kernel.org, sfrench@samba.org,
	 pc@manguebit.org, ronniesahlberg@gmail.com,
	sprasad@microsoft.com,  trondmy@kernel.org, anna@kernel.org,
	jaegeuk@kernel.org, chao@kernel.org,  hansg@kernel.org,
	senozhatsky@chromium.org,  Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v9 15/17] nfsd: Report export case-folding via NFSv3 PATHCONF
Date: Wed, 22 Apr 2026 19:30:09 -0400	[thread overview]
Message-ID: <20260422-case-sensitivity-v9-15-be023cc070e2@oracle.com> (raw)
In-Reply-To: <20260422-case-sensitivity-v9-0-be023cc070e2@oracle.com>

From: Chuck Lever <chuck.lever@oracle.com>

The hard-coded MSDOS_SUPER_MAGIC check in nfsd3_proc_pathconf()
only recognizes FAT filesystems as case-insensitive. Modern
filesystems like F2FS, exFAT, and CIFS support case-insensitive
directories, but NFSv3 clients cannot discover this capability.

Query the export's actual case behavior through ->fileattr_get
instead. This allows NFSv3 clients to correctly handle case
sensitivity for any filesystem that implements the fileattr
interface. Filesystems without ->fileattr_get continue to report
the default POSIX behavior (case-sensitive, case-preserving).

This change depends on commit ("fat: Implement fileattr_get for
case sensitivity"), which ensures FAT filesystems report their
case behavior correctly via the fileattr interface.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 fs/nfsd/nfs3proc.c | 18 ++++++++++--------
 fs/nfsd/vfs.c      | 29 +++++++++++++++++++++++++++++
 fs/nfsd/vfs.h      |  3 +++
 3 files changed, 42 insertions(+), 8 deletions(-)

diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c
index 42adc5461db0..7b094c5908f1 100644
--- a/fs/nfsd/nfs3proc.c
+++ b/fs/nfsd/nfs3proc.c
@@ -717,17 +717,19 @@ nfsd3_proc_pathconf(struct svc_rqst *rqstp)
 
 	if (resp->status == nfs_ok) {
 		struct super_block *sb = argp->fh.fh_dentry->d_sb;
+		bool case_insensitive, case_preserving;
 
-		/* Note that we don't care for remote fs's here */
-		switch (sb->s_magic) {
-		case EXT2_SUPER_MAGIC:
+		if (sb->s_magic == EXT2_SUPER_MAGIC) {
 			resp->p_link_max = EXT2_LINK_MAX;
 			resp->p_name_max = EXT2_NAME_LEN;
-			break;
-		case MSDOS_SUPER_MAGIC:
-			resp->p_case_insensitive = 1;
-			resp->p_case_preserving  = 0;
-			break;
+		}
+
+		resp->status = nfsd_get_case_info(argp->fh.fh_dentry,
+						  &case_insensitive,
+						  &case_preserving);
+		if (resp->status == nfs_ok) {
+			resp->p_case_insensitive = case_insensitive;
+			resp->p_case_preserving = case_preserving;
 		}
 	}
 
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index eafdf7b7890f..6a7c6a691f2a 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -32,6 +32,7 @@
 #include <linux/writeback.h>
 #include <linux/security.h>
 #include <linux/sunrpc/xdr.h>
+#include <linux/fileattr.h>
 
 #include "xdr3.h"
 
@@ -2891,3 +2892,31 @@ nfsd_permission(struct svc_cred *cred, struct svc_export *exp,
 
 	return err? nfserrno(err) : 0;
 }
+
+/**
+ * nfsd_get_case_info - get case sensitivity info for a dentry
+ * @dentry: dentry to query
+ * @case_insensitive: output, true if the filesystem is case-insensitive
+ * @case_preserving: output, true if the filesystem preserves case
+ *
+ * Filesystems without ->fileattr_get report POSIX defaults
+ * (case-sensitive, case-preserving). Outputs are unmodified on
+ * failure.
+ *
+ * Returns nfs_ok on success, or an nfserr on failure.
+ */
+__be32
+nfsd_get_case_info(struct dentry *dentry, bool *case_insensitive,
+		   bool *case_preserving)
+{
+	struct file_kattr fa = {};
+	int err;
+
+	err = vfs_fileattr_get(dentry, &fa);
+	if (err && err != -ENOIOCTLCMD)
+		return nfserrno(err);
+
+	*case_insensitive = fa.fsx_xflags & FS_XFLAG_CASEFOLD;
+	*case_preserving = !(fa.fsx_xflags & FS_XFLAG_CASENONPRESERVING);
+	return nfs_ok;
+}
diff --git a/fs/nfsd/vfs.h b/fs/nfsd/vfs.h
index 702a844f2106..abf33389ee81 100644
--- a/fs/nfsd/vfs.h
+++ b/fs/nfsd/vfs.h
@@ -156,6 +156,9 @@ __be32		nfsd_readdir(struct svc_rqst *, struct svc_fh *,
 			     loff_t *, struct readdir_cd *, nfsd_filldir_t);
 __be32		nfsd_statfs(struct svc_rqst *, struct svc_fh *,
 				struct kstatfs *, int access);
+__be32		nfsd_get_case_info(struct dentry *dentry,
+				   bool *case_insensitive,
+				   bool *case_preserving);
 
 __be32		nfsd_permission(struct svc_cred *cred, struct svc_export *exp,
 				struct dentry *dentry, int acc);

-- 
2.53.0


WARNING: multiple messages have this Message-ID (diff)
From: Chuck Lever via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Al Viro <viro@zeniv.linux.org.uk>,
	 Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>
Cc: pc@manguebit.org, yuezhang.mo@sony.com, cem@kernel.org,
	almaz.alexandrovich@paragon-software.com,
	adilger.kernel@dilger.ca, linux-cifs@vger.kernel.org,
	sfrench@samba.org, slava@dubeyko.com, linux-ext4@vger.kernel.org,
	linkinjeon@kernel.org, sprasad@microsoft.com, frank.li@vivo.com,
	ronniesahlberg@gmail.com, glaubitz@physik.fu-berlin.de,
	jaegeuk@kernel.org, hirofumi@mail.parknet.co.jp,
	linux-nfs@vger.kernel.org, tytso@mit.edu,
	linux-api@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-xfs@vger.kernel.org, senozhatsky@chromium.org,
	Chuck Lever <chuck.lever@oracle.com>,
	hansg@kernel.org, anna@kernel.org, linux-fsdevel@vger.kernel.org,
	sj1557.seo@samsung.com, trondmy@kernel.org
Subject: [f2fs-dev] [PATCH v9 15/17] nfsd: Report export case-folding via NFSv3 PATHCONF
Date: Wed, 22 Apr 2026 19:30:09 -0400	[thread overview]
Message-ID: <20260422-case-sensitivity-v9-15-be023cc070e2@oracle.com> (raw)
In-Reply-To: <20260422-case-sensitivity-v9-0-be023cc070e2@oracle.com>

From: Chuck Lever <chuck.lever@oracle.com>

The hard-coded MSDOS_SUPER_MAGIC check in nfsd3_proc_pathconf()
only recognizes FAT filesystems as case-insensitive. Modern
filesystems like F2FS, exFAT, and CIFS support case-insensitive
directories, but NFSv3 clients cannot discover this capability.

Query the export's actual case behavior through ->fileattr_get
instead. This allows NFSv3 clients to correctly handle case
sensitivity for any filesystem that implements the fileattr
interface. Filesystems without ->fileattr_get continue to report
the default POSIX behavior (case-sensitive, case-preserving).

This change depends on commit ("fat: Implement fileattr_get for
case sensitivity"), which ensures FAT filesystems report their
case behavior correctly via the fileattr interface.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 fs/nfsd/nfs3proc.c | 18 ++++++++++--------
 fs/nfsd/vfs.c      | 29 +++++++++++++++++++++++++++++
 fs/nfsd/vfs.h      |  3 +++
 3 files changed, 42 insertions(+), 8 deletions(-)

diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c
index 42adc5461db0..7b094c5908f1 100644
--- a/fs/nfsd/nfs3proc.c
+++ b/fs/nfsd/nfs3proc.c
@@ -717,17 +717,19 @@ nfsd3_proc_pathconf(struct svc_rqst *rqstp)
 
 	if (resp->status == nfs_ok) {
 		struct super_block *sb = argp->fh.fh_dentry->d_sb;
+		bool case_insensitive, case_preserving;
 
-		/* Note that we don't care for remote fs's here */
-		switch (sb->s_magic) {
-		case EXT2_SUPER_MAGIC:
+		if (sb->s_magic == EXT2_SUPER_MAGIC) {
 			resp->p_link_max = EXT2_LINK_MAX;
 			resp->p_name_max = EXT2_NAME_LEN;
-			break;
-		case MSDOS_SUPER_MAGIC:
-			resp->p_case_insensitive = 1;
-			resp->p_case_preserving  = 0;
-			break;
+		}
+
+		resp->status = nfsd_get_case_info(argp->fh.fh_dentry,
+						  &case_insensitive,
+						  &case_preserving);
+		if (resp->status == nfs_ok) {
+			resp->p_case_insensitive = case_insensitive;
+			resp->p_case_preserving = case_preserving;
 		}
 	}
 
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index eafdf7b7890f..6a7c6a691f2a 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -32,6 +32,7 @@
 #include <linux/writeback.h>
 #include <linux/security.h>
 #include <linux/sunrpc/xdr.h>
+#include <linux/fileattr.h>
 
 #include "xdr3.h"
 
@@ -2891,3 +2892,31 @@ nfsd_permission(struct svc_cred *cred, struct svc_export *exp,
 
 	return err? nfserrno(err) : 0;
 }
+
+/**
+ * nfsd_get_case_info - get case sensitivity info for a dentry
+ * @dentry: dentry to query
+ * @case_insensitive: output, true if the filesystem is case-insensitive
+ * @case_preserving: output, true if the filesystem preserves case
+ *
+ * Filesystems without ->fileattr_get report POSIX defaults
+ * (case-sensitive, case-preserving). Outputs are unmodified on
+ * failure.
+ *
+ * Returns nfs_ok on success, or an nfserr on failure.
+ */
+__be32
+nfsd_get_case_info(struct dentry *dentry, bool *case_insensitive,
+		   bool *case_preserving)
+{
+	struct file_kattr fa = {};
+	int err;
+
+	err = vfs_fileattr_get(dentry, &fa);
+	if (err && err != -ENOIOCTLCMD)
+		return nfserrno(err);
+
+	*case_insensitive = fa.fsx_xflags & FS_XFLAG_CASEFOLD;
+	*case_preserving = !(fa.fsx_xflags & FS_XFLAG_CASENONPRESERVING);
+	return nfs_ok;
+}
diff --git a/fs/nfsd/vfs.h b/fs/nfsd/vfs.h
index 702a844f2106..abf33389ee81 100644
--- a/fs/nfsd/vfs.h
+++ b/fs/nfsd/vfs.h
@@ -156,6 +156,9 @@ __be32		nfsd_readdir(struct svc_rqst *, struct svc_fh *,
 			     loff_t *, struct readdir_cd *, nfsd_filldir_t);
 __be32		nfsd_statfs(struct svc_rqst *, struct svc_fh *,
 				struct kstatfs *, int access);
+__be32		nfsd_get_case_info(struct dentry *dentry,
+				   bool *case_insensitive,
+				   bool *case_preserving);
 
 __be32		nfsd_permission(struct svc_cred *cred, struct svc_export *exp,
 				struct dentry *dentry, int acc);

-- 
2.53.0



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  parent reply	other threads:[~2026-04-22 23:30 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 23:29 [PATCH v9 00/17] Exposing case folding behavior Chuck Lever
2026-04-22 23:29 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:29 ` [PATCH v9 01/17] fs: Move file_kattr initialization to callers Chuck Lever
2026-04-22 23:29   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:38   ` Darrick J. Wong
2026-04-22 23:38     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-04-22 23:29 ` [PATCH v9 02/17] fs: Add case sensitivity flags to file_kattr Chuck Lever
2026-04-22 23:29   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:29 ` [PATCH v9 03/17] fat: Implement fileattr_get for case sensitivity Chuck Lever
2026-04-22 23:29   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:29 ` [PATCH v9 04/17] exfat: " Chuck Lever
2026-04-22 23:29   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:29 ` [PATCH v9 05/17] ntfs3: " Chuck Lever
2026-04-22 23:29   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 06/17] hfs: " Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 07/17] hfsplus: Report case sensitivity in fileattr_get Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 08/17] ext4: " Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 09/17] xfs: " Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 10/17] cifs: Implement fileattr_get for case sensitivity Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-23  0:59   ` Steve French
2026-04-23  0:59     ` [f2fs-dev] " Steve French
2026-04-23  1:35     ` Chuck Lever
2026-04-23  1:35       ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 11/17] nfs: " Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 12/17] f2fs: Add case sensitivity reporting to fileattr_get Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 13/17] vboxsf: Implement fileattr_get for case sensitivity Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 14/17] isofs: " Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` Chuck Lever [this message]
2026-04-22 23:30   ` [f2fs-dev] [PATCH v9 15/17] nfsd: Report export case-folding via NFSv3 PATHCONF Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 16/17] nfsd: Implement NFSv4 FATTR4_CASE_INSENSITIVE and FATTR4_CASE_PRESERVING Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 17/17] ksmbd: Report filesystem case sensitivity via FS_ATTRIBUTE_INFORMATION Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-23 11:52 ` [PATCH v9 00/17] Exposing case folding behavior Christian Brauner
2026-04-23 11:52   ` [f2fs-dev] " Christian Brauner via Linux-f2fs-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260422-case-sensitivity-v9-15-be023cc070e2@oracle.com \
    --to=cel@kernel.org \
    --cc=adilger.kernel@dilger.ca \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=anna@kernel.org \
    --cc=brauner@kernel.org \
    --cc=cem@kernel.org \
    --cc=chao@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=frank.li@vivo.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=hansg@kernel.org \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=jack@suse.cz \
    --cc=jaegeuk@kernel.org \
    --cc=linkinjeon@kernel.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=pc@manguebit.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=senozhatsky@chromium.org \
    --cc=sfrench@samba.org \
    --cc=sj1557.seo@samsung.com \
    --cc=slava@dubeyko.com \
    --cc=sprasad@microsoft.com \
    --cc=trondmy@kernel.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yuezhang.mo@sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.