All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <cel@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>,
	 Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	 linux-xfs@vger.kernel.org, linux-cifs@vger.kernel.org,
	 linux-nfs@vger.kernel.org, linux-api@vger.kernel.org,
	 linux-f2fs-devel@lists.sourceforge.net,
	hirofumi@mail.parknet.co.jp,  linkinjeon@kernel.org,
	sj1557.seo@samsung.com, yuezhang.mo@sony.com,
	 almaz.alexandrovich@paragon-software.com, slava@dubeyko.com,
	 glaubitz@physik.fu-berlin.de, frank.li@vivo.com, tytso@mit.edu,
	 adilger.kernel@dilger.ca, cem@kernel.org, sfrench@samba.org,
	 pc@manguebit.org, ronniesahlberg@gmail.com,
	sprasad@microsoft.com,  trondmy@kernel.org, anna@kernel.org,
	jaegeuk@kernel.org, chao@kernel.org,  hansg@kernel.org,
	senozhatsky@chromium.org,  Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v9 16/17] nfsd: Implement NFSv4 FATTR4_CASE_INSENSITIVE and FATTR4_CASE_PRESERVING
Date: Wed, 22 Apr 2026 19:30:10 -0400	[thread overview]
Message-ID: <20260422-case-sensitivity-v9-16-be023cc070e2@oracle.com> (raw)
In-Reply-To: <20260422-case-sensitivity-v9-0-be023cc070e2@oracle.com>

From: Chuck Lever <chuck.lever@oracle.com>

NFSD currently provides NFSv4 clients with hard-coded responses
indicating all exported filesystems are case-sensitive and
case-preserving. This is incorrect for case-insensitive filesystems
and ext4 directories with casefold enabled.

Query the underlying filesystem's actual case sensitivity via
nfsd_get_case_info() and return accurate values to clients. This
supports per-directory settings for filesystems that allow mixing
case-sensitive and case-insensitive directories within an export.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 fs/nfsd/nfs4xdr.c | 25 +++++++++++++++++++++++--
 1 file changed, 23 insertions(+), 2 deletions(-)

diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 2a0946c630e1..961cd59756fb 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -3158,6 +3158,8 @@ struct nfsd4_fattr_args {
 	u32			rdattr_err;
 	bool			contextsupport;
 	bool			ignore_crossmnt;
+	bool			case_insensitive;
+	bool			case_preserving;
 };
 
 typedef __be32(*nfsd4_enc_attr)(struct xdr_stream *xdr,
@@ -3356,6 +3358,18 @@ static __be32 nfsd4_encode_fattr4_acl(struct xdr_stream *xdr,
 	return nfs_ok;
 }
 
+static __be32 nfsd4_encode_fattr4_case_insensitive(struct xdr_stream *xdr,
+					const struct nfsd4_fattr_args *args)
+{
+	return nfsd4_encode_bool(xdr, args->case_insensitive);
+}
+
+static __be32 nfsd4_encode_fattr4_case_preserving(struct xdr_stream *xdr,
+					const struct nfsd4_fattr_args *args)
+{
+	return nfsd4_encode_bool(xdr, args->case_preserving);
+}
+
 static __be32 nfsd4_encode_fattr4_filehandle(struct xdr_stream *xdr,
 					     const struct nfsd4_fattr_args *args)
 {
@@ -3748,8 +3762,8 @@ static const nfsd4_enc_attr nfsd4_enc_fattr4_encode_ops[] = {
 	[FATTR4_ACLSUPPORT]		= nfsd4_encode_fattr4_aclsupport,
 	[FATTR4_ARCHIVE]		= nfsd4_encode_fattr4__noop,
 	[FATTR4_CANSETTIME]		= nfsd4_encode_fattr4__true,
-	[FATTR4_CASE_INSENSITIVE]	= nfsd4_encode_fattr4__false,
-	[FATTR4_CASE_PRESERVING]	= nfsd4_encode_fattr4__true,
+	[FATTR4_CASE_INSENSITIVE]	= nfsd4_encode_fattr4_case_insensitive,
+	[FATTR4_CASE_PRESERVING]	= nfsd4_encode_fattr4_case_preserving,
 	[FATTR4_CHOWN_RESTRICTED]	= nfsd4_encode_fattr4__true,
 	[FATTR4_FILEHANDLE]		= nfsd4_encode_fattr4_filehandle,
 	[FATTR4_FILEID]			= nfsd4_encode_fattr4_fileid,
@@ -3968,6 +3982,13 @@ nfsd4_encode_fattr4(struct svc_rqst *rqstp, struct xdr_stream *xdr,
 		args.fhp = tempfh;
 	} else
 		args.fhp = fhp;
+	if (attrmask[0] & (FATTR4_WORD0_CASE_INSENSITIVE |
+			   FATTR4_WORD0_CASE_PRESERVING)) {
+		status = nfsd_get_case_info(dentry, &args.case_insensitive,
+					    &args.case_preserving);
+		if (status != nfs_ok)
+			goto out;
+	}
 
 	if (attrmask[0] & FATTR4_WORD0_ACL) {
 		err = nfsd4_get_nfs4_acl(rqstp, dentry, &args.acl);

-- 
2.53.0


WARNING: multiple messages have this Message-ID (diff)
From: Chuck Lever via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Al Viro <viro@zeniv.linux.org.uk>,
	 Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>
Cc: pc@manguebit.org, yuezhang.mo@sony.com, cem@kernel.org,
	almaz.alexandrovich@paragon-software.com,
	adilger.kernel@dilger.ca, linux-cifs@vger.kernel.org,
	sfrench@samba.org, slava@dubeyko.com, linux-ext4@vger.kernel.org,
	linkinjeon@kernel.org, sprasad@microsoft.com, frank.li@vivo.com,
	ronniesahlberg@gmail.com, glaubitz@physik.fu-berlin.de,
	jaegeuk@kernel.org, hirofumi@mail.parknet.co.jp,
	linux-nfs@vger.kernel.org, tytso@mit.edu,
	linux-api@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-xfs@vger.kernel.org, senozhatsky@chromium.org,
	Chuck Lever <chuck.lever@oracle.com>,
	hansg@kernel.org, anna@kernel.org, linux-fsdevel@vger.kernel.org,
	sj1557.seo@samsung.com, trondmy@kernel.org
Subject: [f2fs-dev] [PATCH v9 16/17] nfsd: Implement NFSv4 FATTR4_CASE_INSENSITIVE and FATTR4_CASE_PRESERVING
Date: Wed, 22 Apr 2026 19:30:10 -0400	[thread overview]
Message-ID: <20260422-case-sensitivity-v9-16-be023cc070e2@oracle.com> (raw)
In-Reply-To: <20260422-case-sensitivity-v9-0-be023cc070e2@oracle.com>

From: Chuck Lever <chuck.lever@oracle.com>

NFSD currently provides NFSv4 clients with hard-coded responses
indicating all exported filesystems are case-sensitive and
case-preserving. This is incorrect for case-insensitive filesystems
and ext4 directories with casefold enabled.

Query the underlying filesystem's actual case sensitivity via
nfsd_get_case_info() and return accurate values to clients. This
supports per-directory settings for filesystems that allow mixing
case-sensitive and case-insensitive directories within an export.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 fs/nfsd/nfs4xdr.c | 25 +++++++++++++++++++++++--
 1 file changed, 23 insertions(+), 2 deletions(-)

diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 2a0946c630e1..961cd59756fb 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -3158,6 +3158,8 @@ struct nfsd4_fattr_args {
 	u32			rdattr_err;
 	bool			contextsupport;
 	bool			ignore_crossmnt;
+	bool			case_insensitive;
+	bool			case_preserving;
 };
 
 typedef __be32(*nfsd4_enc_attr)(struct xdr_stream *xdr,
@@ -3356,6 +3358,18 @@ static __be32 nfsd4_encode_fattr4_acl(struct xdr_stream *xdr,
 	return nfs_ok;
 }
 
+static __be32 nfsd4_encode_fattr4_case_insensitive(struct xdr_stream *xdr,
+					const struct nfsd4_fattr_args *args)
+{
+	return nfsd4_encode_bool(xdr, args->case_insensitive);
+}
+
+static __be32 nfsd4_encode_fattr4_case_preserving(struct xdr_stream *xdr,
+					const struct nfsd4_fattr_args *args)
+{
+	return nfsd4_encode_bool(xdr, args->case_preserving);
+}
+
 static __be32 nfsd4_encode_fattr4_filehandle(struct xdr_stream *xdr,
 					     const struct nfsd4_fattr_args *args)
 {
@@ -3748,8 +3762,8 @@ static const nfsd4_enc_attr nfsd4_enc_fattr4_encode_ops[] = {
 	[FATTR4_ACLSUPPORT]		= nfsd4_encode_fattr4_aclsupport,
 	[FATTR4_ARCHIVE]		= nfsd4_encode_fattr4__noop,
 	[FATTR4_CANSETTIME]		= nfsd4_encode_fattr4__true,
-	[FATTR4_CASE_INSENSITIVE]	= nfsd4_encode_fattr4__false,
-	[FATTR4_CASE_PRESERVING]	= nfsd4_encode_fattr4__true,
+	[FATTR4_CASE_INSENSITIVE]	= nfsd4_encode_fattr4_case_insensitive,
+	[FATTR4_CASE_PRESERVING]	= nfsd4_encode_fattr4_case_preserving,
 	[FATTR4_CHOWN_RESTRICTED]	= nfsd4_encode_fattr4__true,
 	[FATTR4_FILEHANDLE]		= nfsd4_encode_fattr4_filehandle,
 	[FATTR4_FILEID]			= nfsd4_encode_fattr4_fileid,
@@ -3968,6 +3982,13 @@ nfsd4_encode_fattr4(struct svc_rqst *rqstp, struct xdr_stream *xdr,
 		args.fhp = tempfh;
 	} else
 		args.fhp = fhp;
+	if (attrmask[0] & (FATTR4_WORD0_CASE_INSENSITIVE |
+			   FATTR4_WORD0_CASE_PRESERVING)) {
+		status = nfsd_get_case_info(dentry, &args.case_insensitive,
+					    &args.case_preserving);
+		if (status != nfs_ok)
+			goto out;
+	}
 
 	if (attrmask[0] & FATTR4_WORD0_ACL) {
 		err = nfsd4_get_nfs4_acl(rqstp, dentry, &args.acl);

-- 
2.53.0



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  parent reply	other threads:[~2026-04-22 23:30 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 23:29 [PATCH v9 00/17] Exposing case folding behavior Chuck Lever
2026-04-22 23:29 ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:29 ` [PATCH v9 01/17] fs: Move file_kattr initialization to callers Chuck Lever
2026-04-22 23:29   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:38   ` Darrick J. Wong
2026-04-22 23:38     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-04-22 23:29 ` [PATCH v9 02/17] fs: Add case sensitivity flags to file_kattr Chuck Lever
2026-04-22 23:29   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:29 ` [PATCH v9 03/17] fat: Implement fileattr_get for case sensitivity Chuck Lever
2026-04-22 23:29   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:29 ` [PATCH v9 04/17] exfat: " Chuck Lever
2026-04-22 23:29   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:29 ` [PATCH v9 05/17] ntfs3: " Chuck Lever
2026-04-22 23:29   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 06/17] hfs: " Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 07/17] hfsplus: Report case sensitivity in fileattr_get Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 08/17] ext4: " Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 09/17] xfs: " Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 10/17] cifs: Implement fileattr_get for case sensitivity Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-23  0:59   ` Steve French
2026-04-23  0:59     ` [f2fs-dev] " Steve French
2026-04-23  1:35     ` Chuck Lever
2026-04-23  1:35       ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 11/17] nfs: " Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 12/17] f2fs: Add case sensitivity reporting to fileattr_get Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 13/17] vboxsf: Implement fileattr_get for case sensitivity Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 14/17] isofs: " Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 15/17] nfsd: Report export case-folding via NFSv3 PATHCONF Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` Chuck Lever [this message]
2026-04-22 23:30   ` [f2fs-dev] [PATCH v9 16/17] nfsd: Implement NFSv4 FATTR4_CASE_INSENSITIVE and FATTR4_CASE_PRESERVING Chuck Lever via Linux-f2fs-devel
2026-04-22 23:30 ` [PATCH v9 17/17] ksmbd: Report filesystem case sensitivity via FS_ATTRIBUTE_INFORMATION Chuck Lever
2026-04-22 23:30   ` [f2fs-dev] " Chuck Lever via Linux-f2fs-devel
2026-04-23 11:52 ` [PATCH v9 00/17] Exposing case folding behavior Christian Brauner
2026-04-23 11:52   ` [f2fs-dev] " Christian Brauner via Linux-f2fs-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260422-case-sensitivity-v9-16-be023cc070e2@oracle.com \
    --to=cel@kernel.org \
    --cc=adilger.kernel@dilger.ca \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=anna@kernel.org \
    --cc=brauner@kernel.org \
    --cc=cem@kernel.org \
    --cc=chao@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=frank.li@vivo.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=hansg@kernel.org \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=jack@suse.cz \
    --cc=jaegeuk@kernel.org \
    --cc=linkinjeon@kernel.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=pc@manguebit.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=senozhatsky@chromium.org \
    --cc=sfrench@samba.org \
    --cc=sj1557.seo@samsung.com \
    --cc=slava@dubeyko.com \
    --cc=sprasad@microsoft.com \
    --cc=trondmy@kernel.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yuezhang.mo@sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.