Re: [LTP] thermal: add new test group

[linuxtestproject.agent@gmail.com]

Hi Piotr,

On Tue, 28 Apr 2026, Piotr Kubaj wrote:
> thermal: add new test group

> +# Copyright (c) 2025, Intel Corporation. All rights reserved.

Year should be 2026 (new file).

[...]

> +	FILE *fp = SAFE_FOPEN("/proc/interrupts", "r");
> [...]
> +			if (ptr == endptr)
> +				tst_brk(TBROK, "CPU %d: interrupt not found", i);
> +
> +			if (errno == ERANGE)
> +				tst_brk(TBROK, "CPU %d: interrupt out of range", i);

Both tst_brk() calls fire before SAFE_FCLOSE(fp). Close fp before calling
tst_brk() to avoid leaking the file descriptor.

[...]

> +		sleep(sleep_time--);

Sleep-based synchronization is not allowed (G2). Replace with a polling
loop using short yields or TST_RETRY_FUNC.

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://github.com/linux-test-project/ltp-agent/actions/runs/25059182102

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp