Re: [LTP] thermal: add new test group

[linuxtestproject.agent@gmail.com]

Hi Piotr,

On Thu, 30 Apr 2026 10:42:40 +0200, Piotr Kubaj wrote:
> [PATCH] thermal: add new test group

> +# Copyright (c) 2025, Intel Corporation. All rights reserved.

Wrong year in the new Makefile -- should be 2026.

> +	while (sleep_time > 0) {
> +		[...]
> +		tst_reap_children();
> +		[...]
> +		sleep(sleep_time--);

sleep() must not be used for synchronization (G2). The children are
already reaped with tst_reap_children(); this sleep is waiting for a
hardware thermal state change. Use a polling loop with
tst_timer_start()/tst_timer_expired_ms() instead, which you already
use in cpu_workload().

---
Note:

Our agent completed the review of the patch.

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp