From: linuxtestproject.agent@gmail.com
To: Piotr Kubaj <piotr.kubaj@intel.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] thermal: add new test group
Date: Wed, 6 May 2026 14:16:36 +0000 [thread overview]
Message-ID: <20260506141636.3929-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260506112420.67516-2-piotr.kubaj@intel.com>
Hi Piotr,
On Wed, 6 May 2026 13:24:21 +0200, Piotr Kubaj wrote:
> [PATCH] thermal: add new test group
> +/*\
> + * Tests the CPU package thermal sensor interface for Intel platforms.
> +
> + * Works by checking the initial count of thermal interrupts. Then it
The blank line separating the two paragraphs must carry the " *" prefix,
i.e. " *" on its own, not an empty line.
> + if (temp > temp_high)
> + break;
> + sleep(sleep_time--);
> + run_time -= 3;
sleep() for synchronisation is not allowed (LTP ground rule G2). Replace
with a polling loop using tst_timer_start()/tst_timer_expired_ms(), or
remove the sleep and let the workload loop duration do the pacing.
---
Note:
Our agent completed the review of the patch.
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-05-06 14:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 11:24 [LTP] [PATCH v19] thermal: add new test group Piotr Kubaj
2026-05-06 14:16 ` linuxtestproject.agent [this message]
2026-05-06 14:23 ` [LTP] " Andrea Cervesato via ltp
2026-05-11 7:51 ` [LTP] [PATCH v19] " Petr Vorel
2026-05-12 9:56 ` Cyril Hrubis
2026-05-13 10:54 ` Petr Vorel
2026-05-13 12:06 ` Cyril Hrubis
-- strict thread matches above, loose matches on Subject: below --
2026-05-14 13:34 [LTP] [PATCH v21] " Piotr Kubaj
2026-05-14 14:19 ` [LTP] " linuxtestproject.agent
2026-05-15 14:42 ` Petr Vorel
2026-05-14 9:36 [LTP] [PATCH v20] " Piotr Kubaj
2026-05-14 12:00 ` [LTP] " linuxtestproject.agent
2026-05-15 14:39 ` Petr Vorel
2026-04-30 8:42 [LTP] [PATCH v18] " Piotr Kubaj
2026-04-30 9:18 ` [LTP] " linuxtestproject.agent
2026-04-30 11:28 ` Kubaj, Piotr
2026-04-28 12:46 [LTP] [PATCH v17] " Piotr Kubaj
2026-04-28 14:41 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506141636.3929-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=piotr.kubaj@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.