All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: animesh.manna@intel.com, dibin.moolakadan.subrahmanian@intel.com,
	mohammed.thasleem@intel.com, ramanaidu.naladala@intel.com,
	Jeevan B <jeevan.b@intel.com>
Subject: [PATCH i-g-t v5 2/7] tests/intel/kms_pm_dc: Replace require with proper assertion
Date: Wed, 13 May 2026 11:46:00 +0530	[thread overview]
Message-ID: <20260513061605.645695-3-jeevan.b@intel.com> (raw)
In-Reply-To: <20260513061605.645695-1-jeevan.b@intel.com>

The DC3CO video playback simulation test was incorrectly using require at
the end to check if DC3CO state was entered. This causes the test to be
marked as SKIP instead of FAIL when DC3CO doesn't work properly, hiding
real issues. So changing the call from require to assert.

Fixes: b89efa8048e58 ("tests/i915/i915_pm_dc: Check dc3co count to skip the test")
Signed-off-by: Jeevan B <jeevan.b@intel.com>
Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
 tests/intel/kms_pm_dc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c
index c8cfa300c..27fa5dc39 100644
--- a/tests/intel/kms_pm_dc.c
+++ b/tests/intel/kms_pm_dc.c
@@ -316,8 +316,7 @@ static void check_dc3co_with_videoplayback_like_load(data_t *data)
 		usleep(delay);
 	}
 
-	igt_require_f(igt_dc_state_wait_entry(data->debugfs_fd, IGT_INTEL_CHECK_DC3CO,
-					      dc3co_prev_cnt), "dc3co-vpb-simulation not enabled\n");
+	assert_dc_counter(data, IGT_INTEL_CHECK_DC3CO, dc3co_prev_cnt);
 }
 
 static void setup_dc3co(data_t *data)
-- 
2.43.0


  parent reply	other threads:[~2026-05-13  6:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13  6:15 [PATCH i-g-t v5 0/7] Enable and Add new tests for DC3CO Jeevan B
2026-05-13  6:15 ` [PATCH i-g-t v5 1/7] tests: s/check_dc_counter/assert_dc_counter Jeevan B
2026-05-13  6:16 ` Jeevan B [this message]
2026-05-13  6:16 ` [PATCH i-g-t v5 3/7] tests/intel/kms_pm_dc: Enable DC3CO test for PSR2/PR modes Jeevan B
2026-05-13  6:16 ` [PATCH i-g-t v5 4/7] tests/kms_vrr: Add new test for DC3CO validation with LOBF Jeevan B
2026-05-13  6:16 ` [PATCH i-g-t v5 5/7] tests/intel/kms_pm_dc: Add new test for dc3co framedrop validation Jeevan B
2026-05-13  6:16 ` [PATCH i-g-t v5 6/7] tests/intel/kms_pm_dc: Add new test for DC3CO recovery after DC6 Jeevan B
2026-05-13  6:16 ` [PATCH i-g-t v5 7/7] tests/intel/kms_pm_dc: Add dc3co-vpb-framegap subtest Jeevan B
2026-05-13  7:51 ` ✗ i915.CI.BAT: failure for Enable and Add new tests for DC3CO (rev6) Patchwork
2026-05-13  7:51 ` Patchwork
2026-05-13  8:22 ` ✓ Xe.CI.BAT: success " Patchwork
2026-05-14  6:02 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260513061605.645695-3-jeevan.b@intel.com \
    --to=jeevan.b@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=dibin.moolakadan.subrahmanian@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=mohammed.thasleem@intel.com \
    --cc=ramanaidu.naladala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.