From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: animesh.manna@intel.com, dibin.moolakadan.subrahmanian@intel.com,
mohammed.thasleem@intel.com, ramanaidu.naladala@intel.com,
Jeevan B <jeevan.b@intel.com>
Subject: [PATCH i-g-t v5 5/7] tests/intel/kms_pm_dc: Add new test for dc3co framedrop validation
Date: Wed, 13 May 2026 11:46:03 +0530 [thread overview]
Message-ID: <20260513061605.645695-6-jeevan.b@intel.com> (raw)
In-Reply-To: <20260513061605.645695-1-jeevan.b@intel.com>
Add a new subtest to validate that no frame drops occur during
DC3CO entry, ensuring that no frame drops are detected and DC3CO
is successfully triggered during the test.
v2: update check_dc3co_framedrop for detecting frame drops via
drmWaitVBlank vblank sequence numbers, checks DC3CO counter
to confirm entry and cast variable 'delay'.
v3: Rename function name from check_dc3co* to detect_dc3co*.
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/intel/kms_pm_dc.c | 108 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 108 insertions(+)
diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c
index 96c96e2db..4497cffb7 100644
--- a/tests/intel/kms_pm_dc.c
+++ b/tests/intel/kms_pm_dc.c
@@ -51,6 +51,10 @@
* Description: Make sure that system enters DC3CO when PSR2 or PR is active and
* system is in SLEEP state
*
+ * SUBTEST: dc3co-framedrop-check
+ * Description: Verify that DC3CO entry does not cause frame drops and successfully
+ * enters the power state
+ *
* SUBTEST: dc5-dpms
* Description: Validate display engine entry to DC5 state while all connectors's
* DPMS property set to OFF
@@ -342,6 +346,87 @@ static void test_dc3co_vpb_simulation(data_t *data)
cleanup_dc3co_fbs(data);
}
+static void detect_dc3co_framedrop(data_t *data)
+{
+ igt_plane_t *primary;
+ uint32_t dc3co_prev_cnt;
+ int delay;
+ int frame_count = 0, frame_drops = 0;
+ int max_count = 60;
+ bool dc3co_flag = false;
+ bool front = false;
+ struct drm_event_vblank ev;
+ uint64_t last_flip_ns = 0, cur_flip_ns;
+ uint64_t frame_time_ns;
+
+ igt_require_f(data->mode->vrefresh != 0, "Invalid vrefresh rate of 0\n");
+
+ frame_time_ns = UINT64_C(1000000000) / data->mode->vrefresh;
+
+ primary = igt_output_get_plane_type(data->output, DRM_PLANE_TYPE_PRIMARY);
+ igt_plane_set_fb(primary, NULL);
+ igt_display_commit(&data->display);
+
+ dc3co_prev_cnt = igt_read_dc_counter(data->debugfs_fd, IGT_INTEL_CHECK_DC3CO);
+
+ delay = (int)(1.5 * (1000000 / data->mode->vrefresh));
+
+ igt_plane_set_fb(primary, &data->fb_rgb);
+ igt_assert_eq(igt_display_try_commit_atomic(&data->display,
+ DRM_MODE_ATOMIC_NONBLOCK |
+ DRM_MODE_PAGE_FLIP_EVENT,
+ data), 0);
+ igt_assert_eq(read(data->drm_fd, &ev, sizeof(ev)), sizeof(ev));
+ last_flip_ns = (uint64_t)ev.tv_sec * UINT64_C(1000000000) +
+ (uint64_t)ev.tv_usec * 1000;
+
+ while (frame_count < max_count) {
+ front = !front;
+ igt_plane_set_fb(primary, front ? &data->fb_rgr : &data->fb_rgb);
+ usleep(delay);
+
+ igt_assert_eq(igt_display_try_commit_atomic(&data->display,
+ DRM_MODE_ATOMIC_NONBLOCK |
+ DRM_MODE_PAGE_FLIP_EVENT,
+ data), 0);
+
+ igt_set_timeout(2, "Waiting for flip event\n");
+ igt_assert_eq(read(data->drm_fd, &ev, sizeof(ev)), sizeof(ev));
+ igt_reset_timeout();
+
+ cur_flip_ns = (uint64_t)ev.tv_sec * UINT64_C(1000000000) +
+ (uint64_t)ev.tv_usec * 1000;
+
+ if (last_flip_ns != 0 &&
+ (cur_flip_ns - last_flip_ns) > 2 * frame_time_ns)
+ frame_drops++;
+
+ last_flip_ns = cur_flip_ns;
+
+ if (!dc3co_flag &&
+ igt_read_dc_counter(data->debugfs_fd,
+ IGT_INTEL_CHECK_DC3CO) > dc3co_prev_cnt)
+ dc3co_flag = true;
+
+ frame_count++;
+ }
+
+ igt_assert_f(dc3co_flag, "DC3CO was not entered during the test\n");
+ igt_assert_f(frame_drops == 0,
+ "Frame drops detected: %d drops out of %d frames\n",
+ frame_drops, frame_count);
+}
+
+static void test_dc3co_framedrop(data_t *data)
+{
+ igt_require_dc_counter(data->debugfs_fd, IGT_INTEL_CHECK_DC3CO);
+ setup_output(data);
+ setup_dc3co(data);
+ setup_videoplayback(data);
+ detect_dc3co_framedrop(data);
+ cleanup_dc3co_fbs(data);
+}
+
static void test_dc5_retention_flops(data_t *data, int dc_flag)
{
uint32_t dc_counter_before_psr;
@@ -693,6 +778,29 @@ int igt_main()
}
}
+ igt_describe("Validate that no frame drops occur during DC3CO entry "
+ "while alternating framebuffers with PSR2 or Panel Replay active");
+ igt_subtest_with_dynamic("dc3co-framedrop-check") {
+ igt_dynamic("psr2") {
+ data.op_psr_mode = PSR_MODE_2;
+ igt_require(psr_sink_support(data.drm_fd, data.debugfs_fd,
+ data.op_psr_mode, NULL));
+ igt_require_f(IS_TIGERLAKE(data.devid) ||
+ intel_display_ver(data.devid) >= 35,
+ "Platform does not support DC3CO with PSR2\n");
+ test_dc3co_framedrop(&data);
+ }
+
+ igt_dynamic("pr") {
+ data.op_psr_mode = PR_MODE;
+ igt_require(psr_sink_support(data.drm_fd, data.debugfs_fd,
+ data.op_psr_mode, NULL));
+ igt_require_f(intel_display_ver(data.devid) >= 35,
+ "Platform does not support DC3CO with Panel Replay\n");
+ test_dc3co_framedrop(&data);
+ }
+ }
+
igt_describe("This test validates display engine entry to DC5 state "
"while PSR is active");
igt_subtest("dc5-psr") {
--
2.43.0
next prev parent reply other threads:[~2026-05-13 6:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 6:15 [PATCH i-g-t v5 0/7] Enable and Add new tests for DC3CO Jeevan B
2026-05-13 6:15 ` [PATCH i-g-t v5 1/7] tests: s/check_dc_counter/assert_dc_counter Jeevan B
2026-05-13 6:16 ` [PATCH i-g-t v5 2/7] tests/intel/kms_pm_dc: Replace require with proper assertion Jeevan B
2026-05-13 6:16 ` [PATCH i-g-t v5 3/7] tests/intel/kms_pm_dc: Enable DC3CO test for PSR2/PR modes Jeevan B
2026-05-13 6:16 ` [PATCH i-g-t v5 4/7] tests/kms_vrr: Add new test for DC3CO validation with LOBF Jeevan B
2026-05-13 6:16 ` Jeevan B [this message]
2026-05-13 6:16 ` [PATCH i-g-t v5 6/7] tests/intel/kms_pm_dc: Add new test for DC3CO recovery after DC6 Jeevan B
2026-05-13 6:16 ` [PATCH i-g-t v5 7/7] tests/intel/kms_pm_dc: Add dc3co-vpb-framegap subtest Jeevan B
2026-05-13 7:51 ` ✗ i915.CI.BAT: failure for Enable and Add new tests for DC3CO (rev6) Patchwork
2026-05-13 7:51 ` Patchwork
2026-05-13 8:22 ` ✓ Xe.CI.BAT: success " Patchwork
2026-05-14 6:02 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260513061605.645695-6-jeevan.b@intel.com \
--to=jeevan.b@intel.com \
--cc=animesh.manna@intel.com \
--cc=dibin.moolakadan.subrahmanian@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=mohammed.thasleem@intel.com \
--cc=ramanaidu.naladala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.