* [koverstreet-bcachefs:bcachefs-rebalance_v2 458/799] fs/bcachefs/btree/commit.c:423 btree_key_can_insert_cached_slowpath() warn: inconsistent returns 'trans'.
@ 2026-05-14 16:05 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-05-14 16:05 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Kent Overstreet <kent.overstreet@linux.dev>
Hi Kent,
FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
tree: https://github.com/koverstreet/bcachefs bcachefs-rebalance_v2
head: d4b3d00447faf8d4d95db47e3902e4ca4db8fbdc
commit: caf90d22262c52f7c29c4b08bd50f2a27d3dbe25 [458/799] bcachefs: move btree files to subdir
:::::: branch date: 6 months ago
:::::: commit date: 7 months ago
config: riscv-randconfig-r073-20260514 (https://download.01.org/0day-ci/archive/20260515/202605150013.fnJD2b4o-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 12.5.0
smatch: v0.5.0-9185-gbcc58b9c
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202605150013.fnJD2b4o-lkp@intel.com/
smatch warnings:
fs/bcachefs/btree/commit.c:423 btree_key_can_insert_cached_slowpath() warn: inconsistent returns 'trans'.
vim +/trans +423 fs/bcachefs/btree/commit.c
b0004d8dfac514f fs/bcachefs/btree_update_leaf.c Kent Overstreet 2018-08-03 387
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 388 noinline static int
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 389 btree_key_can_insert_cached_slowpath(struct btree_trans *trans, unsigned flags,
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 390 struct btree_path *path, unsigned new_u64s)
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 391 {
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 392 struct bkey_cached *ck = (void *) path->l[0].b;
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 393 struct bkey_i *new_k;
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 394 int ret;
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 395
0971a72c3d1a8be fs/bcachefs/btree_trans_commit.c Kent Overstreet 2024-12-24 396 bch2_trans_unlock_updates_write(trans);
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 397 bch2_trans_unlock(trans);
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 398
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 399 new_k = kmalloc(new_u64s * sizeof(u64), GFP_KERNEL);
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 400 if (!new_k) {
09b9c72bd4b77a9 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2025-05-28 401 struct bch_fs *c = trans->c;
09b9c72bd4b77a9 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2025-05-28 402 bch_err(c, "error allocating memory for key cache key, btree %s u64s %u",
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 403 bch2_btree_id_str(path->btree_id), new_u64s);
09b9c72bd4b77a9 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2025-05-28 404 return bch_err_throw(c, ENOMEM_btree_key_cache_insert);
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 405 }
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 406
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 407 ret = bch2_trans_relock(trans) ?:
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 408 bch2_trans_lock_write(trans);
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 409 if (unlikely(ret)) {
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 410 kfree(new_k);
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 411 return ret;
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 412 }
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 413
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 414 memcpy(new_k, ck->k, ck->u64s * sizeof(u64));
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 415
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 416 trans_for_each_update(trans, i)
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 417 if (i->old_v == &ck->k->v)
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 418 i->old_v = &new_k->v;
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 419
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 420 kfree(ck->k);
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 421 ck->u64s = new_u64s;
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 422 ck->k = new_k;
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 @423 return 0;
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 424 }
09b0283ee23a020 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 425
:::::: The code at line 423 was first introduced by commit
:::::: 09b0283ee23a02094a43a9b93146d1060c58fc3a bcachefs: Make sure to drop/retake btree locks before reclaim
:::::: TO: Kent Overstreet <kent.overstreet@linux.dev>
:::::: CC: Kent Overstreet <kent.overstreet@linux.dev>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* [koverstreet-bcachefs:bcachefs-rebalance_v2 458/799] fs/bcachefs/btree/commit.c:423 btree_key_can_insert_cached_slowpath() warn: inconsistent returns 'trans'.
@ 2026-01-26 21:16 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-01-26 21:16 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Kent Overstreet <kent.overstreet@linux.dev>
Hi Kent,
FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
tree: https://github.com/koverstreet/bcachefs bcachefs-rebalance_v2
head: d4b3d00447faf8d4d95db47e3902e4ca4db8fbdc
commit: caf90d22262c52f7c29c4b08bd50f2a27d3dbe25 [458/799] bcachefs: move btree files to subdir
:::::: branch date: 3 months ago
:::::: commit date: 3 months ago
config: parisc-randconfig-r071-20260127 (https://download.01.org/0day-ci/archive/20260127/202601270519.oH8B4Zs8-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 10.5.0
smatch version: v0.5.0-8994-gd50c5a4c
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202601270519.oH8B4Zs8-lkp@intel.com/
smatch warnings:
fs/bcachefs/btree/commit.c:423 btree_key_can_insert_cached_slowpath() warn: inconsistent returns 'trans'.
vim +/trans +423 fs/bcachefs/btree/commit.c
b0004d8dfac514 fs/bcachefs/btree_update_leaf.c Kent Overstreet 2018-08-03 387
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 388 noinline static int
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 389 btree_key_can_insert_cached_slowpath(struct btree_trans *trans, unsigned flags,
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 390 struct btree_path *path, unsigned new_u64s)
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 391 {
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 392 struct bkey_cached *ck = (void *) path->l[0].b;
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 393 struct bkey_i *new_k;
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 394 int ret;
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 395
0971a72c3d1a8b fs/bcachefs/btree_trans_commit.c Kent Overstreet 2024-12-24 396 bch2_trans_unlock_updates_write(trans);
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 397 bch2_trans_unlock(trans);
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 398
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 399 new_k = kmalloc(new_u64s * sizeof(u64), GFP_KERNEL);
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 400 if (!new_k) {
09b9c72bd4b77a fs/bcachefs/btree_trans_commit.c Kent Overstreet 2025-05-28 401 struct bch_fs *c = trans->c;
09b9c72bd4b77a fs/bcachefs/btree_trans_commit.c Kent Overstreet 2025-05-28 402 bch_err(c, "error allocating memory for key cache key, btree %s u64s %u",
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 403 bch2_btree_id_str(path->btree_id), new_u64s);
09b9c72bd4b77a fs/bcachefs/btree_trans_commit.c Kent Overstreet 2025-05-28 404 return bch_err_throw(c, ENOMEM_btree_key_cache_insert);
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 405 }
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 406
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 407 ret = bch2_trans_relock(trans) ?:
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 408 bch2_trans_lock_write(trans);
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 409 if (unlikely(ret)) {
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 410 kfree(new_k);
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 411 return ret;
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 412 }
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 413
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 414 memcpy(new_k, ck->k, ck->u64s * sizeof(u64));
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 415
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 416 trans_for_each_update(trans, i)
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 417 if (i->old_v == &ck->k->v)
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 418 i->old_v = &new_k->v;
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 419
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 420 kfree(ck->k);
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 421 ck->u64s = new_u64s;
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 422 ck->k = new_k;
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 @423 return 0;
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 424 }
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 425
:::::: The code at line 423 was first introduced by commit
:::::: 09b0283ee23a02094a43a9b93146d1060c58fc3a bcachefs: Make sure to drop/retake btree locks before reclaim
:::::: TO: Kent Overstreet <kent.overstreet@linux.dev>
:::::: CC: Kent Overstreet <kent.overstreet@linux.dev>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-14 16:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-14 16:05 [koverstreet-bcachefs:bcachefs-rebalance_v2 458/799] fs/bcachefs/btree/commit.c:423 btree_key_can_insert_cached_slowpath() warn: inconsistent returns 'trans' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2026-01-26 21:16 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.