[PATCH 1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2

[PATCH 1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2

[Chukun Pan]

Enable the QSPI controller and the XM25QU128C SPI NOR flash on the
OrangePi RV2 board. Add a flash partition layout from vendor UBoot.

Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 45 +++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
index c95ca38e3d4a..3081065cec0e 100644
--- a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
@@ -288,6 +288,51 @@ &pcie2 {
 	status = "okay";
 };
 
+&qspi {
+	pinctrl-names = "default";
+	pinctrl-0 = <&qspi_cfg>;
+	status = "okay";
+
+	flash@0 {
+		compatible = "jedec,spi-nor";
+		reg = <0>;
+		spi-max-frequency = <26500000>;
+		spi-rx-bus-width = <4>;
+		spi-tx-bus-width = <4>;
+		vcc-supply = <&buck3_1v8>;
+
+		partitions {
+			compatible = "fixed-partitions";
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			bootinfo@0 {
+				reg = <0x00000 0x010000>;
+			};
+
+			private@10000 {
+				reg = <0x10000 0x010000>;
+			};
+
+			fsbl@20000 {
+				reg = <0x20000 0x040000>;
+			};
+
+			env@60000 {
+				reg = <0x60000 0x010000>;
+			};
+
+			opensbi@70000 {
+				reg = <0x70000 0x030000>;
+			};
+
+			uboot@a00000 {
+				reg = <0xa0000 0x760000>;
+			};
+		};
+	};
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_2_cfg>;
-- 
2.34.1

[PATCH 1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2

[Chukun Pan]

Enable the QSPI controller and the XM25QU128C SPI NOR flash on the
OrangePi RV2 board. Add a flash partition layout from vendor UBoot.

Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 45 +++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
index c95ca38e3d4a..3081065cec0e 100644
--- a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
@@ -288,6 +288,51 @@ &pcie2 {
 	status = "okay";
 };
 
+&qspi {
+	pinctrl-names = "default";
+	pinctrl-0 = <&qspi_cfg>;
+	status = "okay";
+
+	flash@0 {
+		compatible = "jedec,spi-nor";
+		reg = <0>;
+		spi-max-frequency = <26500000>;
+		spi-rx-bus-width = <4>;
+		spi-tx-bus-width = <4>;
+		vcc-supply = <&buck3_1v8>;
+
+		partitions {
+			compatible = "fixed-partitions";
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			bootinfo@0 {
+				reg = <0x00000 0x010000>;
+			};
+
+			private@10000 {
+				reg = <0x10000 0x010000>;
+			};
+
+			fsbl@20000 {
+				reg = <0x20000 0x040000>;
+			};
+
+			env@60000 {
+				reg = <0x60000 0x010000>;
+			};
+
+			opensbi@70000 {
+				reg = <0x70000 0x030000>;
+			};
+
+			uboot@a00000 {
+				reg = <0xa0000 0x760000>;
+			};
+		};
+	};
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_2_cfg>;
-- 
2.34.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH 1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Mismatch between node unit-address and 'reg' property for the uboot partition.
--

commit ac1df28fb4536a816c17f35ce989f0804943afb5
Author: Chukun Pan <amadeus@jmu.edu.cn>

riscv: dts: spacemit: enable QSPI for OrangePi RV2

This commit enables the QSPI controller and the XM25QU128C SPI NOR flash
on the OrangePi RV2 board. It also adds a flash partition layout derived
from the vendor U-Boot.

> diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
> --- a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
[ ... ]
> +			opensbi@70000 {
> +				reg = <0x70000 0x030000>;
> +			};
> +
> +			uboot@a00000 {
> +				reg = <0xa0000 0x760000>;

Is there a mismatch between the unit-address and the reg property here?

The node name uses a00000 (implying an address of 0xa00000), but the reg
property specifies a start address of 0xa0000. 

This difference will usually trigger a unit_address_vs_reg warning when
compiling the device tree with dtc. Should the node name or the reg address
be updated so they match exactly?

> +			};
> +		};
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260516080030.1736836-1-amadeus@jmu.edu.cn?part=1

Re: [PATCH 1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2

[Yixun Lan]

Hi Chukun,

On 16:00 Sat 16 May     , Chukun Pan wrote:
> Enable the QSPI controller and the XM25QU128C SPI NOR flash on the
> OrangePi RV2 board. Add a flash partition layout from vendor UBoot.
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
LGTM

Reviewed-by: Yixun Lan <dlan@kernel.org>

> ---
>  .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)

-- 
Yixun Lan (dlan)

Re: [PATCH 1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2

[Yixun Lan]

Hi Chukun,

On 16:00 Sat 16 May     , Chukun Pan wrote:
> Enable the QSPI controller and the XM25QU128C SPI NOR flash on the
> OrangePi RV2 board. Add a flash partition layout from vendor UBoot.
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
LGTM

Reviewed-by: Yixun Lan <dlan@kernel.org>

> ---
>  .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)

-- 
Yixun Lan (dlan)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH 1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2

[Yixun Lan]

On Sat, 16 May 2026 16:00:30 +0800, Chukun Pan wrote:
> Enable the QSPI controller and the XM25QU128C SPI NOR flash on the
> OrangePi RV2 board. Add a flash partition layout from vendor UBoot.

Applied, thanks!

[1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2
      https://github.com/spacemit-com/linux/commit/dd5c5b54c3be5a1422f05a23370779235043434d

Best regards,
-- 
Yixun Lan <dlan@kernel.org>

Re: [PATCH 1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2

[Yixun Lan]

On Sat, 16 May 2026 16:00:30 +0800, Chukun Pan wrote:
> Enable the QSPI controller and the XM25QU128C SPI NOR flash on the
> OrangePi RV2 board. Add a flash partition layout from vendor UBoot.

Applied, thanks!

[1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2
      https://github.com/spacemit-com/linux/commit/dd5c5b54c3be5a1422f05a23370779235043434d

Best regards,
-- 
Yixun Lan <dlan@kernel.org>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv