[PATCH v4 0/4] staging: rtl8723bs: fix efuse formatting and brace handling

[PATCH v4 0/4] staging: rtl8723bs: fix efuse formatting and brace handling

[Moksh Panicker]

This series fixes coding-style issues in
drivers/staging/rtl8723bs/core/rtw_efuse.c and adds a missing brace fix.

Patch 1 reformats rtw_efuse_read_1_byte() signature.
Patch 2 adds braces to the else clause in rtw_efuse.c.
Patch 3 reformats rtw_efuse_one_byte_read() signature.
Patch 4 fixes missing brace/comment formatting in rtw_efuse_read_1_byte().

v3 -> v4: added the missing brace fix as a separate patch and compile-tested the series. 

Moksh Panicker (4):
   staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature
   staging: rtl8723bs: add braces to else clause in rtw_efuse.c
   staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature
   staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte

 drivers/staging/rtl8723bs/core/rtw_efuse.c | 12 ++++--------
 2 files changed, 7 insertions(+), 8 deletions(-)

-- 
2.34.1

[PATCH 1/4] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature

[Moksh Panicker]

Reformat multi-line function signature to a single line to fix
line length and coding style warnings from checkpatch.pl.

Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 803a608b74fa..987d05816c5c 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -41,10 +41,7 @@ rtw_efuse_calculate_word_counts(u8 word_en)
  * 09/23/2008	MHC		Copy from WMAC.
  *
  */
-u8
-rtw_efuse_read_1_byte(
-struct adapter *Adapter,
-u16		Address)
+u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 {
 	u8 Bytetemp = {0x00};
 	u8 temp = {0x00};
-- 
2.34.1

[PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c

[Moksh Panicker]

Add missing braces to the else clause to satisfy the coding style
requirement that both arms of an if/else statement use braces.

Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 987d05816c5c..2be74f2d4ac8 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -73,7 +73,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 				break;
 		}
 		return rtw_read8(Adapter, EFUSE_CTRL);
-	} else
+	} else {
 		return 0xFF;
 
 } /* rtw_efuse_read_1_byte */
-- 
2.34.1

[PATCH 3/4] staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature

[Moksh Panicker]

Reformat multi-line function signature to a single line to fix
line length and coding style warnings from checkpatch.pl.

Closes: https://lore.kernel.org/oe-kbuild-all/202605150301.7FuEahpv-lkp@intel.com/
Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 2be74f2d4ac8..ef0cec40d388 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -79,11 +79,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 } /* rtw_efuse_read_1_byte */
 
 /*  11/16/2008 MH Read one byte from real Efuse. */
-u8
-rtw_efuse_one_byte_read(
-struct adapter *padapter,
-u16	addr,
-u8	*data)
+u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
 {
 	u32 tmpidx = 0;
 	u8 bResult;
-- 
2.34.1

[PATCH 4/4] staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte

[Moksh Panicker]

Fix missing brace and add space before inline comment in
rtw_efuse_read_1_byte() to comply with kernel coding style.

Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
 rtw_efuse_read_1_byte

---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index ef0cec40d388..a9bbfe2d6fb2 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -75,8 +75,8 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 		return rtw_read8(Adapter, EFUSE_CTRL);
 	} else {
 		return 0xFF;
-
-} /* rtw_efuse_read_1_byte */
+	}
+} /* rtw_efuse_read_1_byte */
 
 /*  11/16/2008 MH Read one byte from real Efuse. */
 u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
-- 
2.34.1

Re: [PATCH 4/4] staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte

[Greg KH]

On Sun, May 17, 2026 at 02:37:23PM +0000, Moksh Panicker wrote:
> Fix missing brace and add space before inline comment in
> rtw_efuse_read_1_byte() to comply with kernel coding style.
> 
> Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
>  rtw_efuse_read_1_byte
> 
> ---
>  drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index ef0cec40d388..a9bbfe2d6fb2 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -75,8 +75,8 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
>  		return rtw_read8(Adapter, EFUSE_CTRL);
>  	} else {
>  		return 0xFF;
> -
> -} /* rtw_efuse_read_1_byte */
> +	}
> +} /* rtw_efuse_read_1_byte */
>  
>  /*  11/16/2008 MH Read one byte from real Efuse. */
>  u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
> -- 
> 2.34.1
> 
> 

You can not break the build and then fix it in a later patch.  All
patches must never add a warning or a build breakage.

thanks,

greg k-h

Re: [PATCH v4 0/4] staging: rtl8723bs: fix efuse formatting and brace handling

[Greg KH]

On Sun, May 17, 2026 at 02:37:19PM +0000, Moksh Panicker wrote:
> This series fixes coding-style issues in
> drivers/staging/rtl8723bs/core/rtw_efuse.c and adds a missing brace fix.
> 
> Patch 1 reformats rtw_efuse_read_1_byte() signature.
> Patch 2 adds braces to the else clause in rtw_efuse.c.
> Patch 3 reformats rtw_efuse_one_byte_read() signature.
> Patch 4 fixes missing brace/comment formatting in rtw_efuse_read_1_byte().
> 
> v3 -> v4: added the missing brace fix as a separate patch and compile-tested the series. 
> 
> Moksh Panicker (4):
>    staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature
>    staging: rtl8723bs: add braces to else clause in rtw_efuse.c
>    staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature
>    staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte
> 
>  drivers/staging/rtl8723bs/core/rtw_efuse.c | 12 ++++--------
>  2 files changed, 7 insertions(+), 8 deletions(-)
> 
> -- 
> 2.34.1
> 
> 

This is the second v4 version :(

It should be v5, right?  Also, what about the changes from v1 -> v4?
You have to list them too.

thanks,

greg k-h

[PATCH v4 0/4] staging: rtl8723bs: fix efuse formatting and brace handling

[Moksh Panicker]

This series fixes coding-style issues in drivers/staging/rtl8723bs/core/rtw_efuse.c and adds a missing brace fix.

Patch 1 adds braces to the else clause.
Patch 2 reformats rtw_efuse_one_byte_read().
Patch 3 fixes a NULL pointer dereference in mxl111sf.
Patch 4 fixes a missing brace in rtw_efuse_read_1_byte().

v3 -> v4: added the missing brace fix as a separate patch and compile-tested the series. 

Moksh Panicker (4):
  staging: rtl8723bs: add braces to else clause in rtw_efuse.c
  staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature
  media: mxl111sf: fix null pointer dereference in mxl111sf_ctrl_msg
  staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte

 drivers/media/usb/dvb-usb-v2/mxl111sf.c    |  3 +++
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 12 ++++--------
 2 files changed, 7 insertions(+), 8 deletions(-)

-- 
2.34.1

[PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c

[Moksh Panicker]

Add missing braces to the else clause to satisfy the coding style
requirement that both arms of an if/else statement use braces.

Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 987d05816c5c..2be74f2d4ac8 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -73,7 +73,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 				break;
 		}
 		return rtw_read8(Adapter, EFUSE_CTRL);
-	} else
+	} else {
 		return 0xFF;
 
 } /* rtw_efuse_read_1_byte */
-- 
2.34.1

[PATCH 1/4] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature

[Moksh Panicker]

Reformat multi-line function signature to a single line to fix
line length and coding style warnings from checkpatch.pl.

Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 803a608b74fa..987d05816c5c 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -41,10 +41,7 @@ rtw_efuse_calculate_word_counts(u8 word_en)
  * 09/23/2008	MHC		Copy from WMAC.
  *
  */
-u8
-rtw_efuse_read_1_byte(
-struct adapter *Adapter,
-u16		Address)
+u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 {
 	u8 Bytetemp = {0x00};
 	u8 temp = {0x00};
-- 
2.34.1

[PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c

[Moksh Panicker]

Add missing braces to the else clause to satisfy the coding style
requirement that both arms of an if/else statement use braces.

Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 987d05816c5c..2be74f2d4ac8 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -73,7 +73,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 				break;
 		}
 		return rtw_read8(Adapter, EFUSE_CTRL);
-	} else
+	} else {
 		return 0xFF;
 
 } /* rtw_efuse_read_1_byte */
-- 
2.34.1

Re: [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c

[Dan Carpenter]

On Sat, May 16, 2026 at 09:51:02AM +0000, Moksh Panicker wrote:
> Add missing braces to the else clause to satisfy the coding style
> requirement that both arms of an if/else statement use braces.
> 
> Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index 987d05816c5c..2be74f2d4ac8 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -73,7 +73,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
>  				break;
>  		}
>  		return rtw_read8(Adapter, EFUSE_CTRL);
> -	} else
> +	} else {
>  		return 0xFF;
>  
>  } /* rtw_efuse_read_1_byte */

Always compile test your code.  Also why did you send this patch
twice?

regards,
dan carpenter

Re: [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c

[Moksh Panicker]

Hi Dan,

Apologies for sending it twice. That was due to a mistake in my
send workflow which I have since corrected. I will make sure to
compile test before submitting future patches.

Moksh


On Sat, May 16, 2026 at 10:17 AM Dan Carpenter <error27@gmail.com> wrote:
>
> On Sat, May 16, 2026 at 09:51:02AM +0000, Moksh Panicker wrote:
> > Add missing braces to the else clause to satisfy the coding style
> > requirement that both arms of an if/else statement use braces.
> >
> > Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
> > ---
> >  drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> > index 987d05816c5c..2be74f2d4ac8 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> > @@ -73,7 +73,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
> >                               break;
> >               }
> >               return rtw_read8(Adapter, EFUSE_CTRL);
> > -     } else
> > +     } else {
> >               return 0xFF;
> >
> >  } /* rtw_efuse_read_1_byte */
>
> Always compile test your code.  Also why did you send this patch
> twice?
>
> regards,
> dan carpenter
>

Re: [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c

[Moksh Panicker]

HI Dan,
I have made sure to compile test it before submitting.

Moksh

On Sat, May 16, 2026 at 11:39 AM Moksh Panicker
<mokshpanicker.7@gmail.com> wrote:
>
> Hi Dan,
>
> Apologies for sending it twice. That was due to a mistake in my
> send workflow which I have since corrected. I will make sure to
> compile test before submitting future patches.
>
> Moksh
>
>
> On Sat, May 16, 2026 at 10:17 AM Dan Carpenter <error27@gmail.com> wrote:
> >
> > On Sat, May 16, 2026 at 09:51:02AM +0000, Moksh Panicker wrote:
> > > Add missing braces to the else clause to satisfy the coding style
> > > requirement that both arms of an if/else statement use braces.
> > >
> > > Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
> > > ---
> > >  drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> > > index 987d05816c5c..2be74f2d4ac8 100644
> > > --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> > > +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> > > @@ -73,7 +73,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
> > >                               break;
> > >               }
> > >               return rtw_read8(Adapter, EFUSE_CTRL);
> > > -     } else
> > > +     } else {
> > >               return 0xFF;
> > >
> > >  } /* rtw_efuse_read_1_byte */
> >
> > Always compile test your code.  Also why did you send this patch
> > twice?
> >
> > regards,
> > dan carpenter
> >

[PATCH 1/4] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature

[Moksh Panicker]

Reformat multi-line function signature to a single line to fix
line length and coding style warnings from checkpatch.pl.

Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 803a608b74fa..987d05816c5c 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -41,10 +41,7 @@ rtw_efuse_calculate_word_counts(u8 word_en)
  * 09/23/2008	MHC		Copy from WMAC.
  *
  */
-u8
-rtw_efuse_read_1_byte(
-struct adapter *Adapter,
-u16		Address)
+u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 {
 	u8 Bytetemp = {0x00};
 	u8 temp = {0x00};
-- 
2.34.1

[PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c

[Moksh Panicker]

Add missing braces to the else clause to satisfy the coding style
requirement that both arms of an if/else statement use braces.

Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 987d05816c5c..2be74f2d4ac8 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -73,7 +73,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 				break;
 		}
 		return rtw_read8(Adapter, EFUSE_CTRL);
-	} else
+	} else {
 		return 0xFF;
 
 } /* rtw_efuse_read_1_byte */
-- 
2.34.1