* [PATCH 1/4] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature
@ 2026-05-16 9:51 Moksh Panicker
2026-05-16 9:51 ` [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c Moksh Panicker
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Moksh Panicker @ 2026-05-16 9:51 UTC (permalink / raw)
To: linux-staging; +Cc: gregkh, Moksh Panicker
Reformat multi-line function signature to a single line to fix
line length and coding style warnings from checkpatch.pl.
Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_efuse.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 803a608b74fa..987d05816c5c 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -41,10 +41,7 @@ rtw_efuse_calculate_word_counts(u8 word_en)
* 09/23/2008 MHC Copy from WMAC.
*
*/
-u8
-rtw_efuse_read_1_byte(
-struct adapter *Adapter,
-u16 Address)
+u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
{
u8 Bytetemp = {0x00};
u8 temp = {0x00};
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c
2026-05-16 9:51 [PATCH 1/4] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature Moksh Panicker
@ 2026-05-16 9:51 ` Moksh Panicker
2026-05-16 10:17 ` Dan Carpenter
2026-05-16 9:51 ` [PATCH 3/4] staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature Moksh Panicker
2026-05-16 10:27 ` [PATCH 1/4] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature Greg KH
2 siblings, 1 reply; 7+ messages in thread
From: Moksh Panicker @ 2026-05-16 9:51 UTC (permalink / raw)
To: linux-staging; +Cc: gregkh, Moksh Panicker
Add missing braces to the else clause to satisfy the coding style
requirement that both arms of an if/else statement use braces.
Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 987d05816c5c..2be74f2d4ac8 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -73,7 +73,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
break;
}
return rtw_read8(Adapter, EFUSE_CTRL);
- } else
+ } else {
return 0xFF;
} /* rtw_efuse_read_1_byte */
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c
2026-05-16 9:51 ` [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c Moksh Panicker
@ 2026-05-16 10:17 ` Dan Carpenter
2026-05-16 11:39 ` Moksh Panicker
0 siblings, 1 reply; 7+ messages in thread
From: Dan Carpenter @ 2026-05-16 10:17 UTC (permalink / raw)
To: Moksh Panicker; +Cc: linux-staging, gregkh
On Sat, May 16, 2026 at 09:51:02AM +0000, Moksh Panicker wrote:
> Add missing braces to the else clause to satisfy the coding style
> requirement that both arms of an if/else statement use braces.
>
> Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index 987d05816c5c..2be74f2d4ac8 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -73,7 +73,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
> break;
> }
> return rtw_read8(Adapter, EFUSE_CTRL);
> - } else
> + } else {
> return 0xFF;
>
> } /* rtw_efuse_read_1_byte */
Always compile test your code. Also why did you send this patch
twice?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c
2026-05-16 10:17 ` Dan Carpenter
@ 2026-05-16 11:39 ` Moksh Panicker
0 siblings, 0 replies; 7+ messages in thread
From: Moksh Panicker @ 2026-05-16 11:39 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-staging, gregkh
Hi Dan,
Apologies for sending it twice. That was due to a mistake in my
send workflow which I have since corrected. I will make sure to
compile test before submitting future patches.
Moksh
On Sat, May 16, 2026 at 10:17 AM Dan Carpenter <error27@gmail.com> wrote:
>
> On Sat, May 16, 2026 at 09:51:02AM +0000, Moksh Panicker wrote:
> > Add missing braces to the else clause to satisfy the coding style
> > requirement that both arms of an if/else statement use braces.
> >
> > Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
> > ---
> > drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> > index 987d05816c5c..2be74f2d4ac8 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> > @@ -73,7 +73,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
> > break;
> > }
> > return rtw_read8(Adapter, EFUSE_CTRL);
> > - } else
> > + } else {
> > return 0xFF;
> >
> > } /* rtw_efuse_read_1_byte */
>
> Always compile test your code. Also why did you send this patch
> twice?
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/4] staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature
2026-05-16 9:51 [PATCH 1/4] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature Moksh Panicker
2026-05-16 9:51 ` [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c Moksh Panicker
@ 2026-05-16 9:51 ` Moksh Panicker
2026-05-16 10:27 ` [PATCH 1/4] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature Greg KH
2 siblings, 0 replies; 7+ messages in thread
From: Moksh Panicker @ 2026-05-16 9:51 UTC (permalink / raw)
To: linux-staging; +Cc: gregkh, Moksh Panicker, kernel test robot
Reformat multi-line function signature to a single line to fix
line length and coding style warnings from checkpatch.pl.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202605150301.7FuEahpv-lkp@intel.com/
Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_efuse.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 2be74f2d4ac8..ef0cec40d388 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -79,11 +79,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
} /* rtw_efuse_read_1_byte */
/* 11/16/2008 MH Read one byte from real Efuse. */
-u8
-rtw_efuse_one_byte_read(
-struct adapter *padapter,
-u16 addr,
-u8 *data)
+u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
{
u32 tmpidx = 0;
u8 bResult;
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/4] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature
2026-05-16 9:51 [PATCH 1/4] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature Moksh Panicker
2026-05-16 9:51 ` [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c Moksh Panicker
2026-05-16 9:51 ` [PATCH 3/4] staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature Moksh Panicker
@ 2026-05-16 10:27 ` Greg KH
2 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2026-05-16 10:27 UTC (permalink / raw)
To: Moksh Panicker; +Cc: linux-staging
On Sat, May 16, 2026 at 09:51:01AM +0000, Moksh Panicker wrote:
> Reformat multi-line function signature to a single line to fix
> line length and coding style warnings from checkpatch.pl.
>
> Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_efuse.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index 803a608b74fa..987d05816c5c 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -41,10 +41,7 @@ rtw_efuse_calculate_word_counts(u8 word_en)
> * 09/23/2008 MHC Copy from WMAC.
> *
> */
> -u8
> -rtw_efuse_read_1_byte(
> -struct adapter *Adapter,
> -u16 Address)
> +u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
> {
> u8 Bytetemp = {0x00};
> u8 temp = {0x00};
> --
> 2.34.1
>
>
I only see 3 patches here :(
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/4] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature
@ 2026-05-15 1:33 Moksh Panicker
2026-05-15 1:33 ` [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c Moksh Panicker
0 siblings, 1 reply; 7+ messages in thread
From: Moksh Panicker @ 2026-05-15 1:33 UTC (permalink / raw)
To: linux-staging; +Cc: gregkh, Moksh Panicker
Reformat multi-line function signature to a single line to fix
line length and coding style warnings from checkpatch.pl.
Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_efuse.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 803a608b74fa..987d05816c5c 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -41,10 +41,7 @@ rtw_efuse_calculate_word_counts(u8 word_en)
* 09/23/2008 MHC Copy from WMAC.
*
*/
-u8
-rtw_efuse_read_1_byte(
-struct adapter *Adapter,
-u16 Address)
+u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
{
u8 Bytetemp = {0x00};
u8 temp = {0x00};
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c
2026-05-15 1:33 Moksh Panicker
@ 2026-05-15 1:33 ` Moksh Panicker
0 siblings, 0 replies; 7+ messages in thread
From: Moksh Panicker @ 2026-05-15 1:33 UTC (permalink / raw)
To: linux-staging; +Cc: gregkh, Moksh Panicker
Add missing braces to the else clause to satisfy the coding style
requirement that both arms of an if/else statement use braces.
Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 987d05816c5c..2be74f2d4ac8 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -73,7 +73,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
break;
}
return rtw_read8(Adapter, EFUSE_CTRL);
- } else
+ } else {
return 0xFF;
} /* rtw_efuse_read_1_byte */
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-05-16 11:39 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-16 9:51 [PATCH 1/4] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature Moksh Panicker
2026-05-16 9:51 ` [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c Moksh Panicker
2026-05-16 10:17 ` Dan Carpenter
2026-05-16 11:39 ` Moksh Panicker
2026-05-16 9:51 ` [PATCH 3/4] staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature Moksh Panicker
2026-05-16 10:27 ` [PATCH 1/4] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature Greg KH
-- strict thread matches above, loose matches on Subject: below --
2026-05-15 1:33 Moksh Panicker
2026-05-15 1:33 ` [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c Moksh Panicker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.