From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Jai Luthra <jai.luthra@ideasonboard.com>,
Mehdi Djait <mehdi.djait@linux.intel.com>,
Frank Li <Frank.li@nxp.com>
Subject: [PATCH v2 00/17] Rework frame descriptors
Date: Mon, 18 May 2026 19:43:00 +0300 [thread overview]
Message-ID: <20260518164318.3367888-1-sakari.ailus@linux.intel.com> (raw)
Hi folks,
This smallish set makes frame descriptors dynamically allocated and
implements a single-entry frame descriptor based on the device's format,
using a new helper called v4l2_subdev_get_frame_desc(). All drivers that
do not obtain their frame descriptor from upstream are converted. The
helper also obtains a frame descriptor for the desired type (parallel or
CSI-2) and checks there's at least one entry there. These checks are
removed from drivers that currently perform them. (Some drivers also check
there's exactly a single frame descriptor entry but I think in most cases
this check could be loosened. That could be done after this set.)
On callee side these patches introduce no changes as the number of
pre-allocated memory for 8 frame descriptors remains as-is. The
get_frame_desc() pad op can return more than 8 frame descriptors by
setting the num_entries to the desired number and returning -ENOSPC.
If people prefer using cleanup.h / __free() to release the dynamically
allocated array (I think I'd almost require that), I'll merge the
now-separate __v4l2_subdev_get_frame_desc() into
v4l2_subdev_get_frame_desc().
More formats can be added to df-to-mbus conversion as needed. These are
meant to be initial formats that are enough for typical raw sensors (and
one RGB format, too).
since v1:
- Take Frank's patch adding media bus format to dt / bpp conversion.
Always return -EINVAL on error.
- Rework sub-device framework patch split to make the patches more
reviewable.
- In call_get_frame_desc(), always set fd->entry to fd->entry_mem and
fd->len_entries. Also use memset_after().
- Check for num_entries in call_get_frame_desc() first and thus remove the
redundant else case.
- Check for validity of the returned frame descriptor type in
call_get_frame_desc().
- Merge the patches adding v4l2_subdev_get_frame_desc() and changing the
interface to return the frame descriptor.
- Check for descriptor type early in v4l2_subdev_get_frame_desc().
- Return 0 instead of ret in v4l2_subdev_get_frame_desc() when ret is 0.
- Check the number of returned entries in v4l2_subdev_get_frame_desc().
- Fill in the first frame descriptor entry in v4l2_subdev_get_frame_desc()
instead of allocating one in the stack.
- Move the definition of frame descriptors to the
v4l2_subdev_get_frame_desc() call site.
- Rework the code dealing with frame descriptor allocation.
- Move frame descriptor declaration to the location of first use in driver
patches.
- Fix numerous bugs in driver patches.
Frank Li (1):
media: v4l2-common: Add helper function
media_bus_fmt_to_csi2_(bpp|dt)()
Sakari Ailus (16):
media: v4l2-subdev: Align frame descriptor error codes with routing
media: v4l2-subdev: Prepare for changes in getting frame descriptors
media: v4l2-subdev: Allow releasing frame descriptors on return
media: v4l2-subdev: Allocate frame descriptors based on the need
media: v4l2-subdev: Change the maximum number of routes
media: v4l2-subdev: Return dynamically allocated pass-through routes
media: v4l2-subdev: Always return at least one frame descriptor
media: bcm2835-unicam: Use v4l2_subdev_get_frame_desc()
media: nxp: imx8-isi: Use v4l2_subdev_get_frame_desc()
media: raspberrypi: cfe: Use v4l2_subdev_get_frame_desc()
media: rzg2l-cru: Use v4l2_subdev_get_frame_desc()
media: rkisp1: Use v4l2_subdev_get_frame_desc()
media: exynos4-is: Use v4l2_subdev_get_frame_desc()
media: ti: cal: Use v4l2_subdev_get_frame_desc()
media: ipu6: Use v4l2_subdev_get_frame_desc()
staging: media: ipu7: Use v4l2_subdev_get_frame_desc()
drivers/media/pci/intel/ipu6/ipu6-isys-csi2.c | 22 +--
.../media/platform/broadcom/bcm2835-unicam.c | 22 +--
.../platform/nxp/imx8-isi/imx8-isi-crossbar.c | 19 +-
.../media/platform/raspberrypi/rp1-cfe/cfe.c | 28 ++-
.../platform/renesas/rzg2l-cru/rzg2l-video.c | 27 +--
.../platform/rockchip/rkisp1/rkisp1-isp.c | 21 +-
.../samsung/exynos4-is/fimc-capture.c | 18 +-
drivers/media/platform/ti/cal/cal-camerarx.c | 26 ++-
drivers/media/v4l2-core/v4l2-common.c | 183 ++++++++++++++++++
drivers/media/v4l2-core/v4l2-subdev.c | 152 +++++++++++++--
.../staging/media/ipu7/ipu7-isys-csi-phy.c | 19 +-
drivers/staging/media/ipu7/ipu7-isys-csi2.c | 26 ++-
include/media/mipi-csi2.h | 24 +++
include/media/v4l2-subdev.h | 78 +++++++-
14 files changed, 512 insertions(+), 153 deletions(-)
--
2.47.3
next reply other threads:[~2026-05-18 16:43 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 16:43 Sakari Ailus [this message]
2026-05-18 16:43 ` [PATCH v2 01/17] media: v4l2-common: Add helper function media_bus_fmt_to_csi2_(bpp|dt)() Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 02/17] media: v4l2-subdev: Align frame descriptor error codes with routing Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 03/17] media: v4l2-subdev: Prepare for changes in getting frame descriptors Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 04/17] media: v4l2-subdev: Allow releasing frame descriptors on return Sakari Ailus
2026-05-19 21:34 ` Frank Li
2026-05-20 12:56 ` Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 05/17] media: v4l2-subdev: Allocate frame descriptors based on the need Sakari Ailus
2026-05-19 21:53 ` Frank Li
2026-05-19 22:18 ` Frank Li
2026-05-18 16:43 ` [PATCH v2 06/17] media: v4l2-subdev: Change the maximum number of routes Sakari Ailus
2026-05-19 21:55 ` Frank Li
2026-05-18 16:43 ` [PATCH v2 07/17] media: v4l2-subdev: Return dynamically allocated pass-through routes Sakari Ailus
2026-05-19 22:33 ` Frank Li
2026-05-20 12:59 ` Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 08/17] media: v4l2-subdev: Always return at least one frame descriptor Sakari Ailus
2026-05-19 22:35 ` Frank Li
2026-05-18 16:43 ` [PATCH v2 09/17] media: bcm2835-unicam: Use v4l2_subdev_get_frame_desc() Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 10/17] media: nxp: imx8-isi: " Sakari Ailus
2026-05-19 22:36 ` Frank Li
2026-05-18 16:43 ` [PATCH v2 11/17] media: raspberrypi: cfe: " Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 12/17] media: rzg2l-cru: " Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 13/17] media: rkisp1: " Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 14/17] media: exynos4-is: " Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 15/17] media: ti: cal: " Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 16/17] media: ipu6: " Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 17/17] staging: media: ipu7: " Sakari Ailus
2026-06-11 12:49 ` [PATCH v2 00/17] Rework frame descriptors Tomi Valkeinen
2026-06-12 8:28 ` Sakari Ailus
2026-06-23 7:39 ` Sakari Ailus
2026-08-14 8:17 ` Mattijs Korpershoek
2026-08-14 8:21 ` Tomi Valkeinen
2026-08-14 9:26 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518164318.3367888-1-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=Frank.li@nxp.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jai.luthra@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mehdi.djait@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.