From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Jai Luthra <jai.luthra@ideasonboard.com>,
Mehdi Djait <mehdi.djait@linux.intel.com>,
Frank Li <Frank.li@nxp.com>
Subject: [PATCH v2 12/17] media: rzg2l-cru: Use v4l2_subdev_get_frame_desc()
Date: Mon, 18 May 2026 19:43:12 +0300 [thread overview]
Message-ID: <20260518164318.3367888-13-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20260518164318.3367888-1-sakari.ailus@linux.intel.com>
Call v4l2_subdev_get_frame_desc() to obtain the frame descriptor. This is
preferred over calling the get_frame_desc() pad operation directly.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
.../platform/renesas/rzg2l-cru/rzg2l-video.c | 27 +++++--------------
1 file changed, 7 insertions(+), 20 deletions(-)
diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
index 162e2ace6931..710fe028fb46 100644
--- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
+++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
@@ -11,6 +11,7 @@
* Copyright (C) 2008 Magnus Damm
*/
+#include <linux/cleanup.h>
#include <linux/clk.h>
#include <linux/delay.h>
#include <linux/pm_runtime.h>
@@ -406,31 +407,17 @@ void rzg2l_cru_stop_image_processing(struct rzg2l_cru_dev *cru)
static int rzg2l_cru_get_virtual_channel(struct rzg2l_cru_dev *cru)
{
- struct v4l2_mbus_frame_desc fd = { };
struct media_pad *remote_pad;
- int ret;
remote_pad = media_pad_remote_pad_unique(&cru->ip.pads[RZG2L_CRU_IP_SINK]);
- ret = v4l2_subdev_call(cru->ip.remote, pad, get_frame_desc, remote_pad->index, &fd);
- if (ret < 0 && ret != -ENOIOCTLCMD) {
- dev_err(cru->dev, "get_frame_desc failed on IP remote subdev\n");
- return ret;
- }
- /* If remote subdev does not implement .get_frame_desc default to VC0. */
- if (ret == -ENOIOCTLCMD)
- return 0;
- if (fd.type != V4L2_MBUS_FRAME_DESC_TYPE_CSI2) {
- dev_err(cru->dev, "get_frame_desc returned invalid bus type %d\n", fd.type);
- return -EINVAL;
- }
-
- if (!fd.num_entries) {
- dev_err(cru->dev, "get_frame_desc returned zero entries\n");
- return -EINVAL;
- }
+ struct v4l2_mbus_frame_desc *fd __free(v4l2_subdev_free_frame_desc) =
+ v4l2_subdev_get_frame_desc(cru->ip.remote, remote_pad->index,
+ V4L2_MBUS_FRAME_DESC_TYPE_CSI2);
+ if (IS_ERR(fd))
+ return PTR_ERR(fd);
- return fd.entry[0].bus.csi2.vc;
+ return fd->entry[0].bus.csi2.vc;
}
void rzg3e_cru_enable_interrupts(struct rzg2l_cru_dev *cru)
--
2.47.3
next prev parent reply other threads:[~2026-05-18 16:43 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 16:43 [PATCH v2 00/17] Rework frame descriptors Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 01/17] media: v4l2-common: Add helper function media_bus_fmt_to_csi2_(bpp|dt)() Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 02/17] media: v4l2-subdev: Align frame descriptor error codes with routing Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 03/17] media: v4l2-subdev: Prepare for changes in getting frame descriptors Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 04/17] media: v4l2-subdev: Allow releasing frame descriptors on return Sakari Ailus
2026-05-19 21:34 ` Frank Li
2026-05-20 12:56 ` Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 05/17] media: v4l2-subdev: Allocate frame descriptors based on the need Sakari Ailus
2026-05-19 21:53 ` Frank Li
2026-05-19 22:18 ` Frank Li
2026-05-18 16:43 ` [PATCH v2 06/17] media: v4l2-subdev: Change the maximum number of routes Sakari Ailus
2026-05-19 21:55 ` Frank Li
2026-05-18 16:43 ` [PATCH v2 07/17] media: v4l2-subdev: Return dynamically allocated pass-through routes Sakari Ailus
2026-05-19 22:33 ` Frank Li
2026-05-20 12:59 ` Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 08/17] media: v4l2-subdev: Always return at least one frame descriptor Sakari Ailus
2026-05-19 22:35 ` Frank Li
2026-05-18 16:43 ` [PATCH v2 09/17] media: bcm2835-unicam: Use v4l2_subdev_get_frame_desc() Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 10/17] media: nxp: imx8-isi: " Sakari Ailus
2026-05-19 22:36 ` Frank Li
2026-05-18 16:43 ` [PATCH v2 11/17] media: raspberrypi: cfe: " Sakari Ailus
2026-05-18 16:43 ` Sakari Ailus [this message]
2026-05-18 16:43 ` [PATCH v2 13/17] media: rkisp1: " Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 14/17] media: exynos4-is: " Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 15/17] media: ti: cal: " Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 16/17] media: ipu6: " Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 17/17] staging: media: ipu7: " Sakari Ailus
2026-06-11 12:49 ` [PATCH v2 00/17] Rework frame descriptors Tomi Valkeinen
2026-06-12 8:28 ` Sakari Ailus
2026-06-23 7:39 ` Sakari Ailus
2026-08-14 8:17 ` Mattijs Korpershoek
2026-08-14 8:21 ` Tomi Valkeinen
2026-08-14 9:26 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518164318.3367888-13-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=Frank.li@nxp.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jai.luthra@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mehdi.djait@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.