From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
kvmarm@lists.linux.dev, peter.maydell@linaro.org,
shaju.abraham@nutanix.com, khushit.shah@nutanix.com,
yangjinqian1@huawei.com, cohuck@redhat.com,
richard.henderson@linaro.org, sebott@redhat.com,
skolothumtho@nvidia.com, philmd@linaro.org
Cc: maz@kernel.org, oliver.upton@linux.dev, pbonzini@redhat.com,
armbru@redhat.com, berrange@redhat.com, abologna@redhat.com,
jdenemar@redhat.com
Subject: [PATCH v5 15/18] target/arm/kvm: Ignore some writable bits that shouldn't be
Date: Tue, 19 May 2026 15:27:29 +0200 [thread overview]
Message-ID: <20260519132905.145643-16-eric.auger@redhat.com> (raw)
In-Reply-To: <20260519132905.145643-1-eric.auger@redhat.com>
KVM currently reports some bits as writable whereas they are
RES0 or RAZ. This is detected because the code attempts to
match those bits against a named field and this later does not
exist in target/arm/cpu-idregs.h.inc.
Let's silence warnings until those bits get fixed in the kernel.
This was observed with v7.1-rc4 kernel.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
target/arm/kvm.c | 23 +++++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/target/arm/kvm.c b/target/arm/kvm.c
index 6373a66bbd..1688cc2106 100644
--- a/target/arm/kvm.c
+++ b/target/arm/kvm.c
@@ -405,6 +405,19 @@ static void get_sysreg_prop(Object *obj, Visitor *v,
trace_get_sysreg_prop(name, value);
}
+static bool ignore_unnamed_writable_field(ARM64SysReg *reg, int i)
+{
+ if ((!strcmp(reg->name, "ID_ISAR0_EL1") && i >= 28 && i <= 31) || /* RES0 */
+ (!strcmp(reg->name, "ID_ISAR5_EL1") && i >= 20 && i <= 23) || /* RES0 */
+ (!strcmp(reg->name, "MVFR2_EL1") && i >= 8 && i <= 31) || /* RES0 */
+ (!strcmp(reg->name, "ID_PFR2_EL1") && i >= 12 && i <= 31) || /* RES0 */
+ (!strcmp(reg->name, "ID_MMFR5_EL1") && i >= 8 && i <= 31) || /* RES0 */
+ (!strcmp(reg->name, "ID_AA64FPFR0_EL1") && i >= 2 && i <= 7)) { /* RAZ */
+ return true;
+ }
+ return false;
+}
+
/*
* decode_idreg_writemap: Generate props for writable fields
*
@@ -426,10 +439,12 @@ decode_idreg_writemap(Object *obj, int index, uint64_t map, ARM64SysReg *reg)
uint64_t mask;
if (!field) {
- warn_report("%s bit %d of %s is writable but no named field "
- "in target/arm/cpu-idregs.h.inc",
- __func__, i, reg->name);
- warn_report("%s is target/arm/cpu-idregs.h.inc?", __func__);
+ if (!ignore_unnamed_writable_field(reg, i)) {
+ warn_report("%s bit %d of %s is writable but no named field "
+ "in target/arm/cpu-idregs.h.inc",
+ __func__, i, reg->name);
+ warn_report("%s is target/arm/cpu-idregs.h.inc?", __func__);
+ }
map = map & ~BIT_ULL(i);
i = ctz64(map);
continue;
--
2.53.0
next prev parent reply other threads:[~2026-05-19 13:31 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 13:27 [PATCH v5 00/18] kvm/arm: Introduce a customizable aarch64 KVM host model Eric Auger
2026-05-19 13:27 ` [PATCH v5 01/18] scripts: introduce scripts/update-aarch64-cpu-sysregs-header.py Eric Auger
2026-05-19 13:27 ` [PATCH v5 02/18] target/arm/cpu-sysregs.h.inc: Sort by name alphabetical order Eric Auger
2026-06-01 14:07 ` Shameer Kolothum Thodi
2026-05-19 13:27 ` [PATCH v5 03/18] target/arm/cpu-sysregs.h.inc: Update with automatic generation Eric Auger
2026-06-01 14:09 ` Shameer Kolothum Thodi
2026-05-19 13:27 ` [PATCH v5 04/18] arm/cpu: Add infra to handle generated ID register definitions Eric Auger
2026-05-21 13:23 ` Sebastian Ott
2026-06-01 14:28 ` Shameer Kolothum Thodi
2026-06-12 7:38 ` Eric Auger
2026-05-19 13:27 ` [PATCH v5 05/18] scripts: Introduce scripts/aarch64_sysreg_helpers module Eric Auger
2026-05-19 13:27 ` [PATCH v5 06/18] scripts: Introduce scripts/update-aarch64-cpu-sysreg-properties.py Eric Auger
2026-05-27 14:35 ` Khushit Shah
2026-05-27 15:11 ` Eric Auger
2026-05-19 13:27 ` [PATCH v5 07/18] target/arm/cpu-idregs.h.inc: generate with script Eric Auger
2026-05-19 13:27 ` [PATCH v5 08/18] target/arm/cpu_idregs: generate tables for Arm64 ID registers and fields Eric Auger
2026-05-21 13:27 ` Sebastian Ott
2026-05-27 14:52 ` Khushit Shah
2026-05-27 15:14 ` Eric Auger
2026-05-19 13:27 ` [PATCH v5 09/18] target/arm/kvm: Introduce kvm_get_writable_id_regs Eric Auger
2026-05-21 13:43 ` Sebastian Ott
2026-06-01 15:26 ` Shameer Kolothum Thodi
2026-05-19 13:27 ` [PATCH v5 10/18] target/arm/cpu64: Retrieve writable ID reg map in aarch64_host_initfn() Eric Auger
2026-05-21 13:47 ` Sebastian Ott
2026-05-27 14:54 ` Khushit Shah
2026-05-27 15:17 ` Eric Auger
2026-05-19 13:27 ` [PATCH v5 11/18] arm/kvm: Initialize all writable ID registers from host Eric Auger
2026-05-21 14:22 ` Sebastian Ott
2026-05-27 15:02 ` Khushit Shah
2026-05-27 15:25 ` Eric Auger
2026-05-27 15:30 ` Eric Auger
2026-05-19 13:27 ` [PATCH v5 12/18] arm/kvm: write back modified ID regs to KVM Eric Auger
2026-05-27 14:42 ` Khushit Shah
2026-05-27 15:28 ` Khushit Shah
2026-05-27 15:33 ` Khushit Shah
2026-05-28 17:35 ` Eric Auger
2026-05-19 13:27 ` [PATCH v5 13/18] target/arm/kvm: Introduce kvm_arm_expose_idreg_properties Eric Auger
2026-05-26 14:42 ` Sebastian Ott
2026-05-27 15:08 ` Khushit Shah
2026-05-27 15:32 ` Eric Auger
2026-05-27 15:44 ` Khushit Shah
2026-05-27 16:19 ` Eric Auger
2026-05-28 5:07 ` Khushit Shah
2026-05-28 15:22 ` Eric Auger
2026-05-19 13:27 ` [PATCH v5 14/18] target/arm/kvm: Special case REVIDR_EL1 and AIDR_EL1 Eric Auger
2026-05-26 15:08 ` Sebastian Ott
2026-05-19 13:27 ` Eric Auger [this message]
2026-05-27 14:46 ` [PATCH v5 15/18] target/arm/kvm: Ignore some writable bits that shouldn't be Khushit Shah
2026-05-27 15:45 ` Eric Auger
2026-05-27 15:54 ` Khushit Shah
2026-05-27 16:01 ` Eric Auger
2026-05-27 16:16 ` Khushit Shah
2026-05-27 16:30 ` Eric Auger
2026-05-19 13:27 ` [PATCH v5 16/18] target/arm/cpu: Expose writable ID reg field properties on the kvm host vcpu model Eric Auger
2026-05-26 14:51 ` Sebastian Ott
2026-05-27 15:16 ` Khushit Shah
2026-05-27 15:51 ` Eric Auger
2026-05-27 15:56 ` Khushit Shah
2026-05-27 16:04 ` Eric Auger
2026-05-27 16:11 ` Khushit Shah
2026-05-27 17:20 ` Eric Auger
2026-05-28 5:29 ` Khushit Shah
2026-05-28 17:31 ` Eric Auger
2026-05-28 15:14 ` Eric Auger
2026-05-19 13:27 ` [PATCH v5 17/18] arm-qmp-cmds: introspection for ID register props Eric Auger
2026-05-27 6:29 ` Sebastian Ott
2026-05-27 15:17 ` Khushit Shah
2026-05-27 15:55 ` Eric Auger
2026-05-19 13:27 ` [PATCH v5 18/18] arm/cpu-features: document ID reg properties Eric Auger
2026-05-27 6:37 ` Sebastian Ott
2026-06-04 6:08 ` [PATCH v5 00/18] kvm/arm: Introduce a customizable aarch64 KVM host model Jinqian Yang
2026-06-04 6:32 ` Jinqian Yang
2026-06-04 8:31 ` Eric Auger
2026-06-04 12:00 ` Jinqian Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260519132905.145643-16-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=abologna@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=jdenemar@redhat.com \
--cc=khushit.shah@nutanix.com \
--cc=kvmarm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sebott@redhat.com \
--cc=shaju.abraham@nutanix.com \
--cc=skolothumtho@nvidia.com \
--cc=yangjinqian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.