From: Eric Biggers <ebiggers@kernel.org>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: linux-xfs@vger.kernel.org, fsverity@lists.linux.dev,
linux-fsdevel@vger.kernel.org, hch@lst.de,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-btrfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
djwong@kernel.org, Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH v10 03/22] ovl: use core fsverity ensure info interface
Date: Wed, 20 May 2026 19:07:19 +0000 [thread overview]
Message-ID: <20260520190719.GB3424023@google.com> (raw)
In-Reply-To: <20260520123722.405752-4-aalbersh@kernel.org>
On Wed, May 20, 2026 at 02:37:01PM +0200, Andrey Albershteyn wrote:
> fsverity now exposes fsverity_ensure_verity_info() which could be used
> instead of opening file to ensure that fsverity info is loaded and
> attached to inode.
>
> Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
> Acked-by: Amir Goldstein <amir73il@gmail.com>
> ---
> fs/overlayfs/util.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
Reviewed-by: Eric Biggers <ebiggers@kernel.org>
I'm still confused by the new implementation of fsverity_active() that
got introduced by "fsverity: use a hashtable to find the fsverity_info",
though. I should have caught this during review of that commit. For
one its comment is outdated, but also the memory barrier seems to be
specific to the fsverity_get_info() caller and probably should be moved
to there. Anyway, that's not directly related to this patch.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: fsverity@lists.linux.dev, djwong@kernel.org,
Amir Goldstein <amir73il@gmail.com>,
linux-unionfs@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, hch@lst.de,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v10 03/22] ovl: use core fsverity ensure info interface
Date: Wed, 20 May 2026 19:07:19 +0000 [thread overview]
Message-ID: <20260520190719.GB3424023@google.com> (raw)
In-Reply-To: <20260520123722.405752-4-aalbersh@kernel.org>
On Wed, May 20, 2026 at 02:37:01PM +0200, Andrey Albershteyn wrote:
> fsverity now exposes fsverity_ensure_verity_info() which could be used
> instead of opening file to ensure that fsverity info is loaded and
> attached to inode.
>
> Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
> Acked-by: Amir Goldstein <amir73il@gmail.com>
> ---
> fs/overlayfs/util.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
Reviewed-by: Eric Biggers <ebiggers@kernel.org>
I'm still confused by the new implementation of fsverity_active() that
got introduced by "fsverity: use a hashtable to find the fsverity_info",
though. I should have caught this during review of that commit. For
one its comment is outdated, but also the memory barrier seems to be
specific to the fsverity_get_info() caller and probably should be moved
to there. Anyway, that's not directly related to this patch.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-05-20 19:07 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 12:36 [PATCH v10 00/22] fs-verity support for XFS with post EOF merkle tree Andrey Albershteyn
2026-05-20 12:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:36 ` [PATCH v10 01/22] fsverity: report validation errors through fserror to fsnotify Andrey Albershteyn
2026-05-20 12:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 02/22] fsverity: expose ensure_fsverity_info() Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 03/22] ovl: use core fsverity ensure info interface Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:54 ` Andrey Albershteyn
2026-05-20 12:54 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 13:00 ` Andrey Albershteyn
2026-05-20 13:00 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 13:24 ` Amir Goldstein
2026-05-20 13:24 ` [f2fs-dev] " Amir Goldstein
2026-05-20 19:07 ` Eric Biggers [this message]
2026-05-20 19:07 ` Eric Biggers via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 04/22] fsverity: generate and store zero-block hash Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 05/22] fsverity: pass digest size and hash of the all-zeroes block to ->write Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 06/22] fsverity: hoist pagecache_read from f2fs/ext4 to fsverity Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 07/22] iomap: introduce IOMAP_F_FSVERITY and teach writeback to handle fsverity Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 08/22] iomap: teach iomap to read files with fsverity Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 09/22] iomap: introduce iomap_fsverity_write() for writing fsverity metadata Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 10/22] xfs: introduce fsverity on-disk changes Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 11/22] xfs: initialize fs-verity on file open Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 12/22] xfs: don't allow to enable DAX on fs-verity sealed inode Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 13/22] xfs: disable direct read path for fs-verity files Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 14/22] xfs: handle fsverity I/O in write/read path Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 15/22] xfs: use read ioend for fsverity data verification Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 16/22] xfs: add fs-verity support Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 17/22] xfs: remove unwritten extents after preallocations in fsverity metadata Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 18/22] xfs: add fs-verity ioctls Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 19/22] xfs: advertise fs-verity being available on filesystem Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 20/22] xfs: check and repair the verity inode flag state Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 21/22] xfs: introduce health state for corrupted fsverity metadata Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-20 12:37 ` [PATCH v10 22/22] xfs: enable ro-compat fs-verity flag Andrey Albershteyn
2026-05-20 12:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-21 9:07 ` [PATCH v10 00/22] fs-verity support for XFS with post EOF merkle tree Christoph Hellwig
2026-05-21 9:07 ` [f2fs-dev] " Christoph Hellwig
2026-05-21 9:42 ` Andrey Albershteyn
2026-05-21 9:42 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-21 11:38 ` Carlos Maiolino
2026-05-21 11:38 ` [f2fs-dev] " Carlos Maiolino via Linux-f2fs-devel
2026-05-21 11:42 ` Carlos Maiolino
2026-05-21 11:42 ` [f2fs-dev] " Carlos Maiolino via Linux-f2fs-devel
2026-05-22 2:06 ` Eric Biggers
2026-05-22 2:06 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-05-22 10:03 ` Christian Brauner
2026-05-22 10:03 ` [f2fs-dev] " Christian Brauner via Linux-f2fs-devel
2026-05-22 12:07 ` Christoph Hellwig
2026-05-22 12:07 ` [f2fs-dev] " Christoph Hellwig
2026-05-26 10:19 ` Carlos Maiolino
2026-05-26 10:19 ` [f2fs-dev] " Carlos Maiolino via Linux-f2fs-devel
2026-05-28 12:20 ` Christian Brauner
2026-05-28 12:20 ` [f2fs-dev] " Christian Brauner via Linux-f2fs-devel
2026-05-28 14:25 ` Andrey Albershteyn
2026-05-28 14:25 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-05-28 14:50 ` Andrey Albershteyn
2026-05-28 14:50 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-06-04 9:04 ` Andrey Albershteyn via Linux-f2fs-devel
2026-06-04 9:04 ` Andrey Albershteyn
2026-06-04 12:00 ` Christian Brauner
2026-06-04 12:00 ` [f2fs-dev] " Christian Brauner via Linux-f2fs-devel
2026-06-04 12:07 ` Andrey Albershteyn
2026-06-04 12:07 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-06-04 12:08 ` Carlos Maiolino
2026-06-04 12:08 ` [f2fs-dev] " Carlos Maiolino via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520190719.GB3424023@google.com \
--to=ebiggers@kernel.org \
--cc=aalbersh@kernel.org \
--cc=amir73il@gmail.com \
--cc=djwong@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.