* [Intel-wired-lan] [PATCH net-next] net: e100: remove redundant static variable initializations
@ 2026-05-22 6:52 ` Ashwin Gundarapu via Intel-wired-lan
0 siblings, 0 replies; 8+ messages in thread
From: Ashwin Gundarapu via Intel-wired-lan @ 2026-05-22 6:52 UTC (permalink / raw)
To: anthonylnguyen, anthony.l.nguyen@intel.com, andrewnetdev, davem,
edumazet, kuba, pabeni
Cc: intel-wired-lan, netdev, linux-kernel
From: Ashwin Gundarapu <linuxuser509@zohomail.in>
Date: Fri, 22 May 2026 12:20:23 +0530
Subject: [PATCH] net: e100: remove redundant static variable initializations
Remove '= 0' from static variables eeprom_bad_csum_allow and use_io.
Static variables are zero-initialized by default.
Found by checkpatch.pl
Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
---
drivers/net/ethernet/intel/e100.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c
index bfacf877ca40..bdddd4315cbb 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel/e100.c
@@ -167,8 +167,8 @@ MODULE_FIRMWARE(FIRMWARE_D101S);
MODULE_FIRMWARE(FIRMWARE_D102E);
static int debug = 3;
-static int eeprom_bad_csum_allow = 0;
-static int use_io = 0;
+static int eeprom_bad_csum_allow;
+static int use_io;
module_param(debug, int, 0);
module_param(eeprom_bad_csum_allow, int, 0444);
module_param(use_io, int, 0444);
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [Intel-wired-lan] [PATCH net-next] net: e100: remove redundant static variable initializations
2026-05-22 6:52 ` [Intel-wired-lan] " Ashwin Gundarapu via Intel-wired-lan
@ 2026-05-22 6:58 ` Loktionov, Aleksandr
-1 siblings, 0 replies; 8+ messages in thread
From: Loktionov, Aleksandr @ 2026-05-22 6:58 UTC (permalink / raw)
To: Ashwin Gundarapu, Nguyen, Anthony L, Kitszel, Przemyslaw,
andrewnetdev, davem, edumazet, kuba, pabeni
Cc: intel-wired-lan, netdev, linux-kernel
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> Of Ashwin Gundarapu via Intel-wired-lan
> Sent: Friday, May 22, 2026 8:53 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@intel.com>; andrewnetdev
> <andrew+netdev@lunn.ch>; davem <davem@davemloft.net>; edumazet
> <edumazet@google.com>; kuba <kuba@kernel.org>; pabeni
> <pabeni@redhat.com>
> Cc: intel-wired-lan <intel-wired-lan@lists.osuosl.org>; netdev
> <netdev@vger.kernel.org>; linux-kernel <linux-kernel@vger.kernel.org>
> Subject: [Intel-wired-lan] [PATCH net-next] net: e100: remove
> redundant static variable initializations
>
>
> From: Ashwin Gundarapu <linuxuser509@zohomail.in>
> Date: Fri, 22 May 2026 12:20:23 +0530
> Subject: [PATCH] net: e100: remove redundant static variable
> initializations
>
> Remove '= 0' from static variables eeprom_bad_csum_allow and use_io.
> Static variables are zero-initialized by default.
>
> Found by checkpatch.pl
>
> Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> ---
> drivers/net/ethernet/intel/e100.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e100.c
> b/drivers/net/ethernet/intel/e100.c
> index bfacf877ca40..bdddd4315cbb 100644
> --- a/drivers/net/ethernet/intel/e100.c
> +++ b/drivers/net/ethernet/intel/e100.c
> @@ -167,8 +167,8 @@ MODULE_FIRMWARE(FIRMWARE_D101S);
> MODULE_FIRMWARE(FIRMWARE_D102E);
>
> static int debug = 3;
> -static int eeprom_bad_csum_allow = 0;
> -static int use_io = 0;
> +static int eeprom_bad_csum_allow;
> +static int use_io;
> module_param(debug, int, 0);
> module_param(eeprom_bad_csum_allow, int, 0444); module_param(use_io,
> int, 0444);
> --
> 2.43.0
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-wired-lan] [PATCH net-next] net: e100: remove redundant static variable initializations
@ 2026-05-22 6:58 ` Loktionov, Aleksandr
0 siblings, 0 replies; 8+ messages in thread
From: Loktionov, Aleksandr @ 2026-05-22 6:58 UTC (permalink / raw)
To: Ashwin Gundarapu, Nguyen, Anthony L, Kitszel, Przemyslaw,
andrewnetdev, davem, edumazet, kuba, pabeni
Cc: intel-wired-lan, netdev, linux-kernel
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> Of Ashwin Gundarapu via Intel-wired-lan
> Sent: Friday, May 22, 2026 8:53 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@intel.com>; andrewnetdev
> <andrew+netdev@lunn.ch>; davem <davem@davemloft.net>; edumazet
> <edumazet@google.com>; kuba <kuba@kernel.org>; pabeni
> <pabeni@redhat.com>
> Cc: intel-wired-lan <intel-wired-lan@lists.osuosl.org>; netdev
> <netdev@vger.kernel.org>; linux-kernel <linux-kernel@vger.kernel.org>
> Subject: [Intel-wired-lan] [PATCH net-next] net: e100: remove
> redundant static variable initializations
>
>
> From: Ashwin Gundarapu <linuxuser509@zohomail.in>
> Date: Fri, 22 May 2026 12:20:23 +0530
> Subject: [PATCH] net: e100: remove redundant static variable
> initializations
>
> Remove '= 0' from static variables eeprom_bad_csum_allow and use_io.
> Static variables are zero-initialized by default.
>
> Found by checkpatch.pl
>
> Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> ---
> drivers/net/ethernet/intel/e100.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e100.c
> b/drivers/net/ethernet/intel/e100.c
> index bfacf877ca40..bdddd4315cbb 100644
> --- a/drivers/net/ethernet/intel/e100.c
> +++ b/drivers/net/ethernet/intel/e100.c
> @@ -167,8 +167,8 @@ MODULE_FIRMWARE(FIRMWARE_D101S);
> MODULE_FIRMWARE(FIRMWARE_D102E);
>
> static int debug = 3;
> -static int eeprom_bad_csum_allow = 0;
> -static int use_io = 0;
> +static int eeprom_bad_csum_allow;
> +static int use_io;
> module_param(debug, int, 0);
> module_param(eeprom_bad_csum_allow, int, 0444); module_param(use_io,
> int, 0444);
> --
> 2.43.0
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-wired-lan] [PATCH net-next] net: e100: remove redundant static variable initializations
2026-05-22 6:52 ` [Intel-wired-lan] " Ashwin Gundarapu via Intel-wired-lan
@ 2026-05-22 8:20 ` David Laight
-1 siblings, 0 replies; 8+ messages in thread
From: David Laight @ 2026-05-22 8:20 UTC (permalink / raw)
To: Ashwin Gundarapu
Cc: anthonylnguyen, anthony.l.nguyen@intel.com, andrewnetdev, davem,
edumazet, kuba, pabeni, intel-wired-lan, netdev, linux-kernel
On Fri, 22 May 2026 12:22:30 +0530
Ashwin Gundarapu <linuxuser509@zohomail.in> wrote:
> From: Ashwin Gundarapu <linuxuser509@zohomail.in>
> Date: Fri, 22 May 2026 12:20:23 +0530
> Subject: [PATCH] net: e100: remove redundant static variable initializations
>
> Remove '= 0' from static variables eeprom_bad_csum_allow and use_io.
> Static variables are zero-initialized by default.
>
> Found by checkpatch.pl
Not worth the churn for existing code.
-- David
>
> Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> ---
> drivers/net/ethernet/intel/e100.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c
> index bfacf877ca40..bdddd4315cbb 100644
> --- a/drivers/net/ethernet/intel/e100.c
> +++ b/drivers/net/ethernet/intel/e100.c
> @@ -167,8 +167,8 @@ MODULE_FIRMWARE(FIRMWARE_D101S);
> MODULE_FIRMWARE(FIRMWARE_D102E);
>
> static int debug = 3;
> -static int eeprom_bad_csum_allow = 0;
> -static int use_io = 0;
> +static int eeprom_bad_csum_allow;
> +static int use_io;
> module_param(debug, int, 0);
> module_param(eeprom_bad_csum_allow, int, 0444);
> module_param(use_io, int, 0444);
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] net: e100: remove redundant static variable initializations
@ 2026-05-22 8:20 ` David Laight
0 siblings, 0 replies; 8+ messages in thread
From: David Laight @ 2026-05-22 8:20 UTC (permalink / raw)
To: Ashwin Gundarapu
Cc: anthonylnguyen, anthony.l.nguyen@intel.com, andrewnetdev, davem,
edumazet, kuba, pabeni, intel-wired-lan, netdev, linux-kernel
On Fri, 22 May 2026 12:22:30 +0530
Ashwin Gundarapu <linuxuser509@zohomail.in> wrote:
> From: Ashwin Gundarapu <linuxuser509@zohomail.in>
> Date: Fri, 22 May 2026 12:20:23 +0530
> Subject: [PATCH] net: e100: remove redundant static variable initializations
>
> Remove '= 0' from static variables eeprom_bad_csum_allow and use_io.
> Static variables are zero-initialized by default.
>
> Found by checkpatch.pl
Not worth the churn for existing code.
-- David
>
> Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> ---
> drivers/net/ethernet/intel/e100.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c
> index bfacf877ca40..bdddd4315cbb 100644
> --- a/drivers/net/ethernet/intel/e100.c
> +++ b/drivers/net/ethernet/intel/e100.c
> @@ -167,8 +167,8 @@ MODULE_FIRMWARE(FIRMWARE_D101S);
> MODULE_FIRMWARE(FIRMWARE_D102E);
>
> static int debug = 3;
> -static int eeprom_bad_csum_allow = 0;
> -static int use_io = 0;
> +static int eeprom_bad_csum_allow;
> +static int use_io;
> module_param(debug, int, 0);
> module_param(eeprom_bad_csum_allow, int, 0444);
> module_param(use_io, int, 0444);
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] net: e100: remove redundant static variable initializations
2026-05-22 6:52 ` [Intel-wired-lan] " Ashwin Gundarapu via Intel-wired-lan
@ 2026-05-22 15:55 ` Jakub Kicinski
-1 siblings, 0 replies; 8+ messages in thread
From: Jakub Kicinski @ 2026-05-22 15:55 UTC (permalink / raw)
To: Ashwin Gundarapu
Cc: anthonylnguyen, anthony.l.nguyen@intel.com, andrewnetdev, davem,
edumazet, pabeni, intel-wired-lan, netdev, linux-kernel
On Fri, 22 May 2026 12:22:30 +0530 Ashwin Gundarapu wrote:
> Remove '= 0' from static variables eeprom_bad_csum_allow and use_io.
> Static variables are zero-initialized by default.
>
> Found by checkpatch.pl
Quoting documentation:
Clean-up patches
~~~~~~~~~~~~~~~~
Netdev discourages patches which perform simple clean-ups, which are not in
the context of other work. For example:
* Addressing ``checkpatch.pl``, and other trivial coding style warnings
* Addressing :ref:`Local variable ordering<rcs>` issues
* Conversions to device-managed APIs (``devm_`` helpers)
This is because it is felt that the churn that such changes produce comes
at a greater cost than the value of such clean-ups.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-wired-lan] [PATCH net-next] net: e100: remove redundant static variable initializations
@ 2026-05-22 15:55 ` Jakub Kicinski
0 siblings, 0 replies; 8+ messages in thread
From: Jakub Kicinski @ 2026-05-22 15:55 UTC (permalink / raw)
To: Ashwin Gundarapu
Cc: anthonylnguyen, anthony.l.nguyen@intel.com, andrewnetdev, davem,
edumazet, pabeni, intel-wired-lan, netdev, linux-kernel
On Fri, 22 May 2026 12:22:30 +0530 Ashwin Gundarapu wrote:
> Remove '= 0' from static variables eeprom_bad_csum_allow and use_io.
> Static variables are zero-initialized by default.
>
> Found by checkpatch.pl
Quoting documentation:
Clean-up patches
~~~~~~~~~~~~~~~~
Netdev discourages patches which perform simple clean-ups, which are not in
the context of other work. For example:
* Addressing ``checkpatch.pl``, and other trivial coding style warnings
* Addressing :ref:`Local variable ordering<rcs>` issues
* Conversions to device-managed APIs (``devm_`` helpers)
This is because it is felt that the churn that such changes produce comes
at a greater cost than the value of such clean-ups.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
^ permalink raw reply [flat|nested] 8+ messages in thread