[LTP] [PATCH] zram01: Specify filesystem type explicitly in mount

[LTP] [PATCH] zram01: Specify filesystem type explicitly in mount

[Avinesh Kumar via ltp]

util-linux 2.42 converts "ntfs" to "ntfs3" during auto-detection,
causing mount failures on systems with CONFIG_NTFS3_FS disabled
even when ntfs-3g is available.

tst_supported_fs_types.c:141: TINFO: FUSE does support ntfs
tst_supported_fs_types.c:67: TINFO: mkfs.ntfs does exist
tst_supported_fs_types.c:137: TINFO: Filesystem ntfs3 is not supported
...
...
zram01 6 TINFO: mount /dev/zram7
mount: /tmp/LTP_zram01.YG3YHQhMER/zram7: unknown filesystem type 'ntfs3'.
       dmesg(1) may have more information after failed mount system call.
zram01 6 TBROK: mount /dev/zram7 zram7 failed

Fix by specifying -t option with the filesystem type that LTP
verified as supported, avoiding auto-detection.

Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
---
 testcases/kernel/device-drivers/zram/zram01.sh | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/testcases/kernel/device-drivers/zram/zram01.sh b/testcases/kernel/device-drivers/zram/zram01.sh
index 793f6603c..4b7f2a753 100755
--- a/testcases/kernel/device-drivers/zram/zram01.sh
+++ b/testcases/kernel/device-drivers/zram/zram01.sh
@@ -94,13 +94,15 @@ zram_makefs()
 
 zram_mount()
 {
-	local i
+	local i=$dev_start
+	local fs
 
-	for i in $(seq $dev_start $dev_end); do
-		tst_res TINFO "mount /dev/zram$i"
+	for fs in $zram_filesystems; do
+		tst_res TINFO "mount /dev/zram$i ($fs)"
 		mkdir zram$i
-		ROD mount /dev/zram$i zram$i
+		ROD mount -t "$fs" /dev/zram$i zram$i
 		dev_mounted=$i
+		i=$((i + 1))
 	done
 
 	tst_res TPASS "mount of zram device(s) succeeded"
-- 
2.54.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] zram01: Specify filesystem type explicitly in mount

[linuxtestproject.agent]

Hi Avinesh,

On Mon, 25 May 2026 21:01:23 +0200, Avinesh Kumar wrote:
> zram01: Specify filesystem type explicitly in mount

> -	for i in $(seq $dev_start $dev_end); do
> -		tst_res TINFO "mount /dev/zram$i"
> +	local i=$dev_start
> +	local fs
> +
> +	for fs in $zram_filesystems; do
> +		tst_res TINFO "mount /dev/zram$i ($fs)"
>  		mkdir zram$i
> -		ROD mount /dev/zram$i zram$i
> +		ROD mount -t "$fs" /dev/zram$i zram$i
>  		dev_mounted=$i
> +		i=$((i + 1))
>  	done

Nit: the rest of the file uses `$(($i + 1))` (e.g. zram_makefs). Prefer
`i=$(($i + 1))` here for consistency.

[...]

Reviewed-by: LTP AI Reviewer <ltp-ai@noreply.github.com>

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://github.com/linux-test-project/ltp-agent/actions/runs/26416857886

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] zram01: Specify filesystem type explicitly in mount

[Petr Vorel]

Hi Avinesh,

> util-linux 2.42 converts "ntfs" to "ntfs3" during auto-detection,
> causing mount failures on systems with CONFIG_NTFS3_FS disabled
> even when ntfs-3g is available.

I see from release notes [1]:

	The NTFS mount type (kernel FS driver) can be changed by the compile option
	--with-ntfs-mounttype=, the default is ntfs3.

As you already found I guess it started as PR#3618 [2] but later got
fixed/changed as PR#3872 [3] (previous attempt was PR#3807 [4]).

[1] https://github.com/util-linux/util-linux/blob/master/Documentation/releases/v2.42-ReleaseNotes
[2] https://github.com/util-linux/util-linux/pull/3618
[3] https://github.com/util-linux/util-linux/pull/3872
[4] https://github.com/util-linux/util-linux/pull/3807

> tst_supported_fs_types.c:141: TINFO: FUSE does support ntfs
> tst_supported_fs_types.c:67: TINFO: mkfs.ntfs does exist
> tst_supported_fs_types.c:137: TINFO: Filesystem ntfs3 is not supported
> ...
> ...
> zram01 6 TINFO: mount /dev/zram7
> mount: /tmp/LTP_zram01.YG3YHQhMER/zram7: unknown filesystem type 'ntfs3'.
>        dmesg(1) may have more information after failed mount system call.
> zram01 6 TBROK: mount /dev/zram7 zram7 failed

> Fix by specifying -t option with the filesystem type that LTP
> verified as supported, avoiding auto-detection.

I guess there is nothing to be fixed in our lib/tst_supported_fs_types.c
(or even testcases/lib/tst_supported_fs.c which uses it) and there is no other
test using TST_ALL_FILESYSTEMS=1 which would need it.

Thanks for fixing this!
Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

> Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
> ---
>  testcases/kernel/device-drivers/zram/zram01.sh | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

> diff --git a/testcases/kernel/device-drivers/zram/zram01.sh b/testcases/kernel/device-drivers/zram/zram01.sh
> index 793f6603c..4b7f2a753 100755
> --- a/testcases/kernel/device-drivers/zram/zram01.sh
> +++ b/testcases/kernel/device-drivers/zram/zram01.sh
> @@ -94,13 +94,15 @@ zram_makefs()

>  zram_mount()
>  {
> -	local i
> +	local i=$dev_start
> +	local fs

> -	for i in $(seq $dev_start $dev_end); do
> -		tst_res TINFO "mount /dev/zram$i"
> +	for fs in $zram_filesystems; do
> +		tst_res TINFO "mount /dev/zram$i ($fs)"
>  		mkdir zram$i
> -		ROD mount /dev/zram$i zram$i
> +		ROD mount -t "$fs" /dev/zram$i zram$i
>  		dev_mounted=$i
> +		i=$((i + 1))
>  	done

>  	tst_res TPASS "mount of zram device(s) succeeded"

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] zram01: Specify filesystem type explicitly in mount

[Petr Vorel]

> Hi Avinesh,

> On Mon, 25 May 2026 21:01:23 +0200, Avinesh Kumar wrote:
> > zram01: Specify filesystem type explicitly in mount

> > -	for i in $(seq $dev_start $dev_end); do
> > -		tst_res TINFO "mount /dev/zram$i"
> > +	local i=$dev_start
> > +	local fs
> > +
> > +	for fs in $zram_filesystems; do
> > +		tst_res TINFO "mount /dev/zram$i ($fs)"
> >  		mkdir zram$i
> > -		ROD mount /dev/zram$i zram$i
> > +		ROD mount -t "$fs" /dev/zram$i zram$i
> >  		dev_mounted=$i
> > +		i=$((i + 1))
> >  	done

> Nit: the rest of the file uses `$(($i + 1))` (e.g. zram_makefs). Prefer
> `i=$(($i + 1))` here for consistency.

Good catch, but I'd prefer to use the form Avinesh posted (i.e. "i", not "$i").
And it's probably not worth to do the cleanup on the other place (neither in
this commit nor in the separate).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] zram01: Specify filesystem type explicitly in mount

[Cyril Hrubis]

Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] zram01: Specify filesystem type explicitly in mount

[Petr Vorel]

Hi all,

thanks, merged!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp