Re: [PATCH 04/15] mm: switch to anon_vma_tree_t APIs in preparation for ANON_VMA_LAZY

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The anon_vma field in vma_merge_struct is passed directly to a %px format specifier without being cast to a pointer type.
--

commit 642dbe1cf1e7ec576816087b7c56d9a36c41f223
Author: tao <tao.wangtao@honor.com>

mm: switch to anon_vma_tree_t APIs in preparation for ANON_VMA_LAZY
    
Replace direct anon_vma usage with anon_vma_tree_t APIs. This prepares
for ANON_VMA_LAZY and prevents external modules from accessing anon_vma
directly.

> diff --git a/mm/vma.h b/mm/vma.h
> index 8e4b61a7304c6..d3bd832992195 100644
> --- a/mm/vma.h
> +++ b/mm/vma.h
> @@ -104,7 +104,7 @@ struct vma_merge_struct {
>  		vma_flags_t vma_flags;
>  	};
>  	struct file *file;
> -	struct anon_vma *anon_vma;
> +	anon_vma_tree_t anon_vma;

[Severity: Low]
Since anon_vma is now an anon_vma_tree_t (which is an unsigned long), does
dump_vma_merge_struct() in mm/debug.c also need an explicit cast to (void *)
when passing it to the %px format specifier?

Without the cast, this might trigger a compiler warning because %px strictly
expects a pointer argument, which could cause a build failure under the
kernel's -Werror configuration.

>  	struct mempolicy *policy;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260527110147.17815-1-tao.wangtao@honor.com?part=4