* [PATCH] filelock: update break_lease() stub with correct arguments
@ 2026-06-07 10:46 Jeff Layton
2026-06-08 22:10 ` Nathan Chancellor
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Layton @ 2026-06-07 10:46 UTC (permalink / raw)
To: NeilBrown, Christian Brauner, Jan Kara
Cc: Nathan Chancellor, linux-kernel, kernel test robot, Jeff Layton
When CONFIG_FILE_LOCKING=n, break_lease() becomes a no-op. The arguments
for the function still need to change though.
Fixes: 4be9f3cc582a ("filelock: rework the __break_lease API to use flags")
Reported-by: Nathan Chancellor <nathan@kernel.org>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202606071029.DKCs8WOs-lkp@intel.com/
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
include/linux/filelock.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/filelock.h b/include/linux/filelock.h
index 7a7a6e8a9a08..ec11cc6b4c58 100644
--- a/include/linux/filelock.h
+++ b/include/linux/filelock.h
@@ -584,7 +584,7 @@ static inline bool is_delegated(struct delegated_inode *di)
return false;
}
-static inline int break_lease(struct inode *inode, bool wait)
+static inline int break_lease(struct inode *inode, unsigned int mode)
{
return 0;
}
---
base-commit: 4d14e43b656c6ddefa91114975470a6a992b30ee
change-id: 20260607-breakleasefix-3d5a9f1e1fd6
Best regards,
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] filelock: update break_lease() stub with correct arguments
2026-06-07 10:46 [PATCH] filelock: update break_lease() stub with correct arguments Jeff Layton
@ 2026-06-08 22:10 ` Nathan Chancellor
0 siblings, 0 replies; 2+ messages in thread
From: Nathan Chancellor @ 2026-06-08 22:10 UTC (permalink / raw)
To: Jeff Layton
Cc: NeilBrown, Christian Brauner, Jan Kara, linux-kernel,
kernel test robot
On Sun, Jun 07, 2026 at 06:46:11AM -0400, Jeff Layton wrote:
> When CONFIG_FILE_LOCKING=n, break_lease() becomes a no-op. The arguments
> for the function still need to change though.
>
> Fixes: 4be9f3cc582a ("filelock: rework the __break_lease API to use flags")
> Reported-by: Nathan Chancellor <nathan@kernel.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202606071029.DKCs8WOs-lkp@intel.com/
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org> # build
> ---
> include/linux/filelock.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/filelock.h b/include/linux/filelock.h
> index 7a7a6e8a9a08..ec11cc6b4c58 100644
> --- a/include/linux/filelock.h
> +++ b/include/linux/filelock.h
> @@ -584,7 +584,7 @@ static inline bool is_delegated(struct delegated_inode *di)
> return false;
> }
>
> -static inline int break_lease(struct inode *inode, bool wait)
> +static inline int break_lease(struct inode *inode, unsigned int mode)
> {
> return 0;
> }
>
> ---
> base-commit: 4d14e43b656c6ddefa91114975470a6a992b30ee
> change-id: 20260607-breakleasefix-3d5a9f1e1fd6
>
> Best regards,
> --
> Jeff Layton <jlayton@kernel.org>
>
--
Cheers,
Nathan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-08 22:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-07 10:46 [PATCH] filelock: update break_lease() stub with correct arguments Jeff Layton
2026-06-08 22:10 ` Nathan Chancellor
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.