From: Jakub Kicinski <kuba@kernel.org>
To: Samuel Moelius <sam.moelius@trailofbits.com>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"Jiri Pirko" <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
cake@lists.bufferbloat.net (moderated list:CAKE QDISC),
netdev@vger.kernel.org (open list:TC subsystem),
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH net v2] net/sched: cake: reject overhead values that underflow length
Date: Sat, 13 Jun 2026 14:26:26 -0700 [thread overview]
Message-ID: <20260613142626.1b2183eb@kernel.org> (raw)
In-Reply-To: <20260609232935.1602659.8545fdb04fbe.cake-overhead-underflow@trailofbits.com>
On Tue, 9 Jun 2026 23:29:36 +0000 Samuel Moelius wrote:
> +static const struct netlink_range_validation_signed cake_overhead_range = {
> + .min = -64,
> + .max = 256,
Both Sashiko's complain - these values are neither safe nor sufficient.
How was the -64 chosen? It looks suspiciously close the min ethernet
frame length. But in that case (a) FCS doesn't count so 60, and
(b) even IPv4 TCP packets can be shorter (at qdisc layer) than 64B
leading to underflow...
I see min rate in cake is 64 but I don't see any other meaning of the
64 literal.
Toke, WDYT? Should we use a smaller constant (ETH_HLEN?) or do the
check on the datapath?
Also - small constants fit directly in nla_policy, you don't need
struct netlink_range_validation_signed
--
pw-bot: cr
prev parent reply other threads:[~2026-06-13 21:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 23:29 [PATCH net v2] net/sched: cake: reject overhead values that underflow length Samuel Moelius
2026-06-10 0:45 ` Jakub Kicinski
2026-06-10 0:55 ` Samuel Moelius
2026-06-10 1:46 ` Jakub Kicinski
2026-06-10 8:06 ` Toke Høiland-Jørgensen
2026-06-13 21:26 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260613142626.1b2183eb@kernel.org \
--to=kuba@kernel.org \
--cc=cake@lists.bufferbloat.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sam.moelius@trailofbits.com \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.