* [PATCH] net: ethtool: mm: Increase FPE verification retry count
@ 2026-06-15 7:24 muhammad.nazim.amirul.nazle.asmade
2026-06-16 7:19 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: muhammad.nazim.amirul.nazle.asmade @ 2026-06-15 7:24 UTC (permalink / raw)
To: netdev
Cc: andrew, kuba, davem, edumazet, pabeni, horms, vladimir.oltean,
faizal.abdul.rahim, linux-kernel
From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
The current FPE verification retry count is set to 3. However,
the IEEE 802.3br standard does not specify a fixed value for this.
A retry count of 3 may be insufficient when the remote device is
slow to respond during link-up. Increase the retry count to 20 to
improve robustness.
Signed-off-by: Rohan G Thomas <rohan.g.thomas@altera.com>
Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
---
include/linux/ethtool.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index f51346a6a686..9a1b1f5d37a4 100644
--- a/include/linux/ethtool.h
+++ b/include/linux/ethtool.h
@@ -23,7 +23,7 @@
#include <uapi/linux/net_tstamp.h>
#define ETHTOOL_MM_MAX_VERIFY_TIME_MS 128
-#define ETHTOOL_MM_MAX_VERIFY_RETRIES 3
+#define ETHTOOL_MM_MAX_VERIFY_RETRIES 20
struct compat_ethtool_rx_flow_spec {
u32 flow_type;
--
2.43.7
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] net: ethtool: mm: Increase FPE verification retry count
2026-06-15 7:24 [PATCH] net: ethtool: mm: Increase FPE verification retry count muhammad.nazim.amirul.nazle.asmade
@ 2026-06-16 7:19 ` Simon Horman
0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2026-06-16 7:19 UTC (permalink / raw)
To: muhammad.nazim.amirul.nazle.asmade
Cc: netdev, andrew, kuba, davem, edumazet, pabeni, vladimir.oltean,
faizal.abdul.rahim, linux-kernel
+ Vladimir
On Mon, Jun 15, 2026 at 12:24:36AM -0700, muhammad.nazim.amirul.nazle.asmade@altera.com wrote:
> From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
>
> The current FPE verification retry count is set to 3. However,
> the IEEE 802.3br standard does not specify a fixed value for this.
> A retry count of 3 may be insufficient when the remote device is
> slow to respond during link-up. Increase the retry count to 20 to
> improve robustness.
>
> Signed-off-by: Rohan G Thomas <rohan.g.thomas@altera.com>
> Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
Vladimir, I'm wondering if you could take a look at this one.
> ---
> include/linux/ethtool.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
> index f51346a6a686..9a1b1f5d37a4 100644
> --- a/include/linux/ethtool.h
> +++ b/include/linux/ethtool.h
> @@ -23,7 +23,7 @@
> #include <uapi/linux/net_tstamp.h>
>
> #define ETHTOOL_MM_MAX_VERIFY_TIME_MS 128
> -#define ETHTOOL_MM_MAX_VERIFY_RETRIES 3
> +#define ETHTOOL_MM_MAX_VERIFY_RETRIES 20
>
> struct compat_ethtool_rx_flow_spec {
> u32 flow_type;
> --
> 2.43.7
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] net: ethtool: mm: Increase FPE verification retry count
@ 2026-06-05 2:56 muhammad.nazim.amirul.nazle.asmade
2026-06-10 0:17 ` Jakub Kicinski
0 siblings, 1 reply; 5+ messages in thread
From: muhammad.nazim.amirul.nazle.asmade @ 2026-06-05 2:56 UTC (permalink / raw)
To: netdev
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, mcoquelin.stm32,
alexandre.torgue, rmk+kernel, maxime.chevallier, linux-stm32,
linux-arm-kernel, linux-kernel
From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
The current FPE verification retry count is set to 3. However,
the IEEE 802.3br standard does not specify a fixed value for this.
A retry count of 3 may be insufficient when the remote device is
slow to respond during link-up. Increase the retry count to 20 to
improve robustness.
Signed-off-by: Rohan G Thomas <rohan.g.thomas@altera.com>
Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
---
include/linux/ethtool.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index f51346a6a686..9a1b1f5d37a4 100644
--- a/include/linux/ethtool.h
+++ b/include/linux/ethtool.h
@@ -23,7 +23,7 @@
#include <uapi/linux/net_tstamp.h>
#define ETHTOOL_MM_MAX_VERIFY_TIME_MS 128
-#define ETHTOOL_MM_MAX_VERIFY_RETRIES 3
+#define ETHTOOL_MM_MAX_VERIFY_RETRIES 20
struct compat_ethtool_rx_flow_spec {
u32 flow_type;
--
2.43.7
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] net: ethtool: mm: Increase FPE verification retry count
2026-06-05 2:56 muhammad.nazim.amirul.nazle.asmade
@ 2026-06-10 0:17 ` Jakub Kicinski
2026-06-15 7:26 ` Nazle Asmade, Muhammad Nazim Amirul
0 siblings, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2026-06-10 0:17 UTC (permalink / raw)
To: muhammad.nazim.amirul.nazle.asmade
Cc: netdev, andrew+netdev, davem, edumazet, pabeni, mcoquelin.stm32,
alexandre.torgue, rmk+kernel, maxime.chevallier, linux-stm32,
linux-arm-kernel, linux-kernel
On Thu, 4 Jun 2026 19:56:31 -0700
muhammad.nazim.amirul.nazle.asmade@altera.com wrote:
> The current FPE verification retry count is set to 3. However,
> the IEEE 802.3br standard does not specify a fixed value for this.
> A retry count of 3 may be insufficient when the remote device is
> slow to respond during link-up. Increase the retry count to 20 to
> improve robustness.
You need to CC the author / expert on this code, please repost
with the CC fixed.
--
pw-bot: cr
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: ethtool: mm: Increase FPE verification retry count
2026-06-10 0:17 ` Jakub Kicinski
@ 2026-06-15 7:26 ` Nazle Asmade, Muhammad Nazim Amirul
0 siblings, 0 replies; 5+ messages in thread
From: Nazle Asmade, Muhammad Nazim Amirul @ 2026-06-15 7:26 UTC (permalink / raw)
To: Jakub Kicinski
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
rmk+kernel@armlinux.org.uk, maxime.chevallier@bootlin.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On 10/6/2026 8:17 am, Jakub Kicinski wrote:
> On Thu, 4 Jun 2026 19:56:31 -0700
> muhammad.nazim.amirul.nazle.asmade@altera.com wrote:
>> The current FPE verification retry count is set to 3. However,
>> the IEEE 802.3br standard does not specify a fixed value for this.
>> A retry count of 3 may be insufficient when the remote device is
>> slow to respond during link-up. Increase the retry count to 20 to
>> improve robustness.
>
> You need to CC the author / expert on this code, please repost
> with the CC fixed.
Reposted, Thanks Jackub!
https://lore.kernel.org/all/20260615072436.26128-1-muhammad.nazim.amirul.nazle.asmade@altera.com/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-06-16 7:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-15 7:24 [PATCH] net: ethtool: mm: Increase FPE verification retry count muhammad.nazim.amirul.nazle.asmade
2026-06-16 7:19 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2026-06-05 2:56 muhammad.nazim.amirul.nazle.asmade
2026-06-10 0:17 ` Jakub Kicinski
2026-06-15 7:26 ` Nazle Asmade, Muhammad Nazim Amirul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.