All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Akhil R" <akhilrajeev@nvidia.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org,
	linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org,
	Frank.Li@kernel.org
Subject: Re: [PATCH v4 11/12] hwmon: spd5118: Add I3C support
Date: Tue, 16 Jun 2026 10:30:55 +0000	[thread overview]
Message-ID: <20260616103056.6F6161F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260616095429.3947205-12-akhilrajeev@nvidia.com>

> Add a regmap config and a probe function to support I3C-based
> communication with SPD5118 devices.
> 
> On an I3C bus, SPD5118 devices are enumerated via SETAASA and always
> require an ACPI or device tree entry. Device matching is hence through
> the OF match tables only and does not need an I3C class match table. The
> device identity is verified in the type registers before proceeding to
> the common probe function.
> 
> Acked-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260616095429.3947205-1-akhilrajeev@nvidia.com?part=11


-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Akhil R" <akhilrajeev@nvidia.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org,
	linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org,
	Frank.Li@kernel.org
Subject: Re: [PATCH v4 11/12] hwmon: spd5118: Add I3C support
Date: Tue, 16 Jun 2026 10:30:55 +0000	[thread overview]
Message-ID: <20260616103056.6F6161F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260616095429.3947205-12-akhilrajeev@nvidia.com>

> Add a regmap config and a probe function to support I3C-based
> communication with SPD5118 devices.
> 
> On an I3C bus, SPD5118 devices are enumerated via SETAASA and always
> require an ACPI or device tree entry. Device matching is hence through
> the OF match tables only and does not need an I3C class match table. The
> device identity is verified in the type registers before proceeding to
> the common probe function.
> 
> Acked-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260616095429.3947205-1-akhilrajeev@nvidia.com?part=11


  reply	other threads:[~2026-06-16 10:30 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-16  9:54 [PATCH v4 00/12] Support ACPI and SETAASA device discovery Akhil R
2026-06-16  9:54 ` Akhil R
2026-06-16  9:54 ` [PATCH v4 01/12] dt-bindings: i3c: Add mipi-i3c-static-method to support SETAASA Akhil R
2026-06-16  9:54   ` Akhil R
2026-06-16 10:04   ` sashiko-bot
2026-06-16 10:04     ` sashiko-bot
2026-06-16  9:54 ` [PATCH v4 02/12] i3c: master: Use unified device property interface Akhil R
2026-06-16  9:54   ` Akhil R
2026-06-16 10:17   ` sashiko-bot
2026-06-16 10:17     ` sashiko-bot
2026-06-16  9:54 ` [PATCH v4 03/12] i3c: master: Support ACPI enumeration of child devices Akhil R
2026-06-16  9:54   ` Akhil R
2026-06-16 10:15   ` sashiko-bot
2026-06-16 10:15     ` sashiko-bot
2026-06-16  9:54 ` [PATCH v4 04/12] i3c: master: Add support for devices using SETAASA Akhil R
2026-06-16  9:54   ` Akhil R
2026-06-16 10:19   ` sashiko-bot
2026-06-16 10:19     ` sashiko-bot
2026-06-16  9:54 ` [PATCH v4 05/12] i3c: master: Add support for devices without PID Akhil R
2026-06-16  9:54   ` Akhil R
2026-06-16 10:17   ` sashiko-bot
2026-06-16 10:17     ` sashiko-bot
2026-06-16  9:54 ` [PATCH v4 06/12] i3c: master: match I3C device through DT and ACPI Akhil R
2026-06-16  9:54   ` Akhil R
2026-06-16 10:12   ` sashiko-bot
2026-06-16 10:12     ` sashiko-bot
2026-06-16  9:54 ` [PATCH v4 07/12] i3c: dw-i3c-master: Add SETAASA as supported CCC Akhil R
2026-06-16  9:54   ` Akhil R
2026-06-16 10:13   ` sashiko-bot
2026-06-16 10:13     ` sashiko-bot
2026-06-16  9:54 ` [PATCH v4 08/12] i3c: dw-i3c-master: Add a quirk to skip clock and reset Akhil R
2026-06-16  9:54   ` Akhil R
2026-06-16 10:14   ` sashiko-bot
2026-06-16 10:14     ` sashiko-bot
2026-06-16  9:54 ` [PATCH v4 09/12] i3c: dw-i3c-master: Add ACPI ID for Tegra410 Akhil R
2026-06-16  9:54   ` Akhil R
2026-06-16 10:09   ` sashiko-bot
2026-06-16 10:09     ` sashiko-bot
2026-06-16  9:54 ` [PATCH v4 10/12] hwmon: spd5118: Remove 16-bit addressing Akhil R
2026-06-16  9:54   ` Akhil R
2026-06-16 10:09   ` sashiko-bot
2026-06-16 10:09     ` sashiko-bot
2026-06-16  9:54 ` [PATCH v4 11/12] hwmon: spd5118: Add I3C support Akhil R
2026-06-16  9:54   ` Akhil R
2026-06-16 10:30   ` sashiko-bot [this message]
2026-06-16 10:30     ` sashiko-bot
2026-06-16  9:54 ` [PATCH v4 12/12] arm64: defconfig: Enable I3C and SPD5118 hwmon Akhil R
2026-06-16  9:54   ` Akhil R
2026-06-16 10:10   ` sashiko-bot
2026-06-16 10:10     ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260616103056.6F6161F00A3D@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=akhilrajeev@nvidia.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-i3c@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.