From: sashiko-bot@kernel.org
To: Frank.Li@oss.nxp.com
Cc: Frank.Li@kernel.org, imx@lists.linux.dev, robh@kernel.org,
devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 09/11] ARM: configs: lpc*: Remove NOMMU platform support
Date: Fri, 19 Jun 2026 15:53:21 +0000 [thread overview]
Message-ID: <20260619155322.406721F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260619-dts_cleanup_arm_mcore-v1-9-0101795a2662@nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The commit message incorrectly categorizes LPC32xx as a NOMMU platform, using this false premise to justify deleting its defconfig and support.
--
commit dd95b6d6b05d88a43de62ac58a8d3da5f10168ac
Author: Frank Li <Frank.Li@nxp.com>
ARM: configs: lpc*: Remove NOMMU platform support
This commit removes the lpc18xx and lpc32xx default configurations,
justifying the removal by stating that commercial users of these NOMMU
platforms have migrated to RTOS solutions.
> Commercial users and hardware vendors migrated to Zephyr or other RTOS
> solutions years ago, leaving the NOMMU platform support effectively
> unused and unmaintained.
[ ... ]
> diff --git a/arch/arm/configs/lpc32xx_defconfig b/arch/arm/configs/lpc32xx_defconfig
> deleted file mode 100644
> index b9e2e603cd95e..0000000000000
> --- a/arch/arm/configs/lpc32xx_defconfig
> +++ /dev/null
> @@ -1,192 +0,0 @@
> -CONFIG_SYSVIPC=y
[ ... ]
> -CONFIG_EXPERT=y
> -# CONFIG_ARCH_MULTI_V7 is not set
> -CONFIG_ARCH_LPC32XX=y
[Severity: High]
Is the commit message description accurate for LPC32xx?
While LPC18xx is a NOMMU platform, LPC32xx is based on the ARM926EJ-S
processor which features a Memory Management Unit (MMU) and runs standard
Linux rather than an RTOS.
Unlike lpc18xx_defconfig which explicitly unsets CONFIG_MMU, this
configuration leaves CONFIG_MMU enabled by default and relies on standard
Linux features like CONFIG_SYSVIPC.
Could removing an MMU-capable platform under the assumption that it is a
deprecated NOMMU target bypass the proper evaluation process for standard
Linux platforms?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260619-dts_cleanup_arm_mcore-v1-0-0101795a2662@nxp.com?part=9
next prev parent reply other threads:[~2026-06-19 15:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-19 15:40 [PATCH 00/11] ARM: NXP: Drop NOMMU platform support Frank.Li
2026-06-19 15:40 ` [PATCH 01/11] ARM: dts: vf610m4: Remove " Frank.Li
2026-06-19 15:52 ` sashiko-bot
2026-06-19 15:40 ` [PATCH 02/11] ARM: dts: imxrt1050: " Frank.Li
2026-06-19 15:41 ` [PATCH 03/11] ARM: imx: " Frank.Li
2026-06-19 15:41 ` [PATCH 04/11] clk: imx: imxrt1050: " Frank.Li
2026-06-19 15:54 ` sashiko-bot
2026-06-19 15:41 ` [PATCH 05/11] pinctrl: freescale: IMXRT: " Frank.Li
2026-06-19 15:41 ` [PATCH 06/11] ARM: imxrt_defconfig: " Frank.Li
2026-06-19 15:55 ` sashiko-bot
2026-06-19 15:41 ` [PATCH 07/11] ARM: dts: lpc: " Frank.Li
2026-06-19 15:50 ` sashiko-bot
2026-06-19 15:41 ` [PATCH 08/11] ARM: mach-lpc: " Frank.Li
2026-06-19 16:00 ` sashiko-bot
2026-06-19 15:41 ` [PATCH 09/11] ARM: configs: lpc*: " Frank.Li
2026-06-19 15:53 ` sashiko-bot [this message]
2026-06-19 15:41 ` [PATCH 10/11] clk: nxp: lpc: " Frank.Li
2026-06-19 15:58 ` sashiko-bot
2026-06-19 15:41 ` [PATCH 11/11] pinctrl: " Frank.Li
2026-06-19 16:07 ` [PATCH 00/11] ARM: NXP: Drop " Vladimir Zapolskiy
2026-06-19 19:17 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260619155322.406721F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=Frank.Li@oss.nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.