Re: [PATCH 04/11] clk: imx: imxrt1050: Remove NOMMU platform support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Deleting the `include/dt-bindings/clock/imxrt1050-clock.h` header breaks `make dt_binding_check` because the header is still included in the YAML binding example.
- [Low] Incomplete cleanup: Defconfig for the removed vf610m4 platform was left behind.
--

commit 19efb4118fc745b70a599c1f992b0e4fad42b13c
Author: Frank Li <Frank.Li@nxp.com>

clk: imx: imxrt1050: Remove NOMMU platform support

This commit removes the IMXRT1050 CCM clock driver and its device tree
binding header. This is part of dropping unused NOMMU platform support
from the kernel.

> diff --git a/include/dt-bindings/clock/imxrt1050-clock.h b/include/dt-bindings/clock/imxrt1050-clock.h
> deleted file mode 100644
> index 93bef0832d16d..0000000000000
> --- a/include/dt-bindings/clock/imxrt1050-clock.h
> +++ /dev/null
> @@ -1,72 +0,0 @@
> -/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */
> -/*
> - * Copyright(C) 2019
> - * Author(s): Giulio Benetti <giulio.benetti@benettiengineering.com>
> - */
> -
> -#ifndef __DT_BINDINGS_CLOCK_IMXRT1050_H
> -#define __DT_BINDINGS_CLOCK_IMXRT1050_H

[Severity: Low]
Does deleting this header break make dt_binding_check?

The Documentation/devicetree/bindings/clock/imxrt1050-clock.yaml file
still includes this header in its examples section:

Documentation/devicetree/bindings/clock/imxrt1050-clock.yaml:examples()
    examples:
      - |
        #include <dt-bindings/clock/imxrt1050-clock.h>

If the YAML file is not removed or updated, make dt_binding_check will fail
with a missing file error when extracting and building the example.

[ ... ]

[Severity: Low]
Does this series miss cleaning up the vf610m4_defconfig file?

Since the patch series removes NOMMU platform support, including the
vf610m4 device tree files, should arch/arm/configs/vf610m4_defconfig
also be removed? It configures the kernel for the vf610m4 NOMMU platform
and appears to be left behind as an unused configuration.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260619-dts_cleanup_arm_mcore-v1-0-0101795a2662@nxp.com?part=4