From: sashiko-bot@kernel.org
To: Frank.Li@oss.nxp.com
Cc: imx@lists.linux.dev, devicetree@vger.kernel.org,
Frank.Li@kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 06/11] ARM: imxrt_defconfig: Remove NOMMU platform support
Date: Fri, 19 Jun 2026 15:55:33 +0000 [thread overview]
Message-ID: <20260619155534.34F1C1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260619-dts_cleanup_arm_mcore-v1-6-0101795a2662@nxp.com>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Leftover references, platform-specific structures, compatible strings, and early console declarations for the removed i.MXRT and VF610M4 platforms remain in multiple drivers and DT bindings.
- [Low] Deleted clock dt-binding header is still included in the `imxrt1050-clock.yaml` dt-binding YAML example, breaking `dt_binding_check`.
--
commit 3968f192513e74f4358aed03401b5e2ab20e266b
Author: Frank Li <Frank.Li@nxp.com>
ARM: imxrt_defconfig: Remove NOMMU platform support
Commercial users and hardware vendors migrated to Zephyr or other RTOS
solutions years ago, leaving the NOMMU platform support effectively
unused and unmaintained.
> Remove the obsolete support to reduce maintenance burden and simplify the
> i.MX platform code.
[Severity: Medium]
Since this series removes the NOMMU platform support for i.MXRT and VF610M4,
should the remaining platform-specific structures and references also be
cleaned up?
There are leftover configurations such as usdhc_imxrt1050_data in
drivers/mmc/host/sdhci-esdhc-imx.c:
static struct esdhc_soc_data usdhc_imxrt1050_data = {
imxrt1050_data in drivers/tty/serial/fsl_lpuart.c:
static const struct lpuart_soc_data imxrt1050_data = {
early console declarations in drivers/tty/serial/fsl_lpuart.c:
OF_EARLYCON_DECLARE(lpuart32, "fsl,imxrt1050-lpuart", lpuart32_imx_early_console_setup);
and the fsl,vf610m4 compatibility string in arch/arm/mach-imx/mach-vf610.c:
"fsl,vf610m4",
Because the core architecture files and Kconfigs are removed, these remnants
become unreachable orphaned dead code.
[Severity: Low]
Does this series also need to update the dt-binding examples?
The deleted include/dt-bindings/clock/imxrt1050-clock.h header is still
included in the Documentation/devicetree/bindings/clock/imxrt1050-clock.yaml
example block:
#include <dt-bindings/clock/imxrt1050-clock.h>
When the dt_binding_check target attempts to preprocess this YAML example,
the C preprocessor fails with a "No such file or directory" error.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260619-dts_cleanup_arm_mcore-v1-0-0101795a2662@nxp.com?part=6
next prev parent reply other threads:[~2026-06-19 15:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-19 15:40 [PATCH 00/11] ARM: NXP: Drop NOMMU platform support Frank.Li
2026-06-19 15:40 ` [PATCH 01/11] ARM: dts: vf610m4: Remove " Frank.Li
2026-06-19 15:52 ` sashiko-bot
2026-06-19 15:40 ` [PATCH 02/11] ARM: dts: imxrt1050: " Frank.Li
2026-06-19 15:41 ` [PATCH 03/11] ARM: imx: " Frank.Li
2026-06-19 15:41 ` [PATCH 04/11] clk: imx: imxrt1050: " Frank.Li
2026-06-19 15:54 ` sashiko-bot
2026-06-19 15:41 ` [PATCH 05/11] pinctrl: freescale: IMXRT: " Frank.Li
2026-06-19 15:41 ` [PATCH 06/11] ARM: imxrt_defconfig: " Frank.Li
2026-06-19 15:55 ` sashiko-bot [this message]
2026-06-19 15:41 ` [PATCH 07/11] ARM: dts: lpc: " Frank.Li
2026-06-19 15:50 ` sashiko-bot
2026-06-19 15:41 ` [PATCH 08/11] ARM: mach-lpc: " Frank.Li
2026-06-19 16:00 ` sashiko-bot
2026-06-19 15:41 ` [PATCH 09/11] ARM: configs: lpc*: " Frank.Li
2026-06-19 15:53 ` sashiko-bot
2026-06-19 15:41 ` [PATCH 10/11] clk: nxp: lpc: " Frank.Li
2026-06-19 15:58 ` sashiko-bot
2026-06-19 15:41 ` [PATCH 11/11] pinctrl: " Frank.Li
2026-06-19 16:07 ` [PATCH 00/11] ARM: NXP: Drop " Vladimir Zapolskiy
2026-06-19 19:17 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260619155534.34F1C1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=Frank.Li@oss.nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.