All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: jaegeuk@kernel.org
Cc: Deepanshu Kartikey <kartikey406@gmail.com>,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH] Revert "f2fs: initialize ino_entry_info before checkpoint load"
Date: Mon, 22 Jun 2026 01:04:27 +0000	[thread overview]
Message-ID: <20260622010427.2273254-1-chao@kernel.org> (raw)

This reverts commit 065a6f8cd23a9297b543dcec913feb3cb787a25e.

f2fs_drop_inode() won't call f2fs_exist_written_data() as commit 3063c80776e3
("f2fs: another way to set large folio by remembering inode number") was
dropped from the tree.

Cc: Deepanshu Kartikey <kartikey406@gmail.com>
Signed-off-by: Chao Yu <chao@kernel.org>
---
 fs/f2fs/super.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 615a071f9605..c448d992ff2a 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -5170,13 +5170,6 @@ static int f2fs_fill_super(struct super_block *sb, struct fs_context *fc)
 		goto free_page_array_cache;
 	}
 
-	/*
-	 * Initialize ino entry info early so f2fs_drop_inode ->
-	 * f2fs_exist_written_data can safely take im->ino_lock if mount
-	 * fails after this point and triggers iput on cleanup.
-	 */
-	f2fs_init_ino_entry_info(sbi);
-
 	err = f2fs_get_valid_checkpoint(sbi);
 	if (err) {
 		f2fs_err(sbi, "Failed to get valid F2FS checkpoint");
@@ -5221,6 +5214,8 @@ static int f2fs_fill_super(struct super_block *sb, struct fs_context *fc)
 
 	f2fs_init_extent_cache_info(sbi);
 
+	f2fs_init_ino_entry_info(sbi);
+
 	f2fs_init_fsync_node_info(sbi);
 
 	/* setup checkpoint request control and start checkpoint issue thread */
-- 
2.49.0



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, Chao Yu <chao@kernel.org>,
	Deepanshu Kartikey <kartikey406@gmail.com>
Subject: [PATCH] Revert "f2fs: initialize ino_entry_info before checkpoint load"
Date: Mon, 22 Jun 2026 01:04:27 +0000	[thread overview]
Message-ID: <20260622010427.2273254-1-chao@kernel.org> (raw)

This reverts commit 065a6f8cd23a9297b543dcec913feb3cb787a25e.

f2fs_drop_inode() won't call f2fs_exist_written_data() as commit 3063c80776e3
("f2fs: another way to set large folio by remembering inode number") was
dropped from the tree.

Cc: Deepanshu Kartikey <kartikey406@gmail.com>
Signed-off-by: Chao Yu <chao@kernel.org>
---
 fs/f2fs/super.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 615a071f9605..c448d992ff2a 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -5170,13 +5170,6 @@ static int f2fs_fill_super(struct super_block *sb, struct fs_context *fc)
 		goto free_page_array_cache;
 	}
 
-	/*
-	 * Initialize ino entry info early so f2fs_drop_inode ->
-	 * f2fs_exist_written_data can safely take im->ino_lock if mount
-	 * fails after this point and triggers iput on cleanup.
-	 */
-	f2fs_init_ino_entry_info(sbi);
-
 	err = f2fs_get_valid_checkpoint(sbi);
 	if (err) {
 		f2fs_err(sbi, "Failed to get valid F2FS checkpoint");
@@ -5221,6 +5214,8 @@ static int f2fs_fill_super(struct super_block *sb, struct fs_context *fc)
 
 	f2fs_init_extent_cache_info(sbi);
 
+	f2fs_init_ino_entry_info(sbi);
+
 	f2fs_init_fsync_node_info(sbi);
 
 	/* setup checkpoint request control and start checkpoint issue thread */
-- 
2.49.0


             reply	other threads:[~2026-06-22  1:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-22  1:04 Chao Yu via Linux-f2fs-devel [this message]
2026-06-22  1:04 ` [PATCH] Revert "f2fs: initialize ino_entry_info before checkpoint load" Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260622010427.2273254-1-chao@kernel.org \
    --to=linux-f2fs-devel@lists.sourceforge.net \
    --cc=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=kartikey406@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.