[f2fs-dev] [PATCH] Revert "f2fs: initialize ino_entry_info before checkpoint load"

[f2fs-dev] [PATCH] Revert "f2fs: initialize ino_entry_info before checkpoint load"

[Chao Yu via Linux-f2fs-devel]

This reverts commit 065a6f8cd23a9297b543dcec913feb3cb787a25e.

f2fs_drop_inode() won't call f2fs_exist_written_data() as commit 3063c80776e3
("f2fs: another way to set large folio by remembering inode number") was
dropped from the tree.

Cc: Deepanshu Kartikey <kartikey406@gmail.com>
Signed-off-by: Chao Yu <chao@kernel.org>
---
 fs/f2fs/super.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 615a071f9605..c448d992ff2a 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -5170,13 +5170,6 @@ static int f2fs_fill_super(struct super_block *sb, struct fs_context *fc)
 		goto free_page_array_cache;
 	}
 
-	/*
-	 * Initialize ino entry info early so f2fs_drop_inode ->
-	 * f2fs_exist_written_data can safely take im->ino_lock if mount
-	 * fails after this point and triggers iput on cleanup.
-	 */
-	f2fs_init_ino_entry_info(sbi);
-
 	err = f2fs_get_valid_checkpoint(sbi);
 	if (err) {
 		f2fs_err(sbi, "Failed to get valid F2FS checkpoint");
@@ -5221,6 +5214,8 @@ static int f2fs_fill_super(struct super_block *sb, struct fs_context *fc)
 
 	f2fs_init_extent_cache_info(sbi);
 
+	f2fs_init_ino_entry_info(sbi);
+
 	f2fs_init_fsync_node_info(sbi);
 
 	/* setup checkpoint request control and start checkpoint issue thread */
-- 
2.49.0



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[PATCH] Revert "f2fs: initialize ino_entry_info before checkpoint load"

[Chao Yu]

This reverts commit 065a6f8cd23a9297b543dcec913feb3cb787a25e.

f2fs_drop_inode() won't call f2fs_exist_written_data() as commit 3063c80776e3
("f2fs: another way to set large folio by remembering inode number") was
dropped from the tree.

Cc: Deepanshu Kartikey <kartikey406@gmail.com>
Signed-off-by: Chao Yu <chao@kernel.org>
---
 fs/f2fs/super.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 615a071f9605..c448d992ff2a 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -5170,13 +5170,6 @@ static int f2fs_fill_super(struct super_block *sb, struct fs_context *fc)
 		goto free_page_array_cache;
 	}
 
-	/*
-	 * Initialize ino entry info early so f2fs_drop_inode ->
-	 * f2fs_exist_written_data can safely take im->ino_lock if mount
-	 * fails after this point and triggers iput on cleanup.
-	 */
-	f2fs_init_ino_entry_info(sbi);
-
 	err = f2fs_get_valid_checkpoint(sbi);
 	if (err) {
 		f2fs_err(sbi, "Failed to get valid F2FS checkpoint");
@@ -5221,6 +5214,8 @@ static int f2fs_fill_super(struct super_block *sb, struct fs_context *fc)
 
 	f2fs_init_extent_cache_info(sbi);
 
+	f2fs_init_ino_entry_info(sbi);
+
 	f2fs_init_fsync_node_info(sbi);
 
 	/* setup checkpoint request control and start checkpoint issue thread */
-- 
2.49.0