Re: [PATCH v4 02/13] perf test: Truncate test description to fit terminal width

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing explicit inclusion of `<stdio.h>` for POSIX standard I/O functions.
--

commit a38919168aca480a6e9314b30b0c93edcb90fb79
Author: Ian Rogers <irogers@google.com>

perf test: Truncate test description to fit terminal width

This commit addresses an issue with the parallel test harness where long test
descriptions wrap around and cause output corruption. It fixes this by
querying terminal dimensions and dynamically truncating test descriptions.

> diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
> index 7e75f590f225e..8b8f63f706d93 100644
> --- a/tools/perf/tests/builtin-test.c
> +++ b/tools/perf/tests/builtin-test.c

[ ... ]

> @@ -415,73 +418,73 @@ static char *xml_escape(const char *str)
>  	return res ? res : strdup("");
>  }
>  
> -static const char *format_test_description(const char *desc, int max_desc_width,
> -					  char *buf, size_t buf_sz)
> +static int get_term_width(void)
>  {
> -	int len = strlen(desc);
> +	struct winsize ws;
> +	int cols = 80;
> +	int term_width;
>  
>  	/*
> -	 * Clamp to buf_sz to prevent GCC format-truncation warnings
> -	 * when terminal width is very large.
> +	 * If output is redirected to a file or piped, we don't need to wrap
> +	 * or truncate at all. Use a massive virtually infinite terminal width
> +	 * so descriptions are printed in full.
>  	 */
> -	if (max_desc_width >= (int)buf_sz)
> -		max_desc_width = buf_sz - 1;
> +	if (!isatty(fileno(debug_file())))
> +		return 10000;

[Severity: Low]
Does this new call to fileno() need an explicit include for <stdio.h> at the
top of the file to ensure it builds correctly under musl libc?

This file already lacked the <stdio.h> header, but since musl libc strictly
separates declarations rather than relying on implicit inclusions, this new
POSIX standard I/O function call might cause build failures without it.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260623012758.2291858-1-irogers@google.com?part=2