Re: [PATCH v2 5/5] mmc: sdhci-esdhc-imx: fix suspend/resume error handling

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Early return on pm_runtime_force_resume() failure bypasses critical software state cleanup, causing resource leaks and unbalanced IRQ/wakeup state.
--

commit ed7f6495b612b03d62a8e94345ad954b930909de
Author: Luke Wang <ziniu.wang_1@nxp.com>

mmc: sdhci-esdhc-imx: fix suspend/resume error handling

This commit updates the suspend and resume error handling paths in the
sdhci-esdhc-imx driver. It replaces pm_runtime_get_sync() with
pm_runtime_resume_and_get() in suspend, logs warnings instead of failing
for non-fatal errors, and adds a failure check for
pm_runtime_force_resume() in resume.

> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
[ ... ]
> @@ -2121,12 +2125,12 @@ static int sdhci_esdhc_resume(struct device *dev)
>  			dev_warn(dev, "Failed to restore pinctrl state\n");
>  	}
>  
> -	pm_runtime_force_resume(dev);
> -
> -	ret = mmc_gpio_set_cd_wake(host->mmc, false);
> +	ret = pm_runtime_force_resume(dev);
>  	if (ret)
>  		return ret;

[Severity: Medium]
Does this early return bypass critical cleanup steps that are required later
in the function?

When sdhci_esdhc_suspend() is called, it disables the interrupt using
disable_irq() and increments the runtime PM usage counter via
pm_runtime_resume_and_get(). 

If pm_runtime_force_resume() fails here and we return immediately, the
required enable_irq() and pm_runtime_put_autosuspend() calls at the end of
sdhci_esdhc_resume() are skipped.

Will this leave the interrupt depth unbalanced and leak the runtime PM usage
counter that was acquired during suspend?

>  
> +	mmc_gpio_set_cd_wake(host->mmc, false);
> +
>  	/* re-initialize hw state in case it's lost in low power mode */
>  	sdhci_esdhc_imx_hwinit(host);
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260625105934.2890635-1-ziniu.wang_1@oss.nxp.com?part=5