Re: [PATCH v2 1/5] mmc: sdhci-esdhc-imx: remove unnecessary mmc_card_wake_sdio_irq check for tuning save/restore

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] If `pm_runtime_force_resume()` fails in `sdhci_esdhc_resume()`, the function returns early without cleaning up software resources, leaking a runtime PM usage counter and leaving the device IRQ permanently disabled.
--

commit 49c3beebc2517e065c8ac10ff38587704b7567c1
Author: Luke Wang <ziniu.wang_1@nxp.com>

mmc: sdhci-esdhc-imx: remove unnecessary mmc_card_wake_sdio_irq check for tuning save/restore

This commit removes the mmc_card_wake_sdio_irq check during suspend
and resume for SDIO devices, as power is maintained even without the
SDIO IRQ wake flag. This ensures tuning delay values are properly
saved and restored.

> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index 18ecddd6df6f2..6526d65538de5 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c

[ ... ]

> @@ -2124,8 +2123,7 @@ static int sdhci_esdhc_resume(struct device *dev)
>  	 * restore the saved tuning delay value for the device which keep
>  	 * power during system PM.
>  	 */
> -	if (mmc_card_keep_power(host->mmc) && mmc_card_wake_sdio_irq(host->mmc) &&
> -	    esdhc_is_usdhc(imx_data))
> +	if (mmc_card_keep_power(host->mmc) && esdhc_is_usdhc(imx_data))
>  		sdhc_esdhc_tuning_restore(host);
>  
>  	pm_runtime_put_autosuspend(dev);

[Severity: High]
This is a pre-existing issue, but I noticed a potential resource leak in
sdhci_esdhc_resume(). Does an early return on pm_runtime_force_resume()
failure skip cleaning up software state?

During system suspend, sdhci_esdhc_suspend() increments the runtime PM
usage count and disables the device IRQ:

sdhci_esdhc_suspend() {
    ...
    ret = pm_runtime_resume_and_get(dev);
    if (ret)
        return ret;
    ...
    disable_irq(host->irq);
}

During system resume, if pm_runtime_force_resume() fails, the function
returns early:

sdhci_esdhc_resume() {
    ...
    ret = pm_runtime_force_resume(dev);
    if (ret)
        return ret;
    ...
    enable_irq(host->irq);
    ...
    pm_runtime_put_autosuspend(dev);
}

If the early return is taken, does this leave the IRQ permanently disabled
and the PM usage counter unbalanced, potentially preventing the device and
its parent power domains from entering low-power states?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260625105934.2890635-1-ziniu.wang_1@oss.nxp.com?part=1