Re: [PATCH v2 3/5] mmc: sdhci-esdhc-imx: restore pinctrl before restoring ios timing on resume

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Spurious 'Failed to restore pinctrl state' warning on system resume for non-UHS boards.
--

commit fb950cf1f88eea6f31025c4c19f7095c516420f2
Author: Luke Wang <ziniu.wang_1@nxp.com>

mmc: sdhci-esdhc-imx: restore pinctrl before restoring ios timing on resume

This commit restores the pinctrl state based on the current timing mode
before calling pm_runtime_force_resume() to avoid persistent read CRC
errors. It targets non-wakeup devices, ensuring the correct pin
configuration is applied before DDR_EN is set.

> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index a944351dbcdff..7fcaecdd4ec61 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -2114,6 +2114,12 @@ static int sdhci_esdhc_resume(struct device *dev)
>  	struct pltfm_imx_data *imx_data = sdhci_pltfm_priv(pltfm_host);
>  	int ret;
>  
> +	if (!device_may_wakeup(dev)) {
> +		ret = esdhc_change_pinstate(host, host->timing);
> +		if (ret)
> +			dev_warn(dev, "Failed to restore pinctrl state\n");

[Severity: Medium]
Will this cause spurious warnings on every system resume for non-UHS boards?

Looking at esdhc_change_pinstate(), it returns -EINVAL if the optional
pins_100mhz or pins_200mhz states are missing from the device tree:

static int esdhc_change_pinstate(struct sdhci_host *host,
                                 unsigned int uhs)
{
        ...
        if (IS_ERR(imx_data->pinctrl) ||
            IS_ERR(imx_data->pins_100mhz) ||
            IS_ERR(imx_data->pins_200mhz))
                return -EINVAL;
        ...
}

Could this unconditionally trigger the dev_warn() here for completely valid
legacy SD or eMMC DDR52 configurations, leading to kernel log spam on every
system resume cycle?

> +	}
> +
>  	pm_runtime_force_resume(dev);
>  
>  	ret = mmc_gpio_set_cd_wake(host->mmc, false);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260625105934.2890635-1-ziniu.wang_1@oss.nxp.com?part=3