All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Joanne Koong <joannelkoong@gmail.com>
Cc: hch@lst.de, willy@infradead.org, djwong@kernel.org,
	linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [RFC PATCH v1 1/3] iomap: add ->iomap_next() and iomap_process() helper
Date: Thu, 25 Jun 2026 14:56:56 +0200	[thread overview]
Message-ID: <20260625125656.GA22620@lst.de> (raw)
In-Reply-To: <20260625024723.1611000-2-joannelkoong@gmail.com>

> +	/*
> +	 * Produce the next mapping (finishing the previous one if needed).
> +	 * Return 1 to continue iterating, 0 if the range is fully consumed,
> +	 * or a negative error on failure.
> +	 */
> +	int (*iomap_next)(const struct iomap_iter *iter, struct iomap *iomap,
> +			struct iomap *srcmap);

If you add function typedefs for all the other two methods I'd one one here
as well for consistency.  We'll need it anywone once the legacy ops are
entirely gone we can kill of the ops and just pass this function pointer.

As for the arguments:  I don't really see much of a point in passing
the iomap/scrmap separately vs just the iter.  Or am I missing something
here?


  reply	other threads:[~2026-06-25 12:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-25  2:47 [RFC PATCH v1 0/3] iomap: convert to in-iter ->iomap_next() model Joanne Koong
2026-06-25  2:47 ` [RFC PATCH v1 1/3] iomap: add ->iomap_next() and iomap_process() helper Joanne Koong
2026-06-25 12:56   ` Christoph Hellwig [this message]
2026-06-25 21:03     ` Joanne Koong
2026-06-26  5:12       ` Christoph Hellwig
2026-06-25  2:47 ` [RFC PATCH v1 2/3] xfs: convert read and buffered write iomap ops to ->iomap_next() Joanne Koong
2026-06-25  2:47 ` [RFC PATCH v1 3/3] xfs: example of devirtualizing buffered write iomap callbacks Joanne Koong
2026-06-25 13:00   ` Christoph Hellwig
2026-06-25 20:46     ` Joanne Koong
2026-06-25  3:25 ` [RFC PATCH v1 0/3] iomap: convert to in-iter ->iomap_next() model Gao Xiang
2026-06-25  3:37   ` Gao Xiang
2026-06-25 13:02   ` Christoph Hellwig
2026-06-25 13:21     ` Gao Xiang
2026-06-25 21:33       ` Joanne Koong
2026-06-26  2:22         ` Gao Xiang
2026-06-26  5:10           ` Christoph Hellwig
2026-06-26  5:35             ` Gao Xiang
2026-06-26  5:38               ` Christoph Hellwig
2026-06-25 13:03 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260625125656.GA22620@lst.de \
    --to=hch@lst.de \
    --cc=djwong@kernel.org \
    --cc=joannelkoong@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.