All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: Joanne Koong <joannelkoong@gmail.com>,
	Christoph Hellwig <hch@lst.de>,
	willy@infradead.org, djwong@kernel.org,
	linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [RFC PATCH v1 0/3] iomap: convert to in-iter ->iomap_next() model
Date: Fri, 26 Jun 2026 07:10:04 +0200	[thread overview]
Message-ID: <20260626051004.GA8968@lst.de> (raw)
In-Reply-To: <9bfa2c7a-1b17-41c5-9846-340e6a5b4b66@linux.alibaba.com>

On Fri, Jun 26, 2026 at 10:22:17AM +0800, Gao Xiang wrote:
> It's just my rough thought, as I said in the previous year, I
> still don't have a strong tendency but it's my suggestion over
> these years.
>
> Anyway since you're actively working/changing on iomap, so
> it's fine to just respect your ideas/efforts if you don't
> think it's worth, but as a record of my thoughts here again.

This does sound like a lot of work, and I'm not a 100% sold on
the benefits, although getting rid of callbacks would be nice.

I'd be tempted to say that as a first step we should move the the
single callback, as a second stop (after converting everyone to
the single callback) to inline for performance critical path, and
then see if we can massage it into a pure iterator without much
downside instead of trying to do everything at once.

As you seem to have the strongest opinion here, I'd love to see
a proof of concept from you to get everyone excited.


  reply	other threads:[~2026-06-26  5:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-25  2:47 [RFC PATCH v1 0/3] iomap: convert to in-iter ->iomap_next() model Joanne Koong
2026-06-25  2:47 ` [RFC PATCH v1 1/3] iomap: add ->iomap_next() and iomap_process() helper Joanne Koong
2026-06-25 12:56   ` Christoph Hellwig
2026-06-25 21:03     ` Joanne Koong
2026-06-26  5:12       ` Christoph Hellwig
2026-06-25  2:47 ` [RFC PATCH v1 2/3] xfs: convert read and buffered write iomap ops to ->iomap_next() Joanne Koong
2026-06-25  2:47 ` [RFC PATCH v1 3/3] xfs: example of devirtualizing buffered write iomap callbacks Joanne Koong
2026-06-25 13:00   ` Christoph Hellwig
2026-06-25 20:46     ` Joanne Koong
2026-06-25  3:25 ` [RFC PATCH v1 0/3] iomap: convert to in-iter ->iomap_next() model Gao Xiang
2026-06-25  3:37   ` Gao Xiang
2026-06-25 13:02   ` Christoph Hellwig
2026-06-25 13:21     ` Gao Xiang
2026-06-25 21:33       ` Joanne Koong
2026-06-26  2:22         ` Gao Xiang
2026-06-26  5:10           ` Christoph Hellwig [this message]
2026-06-26  5:35             ` Gao Xiang
2026-06-26  5:38               ` Christoph Hellwig
2026-06-25 13:03 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260626051004.GA8968@lst.de \
    --to=hch@lst.de \
    --cc=djwong@kernel.org \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=joannelkoong@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.